From 957665c172674e543147dcdfda50accf12bfb892 Mon Sep 17 00:00:00 2001 From: Alain Magloire Date: Wed, 6 Jul 2005 17:42:22 +0000 Subject: [PATCH] 2005-07-06 Alain Magloire Fix PR 99130: no leading underscore in the guard header name * src/org/eclipse/cdt/internal/ui/wizards/filewizard/NewSourceFIleGenerator.java --- core/org.eclipse.cdt.ui/ChangeLog | 4 ++++ .../ui/wizards/filewizard/NewSourceFileGenerator.java | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/core/org.eclipse.cdt.ui/ChangeLog b/core/org.eclipse.cdt.ui/ChangeLog index ac03dec326a..b670984696b 100644 --- a/core/org.eclipse.cdt.ui/ChangeLog +++ b/core/org.eclipse.cdt.ui/ChangeLog @@ -1,3 +1,7 @@ +2005-07-06 Alain Magloire + Fix PR 99130: no leading underscore in the guard header name + * src/org/eclipse/cdt/internal/ui/wizards/filewizard/NewSourceFIleGenerator.java + 2005-07-06 Alain Magloire PR 102789: Add Include dialog typo * src/org/eclipse/cdt/internal/ui/editor/AddIncludeOnSelectionAction.java diff --git a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/wizards/filewizard/NewSourceFileGenerator.java b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/wizards/filewizard/NewSourceFileGenerator.java index 158e9281cab..b5056c5b17c 100644 --- a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/wizards/filewizard/NewSourceFileGenerator.java +++ b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/wizards/filewizard/NewSourceFileGenerator.java @@ -80,7 +80,8 @@ public class NewSourceFileGenerator { //convert to upper case and remove invalid characters //eg convert foo.h --> _FOO_H_ StringBuffer buf = new StringBuffer(); - buf.append('_'); + // Do not do this, leading underscores are discourage by the std. + //buf.append('_'); for (int i = 0; i < name.length(); ++i) { char ch = name.charAt(i); if (Character.isLetterOrDigit(ch)) {