mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-23 17:05:26 +02:00
Code Issues Wiki Activity

Disable remote detach test case for 7.5

Browse source 
With gdbserver 7.5, detaching from a process leaves gdbserver hanging
which prevents the next testcase from running.

We therefore disable the two detach testcases for version 7.5 only.
Note that we cannot simply @ignore the testcases since we want to run
them for the local case, even for version 7.5.

Change-Id: Id4b69420abd1218be5eaf2c54a9f44349283edc2
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
This commit is contained in:
Marc Khouzam 2015-07-17 08:41:07 -04:00 • committed by Gerrit Code Review @ Eclipse.org
parent 00b591ae89
commit 93df44a4ca
2 changed files with 31 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_7_5/OperationsWhileTargetIsRunningTest_7_5.java
View file

@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2012 Ericsson and others.
* Copyright (c) 2012, 2015 Ericsson and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
@ -22,4 +22,27 @@ public class OperationsWhileTargetIsRunningTest_7_5 extends OperationsWhileTarge
protected void setGdbVersion() {
setGdbProgramNamesLaunchAttributes(ITestConstants.SUFFIX_GDB_7_5);
}
@Override
public void detachWhileTargetRunningGDBAlive() throws Throwable {
if (isRemoteSession() && isRemoteDetachFailing()) {
return;
}
super.detachWhileTargetRunningGDBAlive();
}
@Override
public void detachWhileTargetRunningKillGDB() throws Throwable {
if (isRemoteSession() && isRemoteDetachFailing()) {
return;
}
super.detachWhileTargetRunningKillGDB();
}
public boolean isRemoteDetachFailing() {
// With GDB 7.5 in the remote case, the detach test
// case does not kill gdbserver which prevents the next
// testcase from passing.
return true;
}
}

8
dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_7_6/OperationsWhileTargetIsRunningTest_7_6.java
View file

@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2012 Ericsson and others.
* Copyright (c) 2012, 2015 Ericsson and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
@ -22,4 +22,10 @@ public class OperationsWhileTargetIsRunningTest_7_6 extends OperationsWhileTarge
protected void setGdbVersion() {
setGdbProgramNamesLaunchAttributes(ITestConstants.SUFFIX_GDB_7_6);
}
@Override
public boolean isRemoteDetachFailing() {
// This only fails for GDB 7.5
return false;
}
}