From 932f8290549b0cc708069480c319a858f3f0b885 Mon Sep 17 00:00:00 2001 From: Mikhail Khodjaiants Date: Mon, 27 Mar 2006 21:02:57 +0000 Subject: [PATCH] Cleaned up the "Session" class constructors. --- debug/org.eclipse.cdt.debug.mi.core/ChangeLog | 4 ++++ .../eclipse/cdt/debug/mi/core/cdi/Session.java | 15 ++++++++------- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/debug/org.eclipse.cdt.debug.mi.core/ChangeLog b/debug/org.eclipse.cdt.debug.mi.core/ChangeLog index ac6372bfed9..99e6c6dd085 100644 --- a/debug/org.eclipse.cdt.debug.mi.core/ChangeLog +++ b/debug/org.eclipse.cdt.debug.mi.core/ChangeLog @@ -1,3 +1,7 @@ +2006-03-27 Mikhail Khodjaiants + Cleaned up the "Session" class constructors. + * Session.java + 2006-03-27 Mikhail Khodjaiants Added the "getSessionConfiguration" method to allow clients to provide their own session configurations. * AbstractGDBCDIDebugger.java diff --git a/debug/org.eclipse.cdt.debug.mi.core/cdi/org/eclipse/cdt/debug/mi/core/cdi/Session.java b/debug/org.eclipse.cdt.debug.mi.core/cdi/org/eclipse/cdt/debug/mi/core/cdi/Session.java index b733e3fa34a..22d89bb72f1 100644 --- a/debug/org.eclipse.cdt.debug.mi.core/cdi/org/eclipse/cdt/debug/mi/core/cdi/Session.java +++ b/debug/org.eclipse.cdt.debug.mi.core/cdi/org/eclipse/cdt/debug/mi/core/cdi/Session.java @@ -43,26 +43,27 @@ public class Session implements ICDISession, ICDISessionObject { SourceManager sourceManager; ICDISessionConfiguration configuration; - public Session(MISession miSession, boolean attach) { + public Session(MISession miSession, ICDISessionConfiguration configuration) { commonSetup(); - //setConfiguration(new SessionConfiguration(this)); - Target target = new Target(this, miSession); addTargets(new Target[] { target }); + setConfiguration(configuration); + } + + // Why do we need this? + public Session(MISession miSession, boolean attach) { + this(miSession); } public Session(MISession miSession) { commonSetup(); - //setConfiguration(new CoreFileConfiguration()); - Target target = new Target(this, miSession); addTargets(new Target[] { target }); + setConfiguration(new SessionConfiguration(this)); } private void commonSetup() { props = new Properties(); - setConfiguration(new SessionConfiguration(this)); - processManager = new ProcessManager(this); breakpointManager = new BreakpointManager(this); eventManager = new EventManager(this);