mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

Bug 345687 - [fp] "No return, in function returning non-void" for

Browse source 
compound statement at the end
This commit is contained in:
Tomasz Wesolowski 2011-06-27 20:29:36 -04:00 • committed by Alena Laskavaia
parent 5343d22eea
commit 8ad690e18a
2 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/ReturnChecker.java
View file

@ -192,7 +192,7 @@ public class ReturnChecker extends AbstractAstFunctionChecker {
*/ */
private boolean isCompoundStatement(IASTStatement last) { private boolean isCompoundStatement(IASTStatement last) {
return last instanceof IASTIfStatement || last instanceof IASTWhileStatement || last instanceof IASTDoStatement return last instanceof IASTIfStatement || last instanceof IASTWhileStatement || last instanceof IASTDoStatement
|| last instanceof IASTForStatement || last instanceof IASTSwitchStatement; || last instanceof IASTForStatement || last instanceof IASTSwitchStatement || last instanceof IASTCompoundStatement;
} }
protected boolean isFuncExitStatement(IASTStatement statement) { protected boolean isFuncExitStatement(IASTStatement statement) {

10
codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/core/internal/checkers/ReturnCheckerTest.java
View file

@ -256,6 +256,16 @@ public class ReturnCheckerTest extends CheckerTestCase {
checkErrorLine(1); checkErrorLine(1);
} }
// int f345687() {
// {
// return 0;
// }
// }
public void testNextedBlock_Bug345687() {
loadCodeAndRunCpp(getAboveComment());
checkNoErrors();
}
// int // int
// fp_goto(int a) // fp_goto(int a)
// { // {