mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-09 18:56:02 +02:00
Code Issues Wiki Activity

Bug 294327 - [terminal][regression] After logging in, the remote prompt is hidden

Browse source
This commit is contained in:
Martin Oberhuber 2009-11-06 15:25:20 +00:00
parent e0a13b0c62
commit 8952573edd
4 changed files with 40 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
org.eclipse.tm.terminal-feature/feature.xml
View file

@ -1,8 +1,19 @@
<?xml version="1.0" encoding="UTF-8"?> <!-- Copyright (c) 2006, 2009 Wind River Systems, Inc. and others. All rights reserved. This program and the accompanying materials are made available under the terms of the Eclipse Public License v1.0 which accompanies this distribution, and is available at http://www.eclipse.org/legal/epl-v10.html Contributors: Wind River - initial API and implementation Uwe Stieber (Wind River) - [282996] [terminal][api] Add "hidden" attribute to terminal connector extension point -->
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copyright (c) 2006, 2009 Wind River Systems, Inc. and others.
All rights reserved. This program and the accompanying materials
are made available under the terms of the Eclipse Public License v1.0
which accompanies this distribution, and is available at
http://www.eclipse.org/legal/epl-v10.html
Contributors:
Wind River - initial API and implementation
Uwe Stieber (Wind River) - [282996] [terminal][api] Add "hidden" attribute to terminal connector extension point
-->
<feature
id="org.eclipse.tm.terminal"
label="%featureName"
version="3.0.1.qualifier"
version="3.0.100.qualifier"
provider-name="%providerName">
<description>

15
org.eclipse.tm.terminal.sdk-feature/feature.xml
View file

@ -1,8 +1,19 @@
<?xml version="1.0" encoding="UTF-8"?> <!-- Copyright (c) 2006, 2009 Wind River Systems, Inc. and others. All rights reserved. This program and the accompanying materials are made available under the terms of the Eclipse Public License v1.0 which accompanies this distribution, and is available at http://www.eclipse.org/legal/epl-v10.html Contributors: Wind River - initial API and implementation Uwe Stieber (Wind River) - [282996] [terminal][api] Add "hidden" attribute to terminal connector extension point -->
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copyright (c) 2006, 2009 Wind River Systems, Inc. and others.
All rights reserved. This program and the accompanying materials
are made available under the terms of the Eclipse Public License v1.0
which accompanies this distribution, and is available at
http://www.eclipse.org/legal/epl-v10.html
Contributors:
Wind River - initial API and implementation
Uwe Stieber (Wind River) - [282996] [terminal][api] Add "hidden" attribute to terminal connector extension point
-->
<feature
id="org.eclipse.tm.terminal.sdk"
label="%featureName"
version="3.0.1.qualifier"
version="3.0.100.qualifier"
provider-name="%providerName"
image="eclipse_update_120.jpg">

2
org.eclipse.tm.terminal/META-INF/MANIFEST.MF
View file

@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.tm.terminal; singleton:=true
Bundle-Version: 3.0.1.qualifier
Bundle-Version: 3.0.100.qualifier
Bundle-Activator: org.eclipse.tm.internal.terminal.control.impl.TerminalPlugin
Bundle-Vendor: %providerName
Bundle-Localization: plugin

17
org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/textcanvas/TextCanvas.java
View file

@ -8,7 +8,8 @@
* Contributors:
* Michael Scharf (Wind River) - initial API and implementation
* Michael Scharf (Wind River) - [240098] The cursor should not blink when the terminal is disconnected
* Uwe Stieber (Wind River) - [281238] The very first few characters might be missing in the terminal control if opened and connected programmatically
* Uwe Stieber (Wind River) - [281328] The very first few characters might be missing in the terminal control if opened and connected programmatically
* Martin Oberhuber (Wind River) - [294327] After logging in, the remote prompt is hidden
*******************************************************************************/
package org.eclipse.tm.internal.terminal.textcanvas;
@ -185,7 +186,7 @@ public class TextCanvas extends GridCanvas {
int columns=bonds.width/getCellWidth();
// when the view is minimised, its size is set to 0
// we don't sent this to the terminal!
if(lines>0 && columns>0 || init) {
if((lines>0 && columns>0) || init) {
if(columns<fMinColumns) {
if(!isHorizontalBarVisble()) {
setHorizontalBarVisible(true);
@ -300,12 +301,20 @@ public class TextCanvas extends GridCanvas {
throw new IllegalArgumentException("There can be at most one listener at the moment!"); //$NON-NLS-1$
fResizeListener=listener;
// Bug 281238: [terminal] The very first few characters might be missing in
// Bug 281328: [terminal] The very first few characters might be missing in
// the terminal control if opened and connected programmatically
//
// In case the terminal had not been visible yet or is to small (less than one
// line visible), the terminal should have a minimum size to avoid RuntimeExceptions.
setMinColumns(80); setMinLines(24);
//
// Bug 294327: Min lines 1 is sufficient to avoid the exception, and ensures
// that on a new connection, the initial prompt is visible.
// MinColumns was changed from 20 to 80 in TM 3.1.1 -- Having MinColumns 80
// ensures that dumb terminals render properly. On a narrow Terminal, users
// will not see everything, but since the backing store is 80 wide they can
// always resize the terminal to see all. A better solution than guessing the
// MinColumns here should be implemented with bug 196462 (optional fixed-width).
setMinColumns(80); setMinLines(1);
onResize(true);
}