mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

[246318] Added a comment referring to bug in platform.

Browse source
This commit is contained in:
Pawel Piech 2008-09-08 17:41:18 +00:00
parent 800d7229c9
commit 86adda189d
1 changed files with 95 additions and 108 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

203
plugins/org.eclipse.dd.dsf.debug.ui/src/org/eclipse/dd/dsf/debug/internal/provisional/ui/viewmodel/variable/VariableVMNode.java
View file

@ -186,123 +186,110 @@ public class VariableVMNode extends AbstractExpressionVMNode
final IExpressionDMContext dmc = findDmcInPath(update.getViewerInput(), update.getElementPath(), IExpressions.IExpressionDMContext.class); final IExpressionDMContext dmc = findDmcInPath(update.getViewerInput(), update.getElementPath(), IExpressions.IExpressionDMContext.class);
if ( dmc == null ) { if ( dmc == null ) {
/* // Workaround for a bug in platform, where the find operation may use wrong label provider.
* For whatever reason we could not find a match. There is one known case where this happens // See bug 246618.
* and that is when the Find function is trying construct a list of the items to be searched update.done();
* and it wants to get the value of the "Add new expression" entry which is a pseudo phantom continue;
* entry that is created by the ExpressionManagerVMNode for nice work flow display purposes.
* But it not real and has no corresponding DMC. In this case we will just make it blank and
* this will show OK for the most part. There are other error VMC's which do not have valid
* DMC's which can come from the ExpressionManagerVMNode. This will handle both cases.
*/
String[] localColumns = update.getColumnIds();
if (localColumns == null)
localColumns = new String[] { IDebugVMConstants.COLUMN_ID__NAME };
for (int idx = 0; idx < localColumns.length; idx++) {
update.setLabel("",idx);
}
update.done();
} }
else {
getDMVMProvider().getModelData(
this, update,
getServicesTracker().getService(IExpressions.class, null),
dmc,
new ViewerDataRequestMonitor<IExpressionDMData>(getSession().getExecutor(), update) {
@Override
protected void handleCompleted() {
// Check that the request was evaluated and data is still valid. The request could
// fail if the state of the service changed during the request, but the view model
// has not been updated yet.
if (!isSuccess()) {
assert getStatus().isOK() ||
getStatus().getCode() != IDsfStatusConstants.INTERNAL_ERROR ||
getStatus().getCode() != IDsfStatusConstants.NOT_SUPPORTED;
/*
* Instead of just failing this outright we are going to attempt to do more here.
* Failing it outright causes the view to display ... for all columns in the line
* and this is uninformative about what is happening. It will be very common that
* one or more variables at that given instance in time are not evaluatable. They
* may be out of scope and will come back into scope later.
*/
String[] localColumns = update.getColumnIds();
if (localColumns == null)
localColumns = new String[] { IDebugVMConstants.COLUMN_ID__NAME };
for (int idx = 0; idx < localColumns.length; idx++) { getDMVMProvider().getModelData(
if (IDebugVMConstants.COLUMN_ID__NAME.equals(localColumns[idx])) { this, update,
update.setLabel(dmc.getExpression(), idx); getServicesTracker().getService(IExpressions.class, null),
} else if (IDebugVMConstants.COLUMN_ID__TYPE.equals(localColumns[idx])) { dmc,
update.setLabel("", idx); new ViewerDataRequestMonitor<IExpressionDMData>(getSession().getExecutor(), update) {
} else if (IDebugVMConstants.COLUMN_ID__VALUE.equals(localColumns[idx])) { @Override
update.setLabel("Error : " + getStatus().getMessage(), idx); protected void handleCompleted() {
} else if (IDebugVMConstants.COLUMN_ID__DESCRIPTION.equals(localColumns[idx])) { // Check that the request was evaluated and data is still valid. The request could
update.setLabel("", idx); // fail if the state of the service changed during the request, but the view model
} else if (IDebugVMConstants.COLUMN_ID__EXPRESSION.equals(localColumns[idx])) { // has not been updated yet.
update.setLabel(dmc.getExpression(), idx); if (!isSuccess()) {
} assert getStatus().isOK() ||
update.setFontData(JFaceResources.getFontDescriptor(IInternalDebugUIConstants.VARIABLE_TEXT_FONT).getFontData()[0], idx); getStatus().getCode() != IDsfStatusConstants.INTERNAL_ERROR ||
} getStatus().getCode() != IDsfStatusConstants.NOT_SUPPORTED;
/*
* Instead of just failing this outright we are going to attempt to do more here.
* Failing it outright causes the view to display ... for all columns in the line
* and this is uninformative about what is happening. It will be very common that
* one or more variables at that given instance in time are not evaluatable. They
* may be out of scope and will come back into scope later.
*/
String[] localColumns = update.getColumnIds();
if (localColumns == null)
localColumns = new String[] { IDebugVMConstants.COLUMN_ID__NAME };
for (int idx = 0; idx < localColumns.length; idx++) {
if (IDebugVMConstants.COLUMN_ID__NAME.equals(localColumns[idx])) {
update.setLabel(dmc.getExpression(), idx);
} else if (IDebugVMConstants.COLUMN_ID__TYPE.equals(localColumns[idx])) {
update.setLabel("", idx);
} else if (IDebugVMConstants.COLUMN_ID__VALUE.equals(localColumns[idx])) {
update.setLabel("Error : " + getStatus().getMessage(), idx);
} else if (IDebugVMConstants.COLUMN_ID__DESCRIPTION.equals(localColumns[idx])) {
update.setLabel("", idx);
} else if (IDebugVMConstants.COLUMN_ID__EXPRESSION.equals(localColumns[idx])) {
update.setLabel(dmc.getExpression(), idx);
}
update.setFontData(JFaceResources.getFontDescriptor(IInternalDebugUIConstants.VARIABLE_TEXT_FONT).getFontData()[0], idx);
}
update.done(); update.done();
return; return;
} }
// If columns are configured, extract the selected values for each understood column. // If columns are configured, extract the selected values for each understood column.
// First, we fill all of those columns which can be filled without extra data mining. // First, we fill all of those columns which can be filled without extra data mining.
// We also note if we do have to do extra data mining. Any columns need to set the // We also note if we do have to do extra data mining. Any columns need to set the
// processing flag so we know we have further work to do. If there are more columns // processing flag so we know we have further work to do. If there are more columns
// which need data extraction they need to be added in both "for" loops. // which need data extraction they need to be added in both "for" loops.
String[] localColumns = update.getColumnIds(); String[] localColumns = update.getColumnIds();
if (localColumns == null) if (localColumns == null)
localColumns = new String[] { IDebugVMConstants.COLUMN_ID__NAME }; localColumns = new String[] { IDebugVMConstants.COLUMN_ID__NAME };
boolean weAreExtractingFormattedData = false; boolean weAreExtractingFormattedData = false;
for (int idx = 0; idx < localColumns.length; idx++) { for (int idx = 0; idx < localColumns.length; idx++) {
if (IDebugVMConstants.COLUMN_ID__NAME.equals(localColumns[idx])) { if (IDebugVMConstants.COLUMN_ID__NAME.equals(localColumns[idx])) {
update.setLabel(getData().getName(), idx); update.setLabel(getData().getName(), idx);
} else if (IDebugVMConstants.COLUMN_ID__TYPE.equals(localColumns[idx])) { } else if (IDebugVMConstants.COLUMN_ID__TYPE.equals(localColumns[idx])) {
update.setLabel(getData().getTypeName(), idx); update.setLabel(getData().getTypeName(), idx);
} else if (IDebugVMConstants.COLUMN_ID__VALUE.equals(localColumns[idx])) { } else if (IDebugVMConstants.COLUMN_ID__VALUE.equals(localColumns[idx])) {
weAreExtractingFormattedData = true; weAreExtractingFormattedData = true;
} else if (IDebugVMConstants.COLUMN_ID__DESCRIPTION.equals(localColumns[idx])) { } else if (IDebugVMConstants.COLUMN_ID__DESCRIPTION.equals(localColumns[idx])) {
update.setLabel("", idx); update.setLabel("", idx);
} else if (IDebugVMConstants.COLUMN_ID__EXPRESSION.equals(localColumns[idx])) { } else if (IDebugVMConstants.COLUMN_ID__EXPRESSION.equals(localColumns[idx])) {
IVMContext vmc = (IVMContext)update.getElement(); IVMContext vmc = (IVMContext)update.getElement();
IExpression expression = (IExpression)vmc.getAdapter(IExpression.class); IExpression expression = (IExpression)vmc.getAdapter(IExpression.class);
if (expression != null) { if (expression != null) {
update.setLabel(expression.getExpressionText(), idx); update.setLabel(expression.getExpressionText(), idx);
} else { } else {
update.setLabel(getData().getName(), idx); update.setLabel(getData().getName(), idx);
} }
} }
update.setFontData(JFaceResources.getFontDescriptor(IInternalDebugUIConstants.VARIABLE_TEXT_FONT).getFontData()[0], idx); update.setFontData(JFaceResources.getFontDescriptor(IInternalDebugUIConstants.VARIABLE_TEXT_FONT).getFontData()[0], idx);
} }
if ( ! weAreExtractingFormattedData ) { if ( ! weAreExtractingFormattedData ) {
update.done(); update.done();
} else { } else {
boolean found = false; boolean found = false;
for (int idx = 0; idx < localColumns.length; idx++) { for (int idx = 0; idx < localColumns.length; idx++) {
if (IDebugVMConstants.COLUMN_ID__VALUE.equals(localColumns[idx])) { if (IDebugVMConstants.COLUMN_ID__VALUE.equals(localColumns[idx])) {
found = true; found = true;
updateFormattedExpressionValue(update, idx, dmc, getData()); updateFormattedExpressionValue(update, idx, dmc, getData());
break; break;
} }
} }
if (!found) { if (!found) {
update.done(); update.done();
} }
} }
} }
}, },
getExecutor() getExecutor()
); );
}
} }
} }