From 86490a11d76518e2dd995e146038b114da16d03b Mon Sep 17 00:00:00 2001
From: Andrew Gvozdev <angvoz.dev@gmail.com>
Date: Thu, 22 Apr 2010 18:12:26 +0000
Subject: [PATCH] bug 309690: Error catching for CProjectHelper in
 cdt.core.tests

---
 .../cdt/core/testplugin/CProjectHelper.java   | 23 +++++++++----------
 .../core/testplugin/util/BaseTestCase.java    |  2 ++
 2 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/core/org.eclipse.cdt.core.tests/suite/org/eclipse/cdt/core/testplugin/CProjectHelper.java b/core/org.eclipse.cdt.core.tests/suite/org/eclipse/cdt/core/testplugin/CProjectHelper.java
index 080595c0044..b1f087b304d 100644
--- a/core/org.eclipse.cdt.core.tests/suite/org/eclipse/cdt/core/testplugin/CProjectHelper.java
+++ b/core/org.eclipse.cdt.core.tests/suite/org/eclipse/cdt/core/testplugin/CProjectHelper.java
@@ -427,19 +427,18 @@ public class CProjectHelper {
 	}
 
 	/**
-	 * Returns the location of a newly created directory in the systems temp. area.
-	 * @return the location of a newly created directory in the systems temp. area
+	 * @return the location of a newly created directory in temporary area.
+	 *    Note that cleanup should be done with {@link ResourceHelper#cleanUp()}.
 	 * @throws IOException
+	 * @throws CoreException 
 	 */
-	public static File freshDir() throws IOException {
-		File tempDir = new File(System.getProperty("java.io.tmpdir")).getCanonicalFile();		
-		for(int i=0; i<Integer.MAX_VALUE; i++) {
-			File candidate = new File(tempDir, "__testData/"+i);
-			if(!candidate.exists()) {
-				candidate.mkdirs();
-				return candidate;
-			}
-		}
-		return null;
+	public static File freshDir() throws IOException, CoreException {
+		IPath folderPath = ResourceHelper.createTemporaryFolder();
+		File folder = new File(folderPath.toOSString());
+		Assert.assertTrue(folder.exists());
+		Assert.assertTrue(folder.isDirectory());
+		Assert.assertTrue(folder.canWrite());
+		
+		return folder;
 	}
 }
\ No newline at end of file
diff --git a/core/org.eclipse.cdt.core.tests/suite/org/eclipse/cdt/core/testplugin/util/BaseTestCase.java b/core/org.eclipse.cdt.core.tests/suite/org/eclipse/cdt/core/testplugin/util/BaseTestCase.java
index 938a0d5706b..4c71690e005 100644
--- a/core/org.eclipse.cdt.core.tests/suite/org/eclipse/cdt/core/testplugin/util/BaseTestCase.java
+++ b/core/org.eclipse.cdt.core.tests/suite/org/eclipse/cdt/core/testplugin/util/BaseTestCase.java
@@ -31,6 +31,7 @@ import org.eclipse.cdt.core.model.CoreModel;
 import org.eclipse.cdt.core.model.ElementChangedEvent;
 import org.eclipse.cdt.core.model.ICProject;
 import org.eclipse.cdt.core.model.IElementChangedListener;
+import org.eclipse.cdt.core.testplugin.ResourceHelper;
 import org.eclipse.cdt.core.testplugin.TestScannerProvider;
 import org.eclipse.cdt.internal.core.CCoreInternals;
 import org.eclipse.cdt.internal.core.dom.parser.cpp.CPPASTNameBase;
@@ -66,6 +67,7 @@ public class BaseTestCase extends TestCase {
 	
 	@Override
 	protected void tearDown() throws Exception {
+		ResourceHelper.cleanUp();
 		TestScannerProvider.clear();
 	}