From 82e545c9686b6eebdf338e16bb72f179f172d21c Mon Sep 17 00:00:00 2001 From: James Blackburn Date: Thu, 26 Nov 2009 11:01:36 +0000 Subject: [PATCH] Bug 296115 CConfigBasedDescManager & CPrjDescManager singleton refs should be volatile --- .../core/settings/model/CProjectDescriptionManager.java | 2 +- .../src/org/eclipse/cdt/core/CCorePlugin.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/CProjectDescriptionManager.java b/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/CProjectDescriptionManager.java index 7ac436fb38f..527ff7e819e 100644 --- a/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/CProjectDescriptionManager.java +++ b/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/CProjectDescriptionManager.java @@ -246,7 +246,7 @@ public class CProjectDescriptionManager implements ICProjectDescriptionManager { /** Set of Listeners listening for Project Description Deltas */ private Set fListeners = new CopyOnWriteArraySet(); private Map fPreferenceMap = new HashMap(); - private CConfigBasedDescriptorManager fDescriptorManager; + private volatile CConfigBasedDescriptorManager fDescriptorManager; private ResourceChangeHandler fRcChangeHandler; private CProjectDescriptionWorkspacePreferences fPreferences; private boolean fAllowEmptyCreatingDescription = true; // allowed by default diff --git a/core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/CCorePlugin.java b/core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/CCorePlugin.java index 64158d729e3..01aaa032987 100644 --- a/core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/CCorePlugin.java +++ b/core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/CCorePlugin.java @@ -197,7 +197,7 @@ public class CCorePlugin extends Plugin { */ public CDTLogWriter cdtLog = null; - private CProjectDescriptionManager fNewCProjectDescriptionManager; + private volatile CProjectDescriptionManager fNewCProjectDescriptionManager; private CoreModel fCoreModel;