mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-03 07:05:24 +02:00
Code Issues Wiki Activity

launchbar: when there is no descriptors show all connections

Browse source 
- when you bring IDE in new workspace all drops downs are empty,
so you create new connection from target drop down, but its still
remain empty after connection is created which is quite confusing. 
So its better to show
all connection when descriptor is null (i.e. no descriptor at all)

Change-Id: Idef1b676baef4978f8327135691e485ca287d7fe
This commit is contained in:
Alena Laskavaia 2015-09-08 10:48:31 -04:00
parent 4b6a04fac1
commit 806ae521c6
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
bundles/org.eclipse.launchbar.core/src/org/eclipse/launchbar/core/internal/LaunchBarManager.java
View file

@ -598,7 +598,7 @@ public class LaunchBarManager implements ILaunchBarManager, IRemoteConnectionCha
/**
* Sets the preferred mode for the given descriptor
*
*
* @param desc
* @param mode
* @throws CoreException
@ -643,7 +643,7 @@ public class LaunchBarManager implements ILaunchBarManager, IRemoteConnectionCha
public List<IRemoteConnection> getLaunchTargets(ILaunchDescriptor descriptor) throws CoreException {
if (descriptor == null)
return Collections.emptyList();
return remoteServicesManager.getAllRemoteConnections();
List<IRemoteConnection> targets = new ArrayList<>();
for (IRemoteConnection target : remoteServicesManager.getAllRemoteConnections()) {
@ -677,7 +677,7 @@ public class LaunchBarManager implements ILaunchBarManager, IRemoteConnectionCha
/**
* Sets preferred target for launch descriptor
*
*
* @param desc
* @param target
* @throws CoreException
@ -816,7 +816,7 @@ public class LaunchBarManager implements ILaunchBarManager, IRemoteConnectionCha
@Override
public void launchConfigurationChanged(ILaunchConfiguration configuration) {
// we have to ignore notifications from working copies, otherwise
// we will get thousand of events and we don't track working copies
// we will get thousand of events and we don't track working copies
// (add/remove events are not sent for WCs)
if (configuration.isWorkingCopy())
return;
@ -889,7 +889,7 @@ public class LaunchBarManager implements ILaunchBarManager, IRemoteConnectionCha
return;
fireLaunchTargetsChanged();
// if we added new target we probably want to use it
if (activeLaunchDesc != null && supportsTarget(activeLaunchDesc, target)) {
if (activeLaunchDesc == null || supportsTarget(activeLaunchDesc, target)) {
setActiveLaunchTarget(target);
}
}