mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-09-10 12:03:16 +02:00
Code Issues Wiki Activity

Bug 553141 - Fix logic error in TypeInstantiationRequest.equals()

Browse source 
Change-Id: Ie458f44a4384233ef96ed18e46f38fde309c7399
This commit is contained in:
Nathan Ridge 2019-11-19 21:28:15 -05:00
parent ac7d473351
commit 7e267a4791
2 changed files with 34 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/cxx17/TemplateAutoTests.java
View file

@ -75,4 +75,37 @@ public class TemplateAutoTests extends AST2CPPTestBase {
public void testTemplateNontypeParameterTypeDeductionParsing_519361_3() throws Exception { public void testTemplateNontypeParameterTypeDeductionParsing_519361_3() throws Exception {
parseAndCheckBindings(); parseAndCheckBindings();
} }
// template <typename T, T>
// struct meta { using type = int; };
//
// template <typename T>
// struct remove_noexcept { using type = T; };
//
// template <typename T>
// using remove_noexcept_t = typename remove_noexcept<T>::type;
//
// template <auto Key>
// struct K : meta<remove_noexcept_t<decltype(Key)>,Key>{};
//
// template <auto Key>
// struct W {
// using type = typename K<Key>::type;
// };
//
// template <typename T>
// struct M {};
//
// struct A {
// int foo;
// };
// typedef M<W<&A::foo>::type> M1; // typedef #1
//
// struct B {
// int foo;
// };
// typedef M<W<&B::foo>::type> M2; // typedef #2
public void testInstantiationCacheConflict_553141() throws Exception {
parseAndCheckBindings();
}
} }

2
core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/TypeInstantiationRequest.java
View file

@ -80,7 +80,7 @@ public class TypeInstantiationRequest {
return true; return true;
if (type1 == null || type2 == null) if (type1 == null || type2 == null)
return false; return false;
return type1.isSameType(type1); return type1.isSameType(type2);
} }
private boolean equals(ICPPTemplateParameterMap map1, ICPPTemplateParameterMap map2) { private boolean equals(ICPPTemplateParameterMap map1, ICPPTemplateParameterMap map2) {