From 7b4385aadbe84a9bbb37e1d034f61f15fd97cbad Mon Sep 17 00:00:00 2001 From: Kushal Munir < kmunir@ca.ibm.com> Date: Tue, 5 Dec 2006 15:45:09 +0000 Subject: [PATCH] [cleanup] fix compiler warnings --- .../rse/ui/actions/SystemBaseDialogAction.java | 2 +- .../rse/ui/actions/SystemCopyConnectionAction.java | 3 +-- .../ui/actions/SystemPasteFromClipboardAction.java | 1 - .../rse/ui/dialogs/SystemCopyProfileDialog.java | 2 +- .../rse/ui/dialogs/SystemFilterTableDialog.java | 7 +++---- .../ui/dialogs/SystemTestFilterStringDialog.java | 2 +- .../actions/SystemFilterMoveUpFilterAction.java | 1 - ...SystemFilterRemoveFilterPoolReferenceAction.java | 1 - .../rse/ui/messages/SystemMessageDialog.java | 13 +++---------- .../SystemChangeFilterPropertyPage.java | 1 - .../propertypages/SystemConnectionPropertyPage.java | 2 -- .../propertypages/SystemFilterPoolPropertyPage.java | 1 - .../SystemFilterPoolReferencePropertyPage.java | 4 +--- .../ui/propertypages/SystemFilterPropertyPage.java | 1 - .../SystemFilterStringPropertyPage.java | 1 - .../rse/ui/view/SystemDropActionDelegate.java | 3 +-- .../rse/ui/view/SystemPropertySheetForm.java | 9 ++++----- .../UI/org/eclipse/rse/ui/view/SystemTableView.java | 3 --- .../rse/ui/view/SystemViewDataDragAdapter.java | 10 ++++------ .../rse/ui/view/monitor/SystemMonitorViewPart.java | 7 +++---- .../view/scratchpad/SystemScratchpadViewPart.java | 5 +---- .../eclipse/rse/ui/view/team/SystemTeamView.java | 4 +--- .../ui/view/team/SystemTeamViewProfileAdapter.java | 1 - .../rse/ui/wizards/SystemNewConnectionWizard.java | 2 +- .../subsystems/SubSystemConfigurationProxy.java | 1 - .../org/eclipse/rse/core/SystemResourceHelpers.java | 6 ++---- .../rse/core/comm/SystemCommunicationsDaemon.java | 2 +- 27 files changed, 29 insertions(+), 66 deletions(-) diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemBaseDialogAction.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemBaseDialogAction.java index 6a85fecf967..ffa61bcb7d7 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemBaseDialogAction.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemBaseDialogAction.java @@ -298,7 +298,7 @@ public abstract class SystemBaseDialogAction extends SystemBaseAction ((SystemPromptDialog)dlg).setNeedsProgressMonitor(needsProgressMonitor); } - int rc = dlg.open(); + dlg.open(); // if (rc != 0) NOT RELIABLE! if (dlg instanceof SystemWizardDialog) diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemCopyConnectionAction.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemCopyConnectionAction.java index 911de7337a1..f7dd38bc970 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemCopyConnectionAction.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemCopyConnectionAction.java @@ -61,8 +61,7 @@ public class SystemCopyConnectionAction extends SystemBaseCopyAction */ public boolean updateSelection(IStructuredSelection selection) { - boolean enable = true; - ISystemRegistry sr = RSEUIPlugin.getDefault().getSystemRegistry(); + boolean enable = true; ISystemProfile prevProfile = null; Iterator e= selection.iterator(); while (enable && e.hasNext()) diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemPasteFromClipboardAction.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemPasteFromClipboardAction.java index b2230f0272a..a651b5e2c42 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemPasteFromClipboardAction.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemPasteFromClipboardAction.java @@ -97,7 +97,6 @@ public class SystemPasteFromClipboardAction extends SystemBaseAction implements if (targetAdapter != null) { - ISubSystem targetSubSystem = targetAdapter.getSubSystem(target); List rulesList = new ArrayList(); int j = 0; for (int i = 0; i < srcObjects.size(); i++) diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemCopyProfileDialog.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemCopyProfileDialog.java index 84caddb01dc..e5c84cd978b 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemCopyProfileDialog.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemCopyProfileDialog.java @@ -83,7 +83,7 @@ public class SystemCopyProfileDialog extends SystemPromptDialog */ protected ISystemMessageLine createMessageLine(Composite c) { - ISystemMessageLine msgLine = super.createMessageLine(c); + super.createMessageLine(c); //form.setMessageLine(msgLine); return fMessageLine; } diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemFilterTableDialog.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemFilterTableDialog.java index f667de3a5d9..4a7c4bdf099 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemFilterTableDialog.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemFilterTableDialog.java @@ -146,7 +146,7 @@ public class SystemFilterTableDialog extends SystemPromptDialog implements KeyLi inputC.setLayoutData(igd); // input - Label objFilterLabel= SystemWidgetHelpers.createLabel(inputC, "Input"); //$NON-NLS-1$ + SystemWidgetHelpers.createLabel(inputC, "Input"); //$NON-NLS-1$ _inputText = new Combo(inputC, SWT.DROP_DOWN | SWT.READ_ONLY); _inputText.addListener(SWT.Selection, this); @@ -175,7 +175,7 @@ public class SystemFilterTableDialog extends SystemPromptDialog implements KeyLi filterC.setLayoutData(fgd); // type filter strings - Label typeFilterLabel= SystemWidgetHelpers.createLabel(filterC, SystemPropertyResources.RESID_PROPERTY_TYPE_LABEL); + SystemWidgetHelpers.createLabel(filterC, SystemPropertyResources.RESID_PROPERTY_TYPE_LABEL); _typeCombo = new Combo(filterC, SWT.DROP_DOWN | SWT.READ_ONLY); for (int i = 0; i < _typeFilterStrings.length; i++) { @@ -189,7 +189,7 @@ public class SystemFilterTableDialog extends SystemPromptDialog implements KeyLi _typeCombo.addListener(SWT.Selection, this); // view filter strings - Label viewFilterLabel= SystemWidgetHelpers.createLabel(filterC, SystemResources.RESID_FILTERSTRING_STRING_LABEL); + SystemWidgetHelpers.createLabel(filterC, SystemResources.RESID_FILTERSTRING_STRING_LABEL); _filterCombo = SystemWidgetHelpers.createCombo(filterC, this); _filterCombo.setText(_viewFilterStrings[0]); for (int i = 0; i < _viewFilterStrings.length; i++) @@ -350,7 +350,6 @@ public class SystemFilterTableDialog extends SystemPromptDialog implements KeyLi if (input != _currentInput) { _currentInput = input; - ISystemViewElementAdapter adapter = getAdatperFor(_currentInput); _inputText.setText(inputStr); applyViewFilter(false); _viewer.setInput(_currentInput); diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemTestFilterStringDialog.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemTestFilterStringDialog.java index c36185a9d2e..3babc51fc47 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemTestFilterStringDialog.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemTestFilterStringDialog.java @@ -191,7 +191,7 @@ public class SystemTestFilterStringDialog } public void widgetSelected(SelectionEvent event) { - Object src = event.getSource(); + //if (src == connectionCombo.getCombo()) { //System.out.println("connection changed"); diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/filters/actions/SystemFilterMoveUpFilterAction.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/filters/actions/SystemFilterMoveUpFilterAction.java index 4bed51fea9a..c261ff9beb5 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/filters/actions/SystemFilterMoveUpFilterAction.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/filters/actions/SystemFilterMoveUpFilterAction.java @@ -100,7 +100,6 @@ public class SystemFilterMoveUpFilterAction extends SystemBaseAction (selectedObject instanceof ISystemFilterReference))) return false; ISystemFilter filter = getSystemFilter(selectedObject); - ISystemFilterPoolManager fpMgr = filter.getSystemFilterPoolManager(); ISystemFilterContainer fpContainer = filter.getParentFilterContainer(); int pos = fpContainer.getSystemFilterPosition(filter); return (pos>0); diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/filters/actions/SystemFilterRemoveFilterPoolReferenceAction.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/filters/actions/SystemFilterRemoveFilterPoolReferenceAction.java index 3079dc50cfd..59256745e7c 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/filters/actions/SystemFilterRemoveFilterPoolReferenceAction.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/filters/actions/SystemFilterRemoveFilterPoolReferenceAction.java @@ -81,7 +81,6 @@ public class SystemFilterRemoveFilterPoolReferenceAction public void run() { IStructuredSelection selections = getSelection(); - ISystemFilterPoolReference poolReferences[] = new ISystemFilterPoolReference[selections.size()]; Iterator i = selections.iterator(); ISystemFilterPoolReferenceManager fprMgr = null; while (i.hasNext()) diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/messages/SystemMessageDialog.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/messages/SystemMessageDialog.java index eb0a81c40c9..e093f63fc26 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/messages/SystemMessageDialog.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/messages/SystemMessageDialog.java @@ -25,7 +25,6 @@ import org.eclipse.core.runtime.Status; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.preference.IPreferenceStore; -import org.eclipse.jface.resource.JFaceResources; import org.eclipse.rse.core.SystemBasePlugin; import org.eclipse.rse.services.clientserver.messages.IndicatorException; import org.eclipse.rse.services.clientserver.messages.SystemMessage; @@ -63,10 +62,6 @@ public class SystemMessageDialog extends ErrorDialog implements Listener { * The Details button. */ private Button detailsButton=null; - /** - * The title of the dialog. - */ - private String title; /** * The message to display. @@ -183,8 +178,6 @@ public class SystemMessageDialog extends ErrorDialog implements Listener { IStatus status, int displayMask) { super(parentShell, dialogTitle, message, status, displayMask); - this.title = (dialogTitle == null) ? JFaceResources.getString("Problem_Occurred"): //$NON-NLS-1$ - dialogTitle; this.status = status; statusList = Arrays.asList(status.getChildren()); this.displayMask = displayMask; @@ -547,7 +540,7 @@ public class SystemMessageDialog extends ErrorDialog implements Listener { private void toggleDetailsArea() { Point windowSize = getShell().getSize(); - Point oldSize = getContents().computeSize(SWT.DEFAULT, SWT.DEFAULT); + getContents().computeSize(SWT.DEFAULT, SWT.DEFAULT); if (listCreated) { @@ -575,11 +568,11 @@ public class SystemMessageDialog extends ErrorDialog implements Listener { private void toggleDetailsArea2(Composite composite) { Point windowSize = getShell().computeSize(SWT.DEFAULT, SWT.DEFAULT); - Point oldSize = getDialogArea().computeSize(SWT.DEFAULT, SWT.DEFAULT); + getDialogArea().computeSize(SWT.DEFAULT, SWT.DEFAULT); list = createDropDownList2(composite.getParent()); detailsButton.setText(IDialogConstants.HIDE_DETAILS_LABEL); Point newSize = composite.getParent().computeSize(SWT.DEFAULT, SWT.DEFAULT); - Point buttonSize=composite.computeSize(SWT.DEFAULT, SWT.DEFAULT); + composite.computeSize(SWT.DEFAULT, SWT.DEFAULT); // yantzi:5.1.2 this leaves a gap at the bottom of the dialog when opened with details, // why not just set it to the newSize.y? diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemChangeFilterPropertyPage.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemChangeFilterPropertyPage.java index ef4f113652a..d058524d6c3 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemChangeFilterPropertyPage.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemChangeFilterPropertyPage.java @@ -61,7 +61,6 @@ public class SystemChangeFilterPropertyPage extends SystemBasePropertyPage public SystemChangeFilterPropertyPage() { super(); - RSEUIPlugin sp = RSEUIPlugin.getDefault(); changeFilterPane = new SystemChangeFilterPane(null, this, this); changeFilterPane.addPageCompleteListener(this); setHelp(RSEUIPlugin.HELPPREFIX+"dufr0000"); //$NON-NLS-1$ diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemConnectionPropertyPage.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemConnectionPropertyPage.java index 349f73784a2..a98eecaaf08 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemConnectionPropertyPage.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemConnectionPropertyPage.java @@ -47,8 +47,6 @@ public class SystemConnectionPropertyPage extends SystemBasePropertyPage public SystemConnectionPropertyPage() { super(); - RSEUIPlugin sp = RSEUIPlugin.getDefault(); - parentHelpId = RSEUIPlugin.HELPPREFIX + "pcon0000"; //$NON-NLS-1$ form = new SystemConnectionForm(this, this); } diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterPoolPropertyPage.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterPoolPropertyPage.java index a7d5fda7188..e2c9aa6908e 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterPoolPropertyPage.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterPoolPropertyPage.java @@ -45,7 +45,6 @@ public class SystemFilterPoolPropertyPage extends SystemBasePropertyPage public SystemFilterPoolPropertyPage() { super(); - RSEUIPlugin sp = RSEUIPlugin.getDefault(); } /** * Create the page's GUI contents. diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterPoolReferencePropertyPage.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterPoolReferencePropertyPage.java index 6254991dcad..494e19215fc 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterPoolReferencePropertyPage.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterPoolReferencePropertyPage.java @@ -45,7 +45,6 @@ public class SystemFilterPoolReferencePropertyPage extends SystemBasePropertyPag public SystemFilterPoolReferencePropertyPage() { super(); - RSEUIPlugin sp = RSEUIPlugin.getDefault(); } /** * Create the page's GUI contents. @@ -101,8 +100,7 @@ public class SystemFilterPoolReferencePropertyPage extends SystemBasePropertyPag initDone = true; ISystemFilterPoolReference poolRef = getFilterPoolReference(); ISystemFilterPool pool = poolRef.getReferencedFilterPool(); - ISubSystem ss = (ISubSystem)poolRef.getProvider(); - ISubSystemConfiguration ssFactory = ss.getSubSystemConfiguration(); + ISubSystem ss = (ISubSystem)poolRef.getProvider(); // name labelName.setText(pool.getName()); diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterPropertyPage.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterPropertyPage.java index 35f0d8511f3..19b9ebe9965 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterPropertyPage.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterPropertyPage.java @@ -45,7 +45,6 @@ public class SystemFilterPropertyPage extends SystemBasePropertyPage public SystemFilterPropertyPage() { super(); - RSEUIPlugin sp = RSEUIPlugin.getDefault(); } /** * Create the page's GUI contents. diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterStringPropertyPage.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterStringPropertyPage.java index e217f9e7b85..f3a4dc054ab 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterStringPropertyPage.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/SystemFilterStringPropertyPage.java @@ -71,7 +71,6 @@ public class SystemFilterStringPropertyPage extends SystemBasePropertyPage imple public SystemFilterStringPropertyPage() { super(); - RSEUIPlugin sp = RSEUIPlugin.getDefault(); } // configuration methods, called by customizeFilterStringPropertyPage in SubSystemConfigurationImpl... diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/SystemDropActionDelegate.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/SystemDropActionDelegate.java index d16aacd9eeb..4593f38711a 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/SystemDropActionDelegate.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/SystemDropActionDelegate.java @@ -87,8 +87,7 @@ public class SystemDropActionDelegate implements IDropActionDelegate //StringTokenizer tokenizer = new StringTokenizer(new String(result), SystemViewDataDropAdapter.RESOURCE_SEPARATOR); String[] tokens = (new String(result)).split("\\"+SystemViewDataDropAdapter.RESOURCE_SEPARATOR); //$NON-NLS-1$ ArrayList srcObjects = new ArrayList(); - ArrayList rulesList = new ArrayList(); - int j = 0; + //while (tokenizer.hasMoreTokens()) for (int i = 0; i 0) { event.data = fileNames; diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/monitor/SystemMonitorViewPart.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/monitor/SystemMonitorViewPart.java index 54eabf4e99d..86da05c922d 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/monitor/SystemMonitorViewPart.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/monitor/SystemMonitorViewPart.java @@ -492,7 +492,7 @@ class SubSetAction extends BrowseAction { Composite main = SystemWidgetHelpers.createComposite(parent, 1); - Label label = SystemWidgetHelpers.createLabel(main, SystemResources.RESID_TABLE_SELECT_COLUMNS_DESCRIPTION_LABEL); + SystemWidgetHelpers.createLabel(main, SystemResources.RESID_TABLE_SELECT_COLUMNS_DESCRIPTION_LABEL); Composite c = SystemWidgetHelpers.createComposite(main, 4); c.setLayoutData(new GridData(GridData.FILL_BOTH)); @@ -845,7 +845,6 @@ class SubSetAction extends BrowseAction public void systemRemoteResourceChanged(ISystemRemoteChangeEvent event) { int eventType = event.getEventType(); - Object remoteResourceParent = event.getResourceParent(); Object remoteResource = event.getResource(); Vector remoteResourceNames = null; @@ -884,12 +883,12 @@ class SubSetAction extends BrowseAction { if (child instanceof Vector) { - Vector vec = (Vector)child; + /*Vector vec = (Vector)child; for (int v = 0; v < vec.size(); v++) { Object c = vec.get(v); - } + }*/ } else { diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/scratchpad/SystemScratchpadViewPart.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/scratchpad/SystemScratchpadViewPart.java index ba5a18dbb9b..9b3863d8bf4 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/scratchpad/SystemScratchpadViewPart.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/scratchpad/SystemScratchpadViewPart.java @@ -177,7 +177,6 @@ public class SystemScratchpadViewPart extends ViewPart implements ISelectionList return; ISystemViewElementAdapter adapter = (ISystemViewElementAdapter) ((IAdaptable) element).getAdapter(ISystemViewElementAdapter.class); - boolean alreadyHandled = false; if (adapter != null) { @@ -187,7 +186,7 @@ public class SystemScratchpadViewPart extends ViewPart implements ISelectionList } else { - alreadyHandled = adapter.handleDoubleClick(element); + adapter.handleDoubleClick(element); } } } @@ -276,9 +275,7 @@ public class SystemScratchpadViewPart extends ViewPart implements ISelectionList */ public void systemResourceChanged(ISystemResourceChangeEvent event) { - Object child = event.getSource(); Object parent = event.getParent(); - Object input = _viewer.getInput(); if (event.getType() == ISystemResourceChangeEvents.EVENT_RENAME) { diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamView.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamView.java index a1953c47c9f..75b87b0b3cd 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamView.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamView.java @@ -168,9 +168,7 @@ public class SystemTeamView extends TreeViewer implements ISystemSelectAllTarget */ public void systemResourceChanged(ISystemResourceChangeEvent event) { - int type = event.getType(); - Object src = event.getSource(); - Object parent = event.getParent(); + int type = event.getType(); switch(type) { case ISystemResourceChangeEvents.EVENT_COLLAPSE_ALL: diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamViewProfileAdapter.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamViewProfileAdapter.java index 82b4b10890e..17314185e80 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamViewProfileAdapter.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamViewProfileAdapter.java @@ -291,7 +291,6 @@ public class SystemTeamViewProfileAdapter if (propertyDescriptorArray == null) { propertyDescriptorArray = new PropertyDescriptor[1]; - RSEUIPlugin plugin = RSEUIPlugin.getDefault(); int idx = 0; // status propertyDescriptorArray[idx++] = createSimplePropertyDescriptor(ISystemPropertyConstants.P_IS_ACTIVE,SystemViewResources.RESID_PROPERTY_PROFILESTATUS_LABEL, SystemViewResources.RESID_PROPERTY_PROFILESTATUS_TOOLTIP); diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/SystemNewConnectionWizard.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/SystemNewConnectionWizard.java index 193b7f538a6..c2afc2b983c 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/SystemNewConnectionWizard.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/SystemNewConnectionWizard.java @@ -127,7 +127,7 @@ public class SystemNewConnectionWizard if (restrictSystemTypesTo != null) mainPage.restrictSystemTypes(restrictSystemTypesTo); - ISystemProfile defaultProfile = SystemStartHere.getSystemProfileManager().getDefaultPrivateSystemProfile(); + SystemStartHere.getSystemProfileManager().getDefaultPrivateSystemProfile(); showProfilePageInitially = RSEUIPlugin.getDefault().getShowProfilePageInitially(); /* DKM - I don't think we should force profiles into the faces of users diff --git a/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/internal/subsystems/SubSystemConfigurationProxy.java b/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/internal/subsystems/SubSystemConfigurationProxy.java index 70e3a57fdf5..e9b74c2a477 100644 --- a/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/internal/subsystems/SubSystemConfigurationProxy.java +++ b/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/internal/subsystems/SubSystemConfigurationProxy.java @@ -82,7 +82,6 @@ public class SubSystemConfigurationProxy implements ISubSystemConfigurationProxy SystemBasePlugin.logError("Exception reading priority for subsystem configuration " + name + " defined in plugin " + element.getDeclaringExtension().getNamespaceIdentifier(), e); //$NON-NLS-1$ //$NON-NLS-2$ } - String className = element.getAttribute("class"); //$NON-NLS-1$ if (vendor == null) vendor = "Unknown"; //$NON-NLS-1$ if (category == null) category = "Unknown"; //$NON-NLS-1$ if (types == null) types = "*"; //$NON-NLS-1$ diff --git a/rse/plugins/org.eclipse.rse.ui/systems/org/eclipse/rse/core/SystemResourceHelpers.java b/rse/plugins/org.eclipse.rse.ui/systems/org/eclipse/rse/core/SystemResourceHelpers.java index 603b222c626..10ed5998c64 100644 --- a/rse/plugins/org.eclipse.rse.ui/systems/org/eclipse/rse/core/SystemResourceHelpers.java +++ b/rse/plugins/org.eclipse.rse.ui/systems/org/eclipse/rse/core/SystemResourceHelpers.java @@ -191,10 +191,9 @@ public class SystemResourceHelpers implements FileFilter RSEUIPlugin.logError(msg, e); } */ - boolean ok = true; IFolder folder = getFolder(parentFolder, folderName); if (!exists(folder)) - ok = createFolder(folder); + createFolder(folder); return folder; } /** @@ -503,8 +502,7 @@ public class SystemResourceHelpers implements FileFilter file.refreshLocal(IResource.DEPTH_INFINITE, null); } catch (Exception exc) {} - boolean ok = true; - String name = file.getName(); + boolean ok = true; file.delete(true,false,null); // force-yes, keep-history-no, no progress monitor SystemResourceManager.turnOnResourceEventListening(); return ok; diff --git a/rse/plugins/org.eclipse.rse.ui/systems/org/eclipse/rse/core/comm/SystemCommunicationsDaemon.java b/rse/plugins/org.eclipse.rse.ui/systems/org/eclipse/rse/core/comm/SystemCommunicationsDaemon.java index ecf3fd79b8a..c3ab0ce5296 100644 --- a/rse/plugins/org.eclipse.rse.ui/systems/org/eclipse/rse/core/comm/SystemCommunicationsDaemon.java +++ b/rse/plugins/org.eclipse.rse.ui/systems/org/eclipse/rse/core/comm/SystemCommunicationsDaemon.java @@ -141,7 +141,7 @@ public class SystemCommunicationsDaemon extends Thread { } /** - * @see Thread.run() + * @see Thread#run() */ public void run() { byte[] buffer;