mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-24 09:25:31 +02:00
Code Issues Wiki Activity

The enablement of the step actions is calculated in the UI thread. This causes the UI locks for slow or unresponsive targets. Use the cached stack frames to calculate the enablement instead of requesting gdb.

Browse source
This commit is contained in:
Mikhail Khodjaiants 2004-11-23 23:47:49 +00:00
parent e1f0f37434
commit 70c6412de3
2 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
debug/org.eclipse.cdt.debug.core/ChangeLog
View file

@ -1,3 +1,9 @@
2004-11-23 Mikhail Khodjaiants
The enablement of the step actions is calculated in the UI thread. This causes
the UI locks for slow or unresponsive targets. Use the cached stack frames to
calculate the enablement instead of requesting gdb.
* CThread.java
2004-11-22 Mikhail Khodjaiants
Check if the pointer value is not null before pass it to the address factory.
* CValue.java

14
debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/model/CThread.java
View file

@ -462,13 +462,7 @@ public class CThread extends CDebugElement implements ICThread, IRestart, IResum
if ( !fConfig.supportsStepping() || !canResume() ) {
return false;
}
try {
List c = computeStackFrames();
return ( c.size() > 1 );
}
catch( DebugException e ) {
}
return false;
return ( fStackFrames.size() > 1 );
}
/**
@ -477,12 +471,10 @@ public class CThread extends CDebugElement implements ICThread, IRestart, IResum
* @return whether this thread is in a valid state to step
*/
protected boolean canStep() {
try {
return fConfig.supportsStepping() && isSuspended() && getTopStackFrame() != null;
}
catch( DebugException e ) {
if ( !fConfig.supportsStepping() || !isSuspended() ) {
return false;
}
return !fStackFrames.isEmpty();
}
/* (non-Javadoc)