diff --git a/codan/org.eclipse.cdt.codan.checkers/plugin.xml b/codan/org.eclipse.cdt.codan.checkers/plugin.xml index 117593b0117..607d62fe163 100644 --- a/codan/org.eclipse.cdt.codan.checkers/plugin.xml +++ b/codan/org.eclipse.cdt.codan.checkers/plugin.xml @@ -13,7 +13,7 @@ defaultSeverity="Warning" description="Finds statements like 'if (a=b)'" id="org.eclipse.cdt.codan.internal.checkers.AssignmentInConditionProblem" - messagePattern="Possible assignment in condition" + messagePattern="Possible assignment in condition ''{0}''" name="Assignment in condition"> @@ -39,6 +39,7 @@ @@ -55,7 +56,7 @@ description="Catching by reference is recommended by C++ experts, "Throw by value, catch by reference". For one thing, this avoids copying and potentially slicing the exception." id="org.eclipse.cdt.codan.internal.checkers.CatchByReference" name="Catching by reference is recommended" - messagePattern="Catching by reference is recommended for non-basic types"> + messagePattern="Catching by reference is recommended ''{0}''"> diff --git a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/AssignmentInConditionChecker.java b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/AssignmentInConditionChecker.java index aae0025ccce..8cf57d264fa 100644 --- a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/AssignmentInConditionChecker.java +++ b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/AssignmentInConditionChecker.java @@ -35,7 +35,7 @@ public class AssignmentInConditionChecker extends AbstractIndexAstChecker { public int visit(IASTExpression expression) { if (isAssignmentExpression(expression) && isUsedAsCondition(expression)) { - reportProblem(ER_ID, expression); + reportProblem(ER_ID, expression, expression.getRawSignature()); } return PROCESS_CONTINUE; } diff --git a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/CatchByReference.java b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/CatchByReference.java index ac9e852f85d..a96d3218f46 100644 --- a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/CatchByReference.java +++ b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/CatchByReference.java @@ -75,7 +75,7 @@ public class CatchByReference extends AbstractIndexAstChecker { || typeName instanceof IPointerType || typeName == null) continue; - reportProblem(ER_ID, decl); + reportProblem(ER_ID, decl, decl.getRawSignature()); } } } diff --git a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/CheckersMessages.java b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/CheckersMessages.java index 2eff513b4f7..6263a60b2f0 100644 --- a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/CheckersMessages.java +++ b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/CheckersMessages.java @@ -22,6 +22,7 @@ public class CheckersMessages extends NLS { public static String StatementHasNoEffectChecker_ParameterExceptions; public static String StatementHasNoEffectChecker_ParameterExceptionsItem; public static String StatementHasNoEffectChecker_ParameterMacro; + public static String SuggestedParenthesisChecker_SuggestParanthesesAroundNot; static { // initialize resource bundle NLS.initializeMessages(BUNDLE_NAME, CheckersMessages.class); diff --git a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/SuggestedParenthesisChecker.java b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/SuggestedParenthesisChecker.java index 72f1892dfb1..9ea8bba6779 100644 --- a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/SuggestedParenthesisChecker.java +++ b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/SuggestedParenthesisChecker.java @@ -56,14 +56,14 @@ public class SuggestedParenthesisChecker extends AbstractIndexAstChecker { return PROCESS_CONTINUE; if (precedence == 2) { // unary not if (isParamNot() && isUsedAsOperand(expression)) { - reportProblem(ER_ID, expression); + reportProblem(ER_ID, expression, expression.getRawSignature()); return PROCESS_SKIP; } } else if (precedence >= 0) { int pp = getPrecedence(parentExpr); if (pp == -1 || pp == precedence) return PROCESS_CONTINUE; - reportProblem(ER_ID, expression); + reportProblem(ER_ID, expression, expression.getRawSignature()); } } return PROCESS_CONTINUE; @@ -136,6 +136,6 @@ public class SuggestedParenthesisChecker extends AbstractIndexAstChecker { public void initPreferences(IProblemWorkingCopy problem) { super.initPreferences(problem); addPreference(problem, PARAM_NOT, - "Suggest parentesis around not operator", Boolean.FALSE); + CheckersMessages.SuggestedParenthesisChecker_SuggestParanthesesAroundNot, Boolean.FALSE); } } diff --git a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/messages.properties b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/messages.properties index a20ffc9fbae..efc7aedd8aa 100644 --- a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/messages.properties +++ b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/messages.properties @@ -3,3 +3,4 @@ ReturnChecker_Param0=Also check functions with implicit return value StatementHasNoEffectChecker_ParameterExceptions=Exceptions (value of the problem argument) StatementHasNoEffectChecker_ParameterExceptionsItem=Value of the argument StatementHasNoEffectChecker_ParameterMacro=Report problem in statements that comes from macro expansion +SuggestedParenthesisChecker_SuggestParanthesesAroundNot=Suggest parentesis around not operator