mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

tidy method hasBaseClass and rename to calculateInheritanceDepth

Browse source
This commit is contained in:
Andrew Ferguson 2007-10-17 17:34:51 +00:00
parent b8da02462e
commit 6a6fd2dc24
1 changed files with 64 additions and 63 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

123
core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPSemantics.java
View file

@ -2880,7 +2880,23 @@ public class CPPSemantics {
return cost; return cost;
} }
public static IType getUltimateType( IType type, boolean stopAtPointerToMember ){ /**
* Unravels a type by following purely typedefs
* @param type
* @return
*/
private static IType getUltimateTypeViaTypedefs(IType type) {
try {
while(type instanceof ITypedef) {
type= ((ITypedef)type).getType();
}
} catch(DOMException e) {
type= e.getProblem();
}
return type;
}
public static IType getUltimateType(IType type, boolean stopAtPointerToMember) {
try { try {
while( true ){ while( true ){
if( type instanceof ITypedef ) if( type instanceof ITypedef )
@ -3140,12 +3156,11 @@ public class CPPSemantics {
cost.rank = (cost.promotion > 0 ) ? Cost.PROMOTION_RANK : Cost.NO_MATCH_RANK; cost.rank = (cost.promotion > 0 ) ? Cost.PROMOTION_RANK : Cost.NO_MATCH_RANK;
} }
static private void conversion( Cost cost ) throws DOMException{ static private void conversion( Cost cost ) throws DOMException{
IType src = cost.source; IType src = cost.source;
IType trg = cost.target; IType trg = cost.target;
int temp = -1;
cost.conversion = 0; cost.conversion = 0;
cost.detail = 0; cost.detail = 0;
@ -3202,10 +3217,10 @@ public class CPPSemantics {
//4.10-3 An rvalue of type "pointer to cv D", where D is a class type can be converted //4.10-3 An rvalue of type "pointer to cv D", where D is a class type can be converted
//to an rvalue of type "pointer to cv B", where B is a base class of D. //to an rvalue of type "pointer to cv B", where B is a base class of D.
else if( s instanceof ICPPClassType && tPrev instanceof IPointerType && t instanceof ICPPClassType ){ else if( s instanceof ICPPClassType && tPrev instanceof IPointerType && t instanceof ICPPClassType ){
temp = hasBaseClass( (ICPPClassType)s, (ICPPClassType) t, false ); int depth= calculateInheritanceDepth( (ICPPClassType)s, (ICPPClassType) t );
cost.rank = ( temp > -1 ) ? Cost.CONVERSION_RANK : Cost.NO_MATCH_RANK; cost.rank= ( depth > -1 ) ? Cost.CONVERSION_RANK : Cost.NO_MATCH_RANK;
cost.conversion = ( temp > -1 ) ? temp : 0; cost.conversion= ( depth > -1 ) ? depth : 0;
cost.detail = 1; cost.detail= 1;
return; return;
} }
} }
@ -3227,10 +3242,10 @@ public class CPPSemantics {
IType st = spm.getType(); IType st = spm.getType();
IType tt = tpm.getType(); IType tt = tpm.getType();
if( st != null && tt != null && st.isSameType( tt ) ){ if( st != null && tt != null && st.isSameType( tt ) ){
temp = hasBaseClass( tpm.getMemberOfClass(), spm.getMemberOfClass(), false ); int depth= calculateInheritanceDepth( tpm.getMemberOfClass(), spm.getMemberOfClass() );
cost.rank = ( temp > -1 ) ? Cost.CONVERSION_RANK : Cost.NO_MATCH_RANK; cost.rank= ( depth > -1 ) ? Cost.CONVERSION_RANK : Cost.NO_MATCH_RANK;
cost.conversion = ( temp > -1 ) ? temp : 0; cost.conversion= ( depth > -1 ) ? depth : 0;
cost.detail = 1; cost.detail= 1;
} }
} }
} }
@ -3240,14 +3255,14 @@ public class CPPSemantics {
IType t = getUltimateType( cost.target, true ); IType t = getUltimateType( cost.target, true );
if( cost.targetHadReference && s instanceof ICPPClassType && t instanceof ICPPClassType ){ if( cost.targetHadReference && s instanceof ICPPClassType && t instanceof ICPPClassType ){
int temp = hasBaseClass( (ICPPClassType) s, (ICPPClassType) t, false ); int depth= calculateInheritanceDepth( (ICPPClassType) s, (ICPPClassType) t );
if(depth > -1){
cost.rank= Cost.DERIVED_TO_BASE_CONVERSION;
cost.conversion= depth;
}
}
}
if( temp > -1 ){
cost.rank = Cost.DERIVED_TO_BASE_CONVERSION;
cost.conversion = temp;
}
}
}
static private void relaxTemplateParameters( Cost cost ){ static private void relaxTemplateParameters( Cost cost ){
IType s = getUltimateType( cost.source, false ); IType s = getUltimateType( cost.source, false );
IType t = getUltimateType( cost.target, false ); IType t = getUltimateType( cost.target, false );
@ -3259,58 +3274,44 @@ public class CPPSemantics {
} }
} }
static private int hasBaseClass( IBinding symbol, IBinding base, boolean needVisibility ) throws DOMException { /**
if( symbol == base ){ * Calculates the number of edges in the inheritance path of <code>clazz</code> to
* <code>ancestorToFind</code>, returning -1 if no inheritance relationship is found.
* @param clazz the class to search upwards from
* @param ancestorToFind the class to find in the inheritance graph
* @return the number of edges in the inheritance graph, or -1 if the specifide classes have
* no inheritance relation
* @throws DOMException
*/
private static int calculateInheritanceDepth(ICPPClassType clazz, ICPPClassType ancestorToFind) throws DOMException {
if(clazz == ancestorToFind || clazz.isSameType(ancestorToFind))
return 0; return 0;
}
ICPPClassType clsSymbol = null;
ICPPClassType clsBase = null;
IType temp = null;
while( symbol instanceof ITypedef ){
temp = ((ITypedef)symbol).getType();
if( temp instanceof IBinding )
symbol = (IBinding) temp;
else return -1;
}
if( symbol instanceof ICPPClassType )
clsSymbol = (ICPPClassType) symbol;
else return -1;
while( base instanceof ITypedef ){ ICPPBase [] bases = clazz.getBases();
temp = ((ITypedef)base).getType(); for(int i=0; i<bases.length; i++) {
if( temp instanceof IBinding ) IBinding base = bases[i].getBaseClass();
base= (IBinding) temp; if(base instanceof IType) {
else return -1; IType tbase= (IType) base;
} if( tbase.isSameType(ancestorToFind) ||
if( base instanceof ICPPClassType ) (ancestorToFind instanceof ICPPSpecialization && /*allow some flexibility with templates*/
clsBase = (ICPPClassType) base; ((IType)((ICPPSpecialization)ancestorToFind).getSpecializedBinding()).isSameType(tbase) ) )
else return -1;
IBinding parent = null;
ICPPBase [] bases = clsSymbol.getBases();
for( int i = 0; i < bases.length; i ++ ){
ICPPBase wrapper = bases[i];
parent = bases[i].getBaseClass();
boolean isVisible = ( wrapper.getVisibility() == ICPPBase.v_public);
if( parent instanceof IType &&
( ((IType)parent).isSameType( clsBase ) ||
( clsBase instanceof ICPPSpecialization && //allow some flexibility with templates
((IType)((ICPPSpecialization)clsBase).getSpecializedBinding()).isSameType( (IType) parent ) ) ) )
{ {
if( needVisibility && !isVisible )
return -1;
return 1; return 1;
} }
int n = hasBaseClass( parent, clsBase, needVisibility );
if( n > 0 ) tbase= getUltimateTypeViaTypedefs(tbase);
return n + 1; if(tbase instanceof ICPPClassType) {
int n= calculateInheritanceDepth((ICPPClassType) tbase, ancestorToFind );
if(n>0)
return n+1;
} }
}
}
return -1; return -1;
} }
public static ICPPFunction findOperator( IASTExpression exp, ICPPClassType cls ){ public static ICPPFunction findOperator( IASTExpression exp, ICPPClassType cls ){
IScope scope = null; IScope scope = null;
try { try {