mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-08 02:06:01 +02:00
Code Issues Wiki Activity

Bug 435142 - Duplicate *running events cause UI slowness

Browse source 
Change-Id: I4b30e6cd62b7cc822442ddd14c3c1440f6bab376
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/26780
Tested-by: Hudson CI
Reviewed-by: Mikhail Khodjaiants <mikhailkhod@googlemail.com>
Reviewed-by: Alvaro Sanchez-Leon <alvsan09@gmail.com>
This commit is contained in:
Marc Khouzam 2014-05-16 16:30:09 -04:00
parent 44d66b4750
commit 6996d3f93c
2 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBRunControl_7_0_NS.java
View file

@ -1529,12 +1529,18 @@ public class GDBRunControl_7_0_NS extends AbstractDsfService implements IMIRunCo
return; return;
} }
MIThreadRunState threadState = fThreadRunStates.get(e.getDMContext());
if (threadState != null && threadState.fLatestEvent instanceof IResumedDMEvent) {
// Ignore multiple running events in a row. They will only slow down the UI
// for no added value.
return;
}
if (fRunToLineActiveOperation == null && fStepInToSelectionActiveOperation == null) { if (fRunToLineActiveOperation == null && fStepInToSelectionActiveOperation == null) {
// No special case here, i.e. send notification // No special case here, i.e. send notification
getSession().dispatchEvent(new ResumedEvent(e.getDMContext(), e), getProperties()); getSession().dispatchEvent(new ResumedEvent(e.getDMContext(), e), getProperties());
} else { } else {
// Either RunToLine or StepIntoSelection operations are active // Either RunToLine or StepIntoSelection operations are active
MIThreadRunState threadState = fThreadRunStates.get(e.getDMContext());
if (threadState == null || threadState.fLatestEvent instanceof ISuspendedDMEvent) { if (threadState == null || threadState.fLatestEvent instanceof ISuspendedDMEvent) {
// Need to send out Running event notification, only once per operation, then a stop event is expected // Need to send out Running event notification, only once per operation, then a stop event is expected
// at the end of the operation // at the end of the operation

8
dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIRunControl.java
View file

@ -482,13 +482,19 @@ public class MIRunControl extends AbstractDsfService implements IMIRunControl, I
* @noreference This method is not intended to be referenced by clients. * @noreference This method is not intended to be referenced by clients.
*/ */
@DsfServiceEventHandler @DsfServiceEventHandler
public void eventDispatched(final MIRunningEvent e) { public void eventDispatched(MIRunningEvent e) {
if (fDisableNextRunningEvent) { if (fDisableNextRunningEvent) {
fDisableNextRunningEvent = false; fDisableNextRunningEvent = false;
// We don't broadcast this running event // We don't broadcast this running event
return; return;
} }
if (fLatestEvent instanceof IResumedDMEvent) {
// Ignore multiple running events in a row. They will only slow down the UI
// for no added value.
return;
}
IDMEvent<?> event = null; IDMEvent<?> event = null;
// Find the container context, which is used in multi-threaded debugging. // Find the container context, which is used in multi-threaded debugging.
IContainerDMContext containerDmc = DMContexts.getAncestorOfType(e.getDMContext(), IContainerDMContext.class); IContainerDMContext containerDmc = DMContexts.getAncestorOfType(e.getDMContext(), IContainerDMContext.class);