From 66e6b8bb9205fec5215dab377cfe68aaf1b633e2 Mon Sep 17 00:00:00 2001 From: David McKnight Date: Wed, 4 Jul 2007 18:24:36 +0000 Subject: [PATCH] [192705] exception needs to be thrown when rename fails --- .../internal/services/local/files/LocalFileService.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/rse/plugins/org.eclipse.rse.services.local/src/org/eclipse/rse/internal/services/local/files/LocalFileService.java b/rse/plugins/org.eclipse.rse.services.local/src/org/eclipse/rse/internal/services/local/files/LocalFileService.java index df180438ee8..05797a943ca 100644 --- a/rse/plugins/org.eclipse.rse.services.local/src/org/eclipse/rse/internal/services/local/files/LocalFileService.java +++ b/rse/plugins/org.eclipse.rse.services.local/src/org/eclipse/rse/internal/services/local/files/LocalFileService.java @@ -16,6 +16,7 @@ * Martin Oberhuber (Wind River) - [186128] Move IProgressMonitor last in all API * Kevin Doyle (IBM) - [182221] Throwing Proper Exceptions on create file/folder * Xuan Chen (IBM) - Fix 189487 - copy and paste a folder did not work - workbench hang + * David McKnight (IBM) - [192705] Exception needs to be thrown when rename fails ********************************************************************************/ package org.eclipse.rse.internal.services.local.files; @@ -997,7 +998,13 @@ public class LocalFileService extends AbstractFileService implements IFileServic return renameVirtualFile(fileToRename, newName); } File newFile = new File(remoteParent, newName); - return fileToRename.renameTo(newFile); + boolean result = fileToRename.renameTo(newFile); + if (!result) + { + // for 192705, we need to throw an exception when rename fails + throw new SystemMessageException(getMessage("RSEF1301").makeSubstitution(newFile)); //$NON-NLS-1$ + } + return result; } public boolean rename(String remoteParent, String oldName, String newName, IHostFile oldFile, IProgressMonitor monitor) throws SystemMessageException