From 66b367c79f0f800ef8def78793d93fe53a5bdcce Mon Sep 17 00:00:00 2001 From: Mikhail Khodjaiants Date: Thu, 11 Nov 2004 21:28:40 +0000 Subject: [PATCH] Fix for bug 75627: Incorrect limit to port numbers. --- debug/org.eclipse.cdt.debug.mi.ui/ChangeLog | 4 ++++ .../eclipse/cdt/debug/mi/internal/ui/TCPSettingsBlock.java | 6 ++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/debug/org.eclipse.cdt.debug.mi.ui/ChangeLog b/debug/org.eclipse.cdt.debug.mi.ui/ChangeLog index 8a9dbf1085a..fd2fae1225f 100644 --- a/debug/org.eclipse.cdt.debug.mi.ui/ChangeLog +++ b/debug/org.eclipse.cdt.debug.mi.ui/ChangeLog @@ -1,3 +1,7 @@ +2004-11-11 Mikhail Khodjaiants + Fix for bug 75627: Incorrect limit to port numbers. + * TCPSettingsBlock.java + 2004-11-08 Mikhail Khodjaiants Added the "Automatically refresh registers" and "Automatically refresh shared libraries" preferences and properties. diff --git a/debug/org.eclipse.cdt.debug.mi.ui/src/org/eclipse/cdt/debug/mi/internal/ui/TCPSettingsBlock.java b/debug/org.eclipse.cdt.debug.mi.ui/src/org/eclipse/cdt/debug/mi/internal/ui/TCPSettingsBlock.java index 7b3f8299fd9..9b43118288c 100644 --- a/debug/org.eclipse.cdt.debug.mi.ui/src/org/eclipse/cdt/debug/mi/internal/ui/TCPSettingsBlock.java +++ b/debug/org.eclipse.cdt.debug.mi.ui/src/org/eclipse/cdt/debug/mi/internal/ui/TCPSettingsBlock.java @@ -188,13 +188,11 @@ public class TCPSettingsBlock extends Observable { private boolean portNumberIsValid( String portNumber ) { try { - int port = Short.parseShort( portNumber ); - if ( port < 0 ) - return false; + int port = Integer.parseInt( portNumber ); + return ( port > 0 && port <= 0xFFFF ); } catch( NumberFormatException e ) { return false; } - return true; } } \ No newline at end of file