mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-22 14:12:10 +02:00
Code Issues Wiki Activity

[releng] Update code cleanliness to better handle non-JDT/PDE projects

Browse source 
This commit on its own fails cleanliness, but is separated out
to make review easier. The subsequent commit is the result of
cleaning the code with the script

Change-Id: Ibaddc2f338f14fbe60662acc8cb272b584a1a828
This commit is contained in:
Jonah Graham 2020-02-19 13:05:26 -05:00
parent 7cd1995573
commit 646273d9a4
1 changed files with 20 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
releng/scripts/check_code_cleanliness.sh
View file

@ -54,11 +54,12 @@ done
## ##
git ls-files -- \*\*/.project ":!$COREPROJECT/.project" | while read i ; do git ls-files -- \*\*/.project ":!$COREPROJECT/.project" | while read i ; do
d=`dirname $i`; d=`dirname $i`;
if test ! -e $d/feature.xml; then natures=$(xmllint --xpath 'string(//projectDescription/natures)' $i)
mkdir -p $d/.settings mkdir -p $d/.settings
# JDT
if [[ $natures == *"org.eclipse.jdt.core.javanature"* ]]; then
cp $COREPROJECT/.settings/org.eclipse.jdt.* $d/.settings cp $COREPROJECT/.settings/org.eclipse.jdt.* $d/.settings
cp $COREPROJECT/.settings/org.eclipse.pde.prefs $d/.settings
cp $COREPROJECT/.settings/org.eclipse.pde.api.tools.prefs $d/.settings
# For test plug-ins we are more lenient so don't warn on some items # For test plug-ins we are more lenient so don't warn on some items
if echo $i | grep -E '\.tests?[/\.]' > /dev/null; then if echo $i | grep -E '\.tests?[/\.]' > /dev/null; then
sed -i \ sed -i \
@ -77,15 +78,27 @@ git ls-files -- \*\*/.project ":!$COREPROJECT/.project" | while read i ; do
'-es@org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning@org.eclipse.jdt.core.compiler.problem.rawTypeReference=ignore@' \ '-es@org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning@org.eclipse.jdt.core.compiler.problem.rawTypeReference=ignore@' \
'-es@org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning@org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=ignore@' \ '-es@org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning@org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=ignore@' \
$d/.settings/org.eclipse.jdt.core.prefs $d/.settings/org.eclipse.jdt.core.prefs
sed -i \
'-es@compilers.p.not-externalized-att=1@compilers.p.not-externalized-att=2@' \
$d/.settings/org.eclipse.pde.prefs
fi fi
if echo $i | grep 'org.eclipse.cdt.examples.dsf' > /dev/null; then if echo $i | grep 'org.eclipse.cdt.examples.dsf' > /dev/null; then
sed -i \ sed -i \
'-es@org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning@org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore@' \ '-es@org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning@org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore@' \
$d/.settings/org.eclipse.jdt.core.prefs $d/.settings/org.eclipse.jdt.core.prefs
fi fi
else
rm -f $d/.settings/org.eclipse.jdt*.prefs
fi
# PDE
if [[ $natures == *"org.eclipse.pde.PluginNature"* ]]; then
cp $COREPROJECT/.settings/org.eclipse.pde.prefs $d/.settings
cp $COREPROJECT/.settings/org.eclipse.pde.api.tools.prefs $d/.settings
if echo $i | grep -E '\.tests?[/\.]' > /dev/null; then
sed -i \
'-es@compilers.p.not-externalized-att=1@compilers.p.not-externalized-att=2@' \
$d/.settings/org.eclipse.pde.prefs
fi
else
rm -f $d/.settings/org.eclipse.pde*.prefs
fi fi
done done