From 6434dd05593b9eba0ea9ca41396f61102d146ea2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torbj=C3=B6rn=20Svensson?= Date: Sat, 7 May 2022 20:14:17 +0200 Subject: [PATCH] Bug 579876: Don't assume background is white for disassembly view MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The trail in the disassbemly view should have luminance going towards the background color, that might be different color than white. Contributed by STMicroelectronics Change-Id: I9e00e71719cbd1fb40cc5e6de983aacbcb854106 Signed-off-by: Torbjörn Svensson --- .../dsf/debug/internal/ui/disassembly/DisassemblyPart.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyPart.java b/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyPart.java index 58e1072791b..73ab03b6f63 100644 --- a/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyPart.java +++ b/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyPart.java @@ -2933,9 +2933,10 @@ public abstract class DisassemblyPart extends WorkbenchPart } // update pc history trail if (fPCHistory.size() > 1) { + final double bgLuminance = new HSL(fViewer.getTextWidget().getBackground().getRGB()).luminance; HSL hsv = new HSL(fPCAnnotationRGB); - double luminanceStep = (1 - hsv.luminance) / (fPCHistorySizeMax + 1); - hsv.luminance = 1 - luminanceStep * (fPCHistorySizeMax - fPCHistory.size()); + double luminanceStep = (bgLuminance - hsv.luminance) / (fPCHistorySizeMax + 1); + hsv.luminance = bgLuminance - luminanceStep * (fPCHistorySizeMax - fPCHistory.size()); for (ListIterator listIt = fPCHistory.listIterator(fPCHistory.size()); listIt .hasPrevious();) { AddressRangePosition pcPos = listIt.previous();