mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-11 02:05:39 +02:00
Code Issues Wiki Activity

RESOLVED - bug 170615: Need access to ProgressMonitor in MBS Custom Pages

Browse source 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=170615
This commit is contained in:
Chris Recoskie 2007-04-25 14:00:22 +00:00
parent 1346d01ba1
commit 6405b3a368
2 changed files with 15 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
build/org.eclipse.cdt.managedbuilder.ui/schema/newWizardPages.exsd
View file

@ -87,7 +87,7 @@ For convenience, there is an org.eclipse.cdt.managedbuilder.ui.wizards.MBSCustom
<attribute name="operationClass" type="string"> <attribute name="operationClass" type="string">
<annotation> <annotation>
<documentation> <documentation>
Specifies the Java class which implements the operations associated with this page. The class must implement the java.lang.Runnable interface. Specifies the Java class which implements the operations associated with this page. The class must implement either the java.lang.Runnable interface, or the org.eclipse.jface.operation.IRunnableWithProgress interface if progress reporting is desired.
</documentation> </documentation>
<appInfo> <appInfo>
<meta.attribute kind="java"/> <meta.attribute kind="java"/>

18
build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/wizards/MBSCustomPageManager.java
View file

@ -191,7 +191,7 @@ public final class MBSCustomPageManager
// String operationClassName = element.getAttribute(OPERATION_CLASS); // optional element so may be null // String operationClassName = element.getAttribute(OPERATION_CLASS); // optional element so may be null
IWizardPage wizardPage = null; IWizardPage wizardPage = null;
Runnable operation = null; Object operation = null;
// instantiate the classes specified in the manifest // instantiate the classes specified in the manifest
// first try to create the page class, which is required // first try to create the page class, which is required
@ -201,7 +201,7 @@ public final class MBSCustomPageManager
// the operation is an optional element so it might not be present // the operation is an optional element so it might not be present
if (element.getAttribute(OPERATION_CLASS) != null) if (element.getAttribute(OPERATION_CLASS) != null)
operation = (Runnable) element.createExecutableExtension(OPERATION_CLASS); operation = element.createExecutableExtension(OPERATION_CLASS);
} }
catch (CoreException e) catch (CoreException e)
{ {
@ -210,8 +210,18 @@ public final class MBSCustomPageManager
} }
// create the page data and add it to ourselves // create the page data and add it to ourselves
MBSCustomPageData currentPageData = new MBSCustomPageData(id, MBSCustomPageData currentPageData;
wizardPage, operation, false);
// Custom pages prior to CDT 4.0 were required to provide Runnables as operations.
// Post 4.0, IRunnableWithProgress are accepted as well.
if (operation instanceof Runnable) {
currentPageData = new MBSCustomPageData(id, wizardPage, (Runnable) operation, false);
} else if (operation instanceof IRunnableWithProgress) {
currentPageData = new MBSCustomPageData(id, wizardPage, (IRunnableWithProgress) operation, false);
} else {
throw new BuildException(element.getName());
}
idToPageDataMap.put(id, currentPageData); idToPageDataMap.put(id, currentPageData);
pageSet.add(currentPageData); pageSet.add(currentPageData);