mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-09 01:05:38 +02:00
Code Issues Wiki Activity

Bug 338467 - Codan calls "before" and "after" even for checkers that are not supposed to run in a launch mode. Patch by Alex Ruiz.

Browse source
This commit is contained in:
Sergey Prigogin 2011-03-04 23:25:33 +00:00
parent 9a7ecdfa7c
commit 63b1a31bb5
1 changed files with 8 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/internal/core/CodanBuilder.java
View file

@ -1,5 +1,5 @@
/******************************************************************************* /*******************************************************************************
* Copyright (c) 2009, 2010 Alena Laskavaia * Copyright (c) 2009, 2011 Alena Laskavaia
* All rights reserved. This program and the accompanying materials * All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0 * are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at * which accompanies this distribution, and is available at
@ -129,16 +129,16 @@ public class CodanBuilder extends IncrementalProjectBuilder implements ICodanBui
try { try {
if (monitor.isCanceled()) if (monitor.isCanceled())
return; return;
if (checker.enabledInContext(resource) && chegistry.isCheckerEnabledForLaunchMode(checker, resource, checkerLaunchMode)) { if (doesCheckerSupportLaunchMode(checker, checkerLaunchMode)
&& checker.enabledInContext(resource)
&& chegistry.isCheckerEnabledForLaunchMode(checker, resource, checkerLaunchMode)) {
synchronized (checker) { synchronized (checker) {
try { try {
checker.before(resource); checker.before(resource);
if (chegistry.isCheckerEnabled(checker, resource)) { if (chegistry.isCheckerEnabled(checker, resource)) {
//long time = System.currentTimeMillis(); //long time = System.currentTimeMillis();
if (checkerLaunchMode == CheckerLaunchMode.RUN_AS_YOU_TYPE) { if (checkerLaunchMode == CheckerLaunchMode.RUN_AS_YOU_TYPE) {
if (checker.runInEditor() && checker instanceof IRunnableInEditorChecker) { ((IRunnableInEditorChecker) checker).processModel(model);
((IRunnableInEditorChecker) checker).processModel(model);
}
} else { } else {
checker.processResource(resource); checker.processResource(resource);
} }
@ -178,12 +178,9 @@ public class CodanBuilder extends IncrementalProjectBuilder implements ICodanBui
} }
} }
/** private boolean doesCheckerSupportLaunchMode(IChecker checker, CheckerLaunchMode mode) {
* @param checker if (mode == CheckerLaunchMode.RUN_AS_YOU_TYPE)
* @return return checker.runInEditor() && checker instanceof IRunnableInEditorChecker;
*/
private boolean isEnabledForLaunchMode(IChecker checker) {
// TODO Auto-generated method stub
return true; return true;
} }