From 60105e8ddfb2caf54a144ba84a0f04b9212faab5 Mon Sep 17 00:00:00 2001 From: Martin Oberhuber < martin.oberhuber@windriver.com> Date: Fri, 2 May 2008 13:45:11 +0000 Subject: [PATCH] [cleanup] Fix @since tag format --- .../rse/ui/messages/SystemMessageDialog.java | 13 +++++++++---- .../rse/ui/operations/SystemFetchOperation.java | 8 ++++++-- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/messages/SystemMessageDialog.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/messages/SystemMessageDialog.java index 5b9aa20fc21..2da89135a6e 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/messages/SystemMessageDialog.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/messages/SystemMessageDialog.java @@ -60,7 +60,7 @@ import org.eclipse.swt.widgets.Text; /** * A dialog for showing SystemMessages and optionally asking the user for Yes / * No / Ok / Cancel type of response. - * + * * The client may choose to construct and open the dialog itself, or use one of * the provided static factory methods, which construct the dialog and * synchronously open it without thread switch (must be called on the UI @@ -509,9 +509,14 @@ public class SystemMessageDialog extends ErrorDialog implements Listener { } /** - * opens the dialog with an optional Yes/No or OK, Details button for an Inquiry/Question message. - * Eats up the IndicatorException, so only call this when you know what you are doing! - * @since 3.0 taking a boolean arg + * opens the dialog with an optional Yes/No or OK, Details button for an + * Inquiry/Question message. Eats up the IndicatorException, so only call + * this when you know what you are doing! + * + * Before RSE 3.0, this method had no arguments. Since RSE 3.0, it is taking + * a boolean argument. + * + * @since org.eclipse.rse.ui 3.0 */ public boolean openQuestionNoException(boolean showYesNo) { diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/operations/SystemFetchOperation.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/operations/SystemFetchOperation.java index 564d3b6c074..383bd04fb7e 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/operations/SystemFetchOperation.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/operations/SystemFetchOperation.java @@ -160,7 +160,7 @@ public class SystemFetchOperation extends JobChangeAdapter implements IRunnableW public class PromptForPassword implements Runnable { public SubSystem _ss; - private boolean isCancelled = false; + private volatile boolean isCancelled = false; public PromptForPassword(SubSystem ss) { _ss = ss; @@ -183,7 +183,11 @@ public class SystemFetchOperation extends JobChangeAdapter implements IRunnableW } /** - * @since org.eclipse.rse.ui 3.0 renamed from isCanceled to isCancelled + * Test whether this operation is cancelled. + * + * This method was renamed from isCanceled to isCancelled in RSE 3.0. + * + * @since org.eclipse.rse.ui 3.0 * @return true if cancelled */ public boolean isCancelled() {