From 5edac6e20c69845546fe873268989f53b5f55a48 Mon Sep 17 00:00:00 2001 From: Jeff Johnston Date: Fri, 26 Apr 2019 11:46:41 -0400 Subject: [PATCH] Bug 546395 - Added "copy qualified name" feature - fix isValidSelection() to not bog down performance Change-Id: I8d3b595c988f09c731d76b8174f5175b31115460 --- .../ui/actions/CopyQualifiedNameAction.java | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/CopyQualifiedNameAction.java b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/CopyQualifiedNameAction.java index 1e6444cc1a7..222ebce1f3d 100644 --- a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/CopyQualifiedNameAction.java +++ b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/CopyQualifiedNameAction.java @@ -82,23 +82,7 @@ public class CopyQualifiedNameAction extends TextEditorAction { private boolean isValidSelection(ITextSelection selection) { if (selection == null || selection.isEmpty() || selection.getLength() <= 0) return false; - final int offset = selection.getOffset(); - final int length = selection.getLength(); - ITranslationUnit translationUnit = (ITranslationUnit) CDTUITools - .getEditorInputCElement(fEditor.getEditorInput()); - String qualName = null; - try { - IASTTranslationUnit ast = translationUnit.getAST(null, 0); - if (ast != null) { - IASTNode enclosingNode = ast.getNodeSelector(null).findEnclosingNode(offset, length); - NameVisitor n = new NameVisitor(); - enclosingNode.accept(n); - qualName = n.getQualifiedName(); - } - } catch (CoreException e) { - return false; - } - return qualName != null; + return true; } @Override