From 5e5d6a0505d822cff45bcbd5fd97c549069613fd Mon Sep 17 00:00:00 2001 From: Mikhail Khodjaiants Date: Tue, 10 Jul 2012 13:34:38 -0400 Subject: [PATCH] Bug 384756 - Projectless debugging: no error is reported if a directory is specified as the program path Change-Id: I4800d6851d3d086cc59963bd2bd44e4584a78d0b Reviewed-on: https://git.eclipse.org/r/6691 Reviewed-by: Marc Khouzam IP-Clean: Marc Khouzam Tested-by: Marc Khouzam Reviewed-by: Mikhail Khodjaiants IP-Clean: Mikhail Khodjaiants Tested-by: Mikhail Khodjaiants --- .../cdt/dsf/gdb/internal/ui/launching/CMainTab.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/launching/CMainTab.java b/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/launching/CMainTab.java index dcb0270820d..2ca26c25dcd 100644 --- a/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/launching/CMainTab.java +++ b/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/launching/CMainTab.java @@ -470,10 +470,15 @@ public class CMainTab extends CAbstractMainTab { if (exePath.isAbsolute()) { // For absolute paths, we don't need a project, we can debug the binary directly // as long as it exists - if (!exePath.toFile().exists()) { + File executable = exePath.toFile(); + if (!executable.exists()) { setErrorMessage(LaunchMessages.getString("CMainTab.Program_does_not_exist")); //$NON-NLS-1$ return false; } + if (!executable.isFile()) { + setErrorMessage(LaunchMessages.getString("CMainTab.Selection_must_be_file")); //$NON-NLS-1$ + return false; + } } else { // For relative paths, we need a proper project String projectName = fProjText.getText().trim();