mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-22 06:02:11 +02:00
Code Issues Wiki Activity

Bug 511029 - Debug views become permanently pinned...

Browse source 
... if they are closed and reopened whilst pinned.

This was because IPartListener2 was being removed before #partClosed()
was called.

Change-Id: I16de016387131b775237b5d61639bb32107231fe
Signed-off-by: Bruno Medeiros <bruno.do.medeiros@gmail.com>
This commit is contained in:
Bruno Medeiros 2017-01-25 13:28:16 +00:00 • committed by Gerrit Code Review @ Eclipse.org
parent d45c67967a
commit 5c93171cbc
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/PinDebugContextActionDelegate.java
View file

@ -145,10 +145,7 @@ public class PinDebugContextActionDelegate implements IViewActionDelegate, IActi
public void partClosed(IWorkbenchPartReference partRef) { public void partClosed(IWorkbenchPartReference partRef) {
IWorkbenchPart part = partRef.getPart(false); IWorkbenchPart part = partRef.getPart(false);
if (part.equals(fPart)) { if (part.equals(fPart)) {
if (fAction.isChecked()) { unpinPart();
DebugEventFilterService.getInstance().removeDebugEventFilter(fPart);
fAction.setChecked(false);
}
} }
} }
@Override @Override
@ -174,6 +171,14 @@ public class PinDebugContextActionDelegate implements IViewActionDelegate, IActi
public void dispose() { public void dispose() {
DebugUITools.removePartDebugContextListener(fPart.getSite(), this); DebugUITools.removePartDebugContextListener(fPart.getSite(), this);
fPart.getSite().getWorkbenchWindow().getPartService().removePartListener(fPartListener); fPart.getSite().getWorkbenchWindow().getPartService().removePartListener(fPartListener);
unpinPart();
}
protected void unpinPart() {
if (fAction.isChecked()) {
DebugEventFilterService.getInstance().removeDebugEventFilter(fPart);
fAction.setChecked(false);
}
} }
protected ISelection getActiveDebugContext() { protected ISelection getActiveDebugContext() {