From 5be124e20066016fb85f1adff645386a879aaf80 Mon Sep 17 00:00:00 2001 From: David Dykstal Date: Thu, 19 Apr 2007 06:04:49 +0000 Subject: [PATCH] [170932][api][refactor] revamp persistence manager interface --- .../rse/core/SystemResourceManager.java | 14 - .../rse/core/filters/ISystemFilterPool.java | 3 +- .../ISystemFilterPoolReferenceManager.java | 3 +- .../core/filters/SystemFilterPoolManager.java | 149 ++---- .../src/org/eclipse/rse/core/model/Host.java | 9 +- .../eclipse/rse/core/model/IPropertySet.java | 7 + .../core/model/IRSEPersistableContainer.java | 20 +- .../rse/core/model/ISystemProfileManager.java | 13 +- .../rse/core/model/ISystemRegistry.java | 3 - .../org/eclipse/rse/core/model/Property.java | 45 +- .../eclipse/rse/core/model/PropertySet.java | 51 +- .../rse/core/model/PropertySetContainer.java | 3 + .../rse/core/model/RSEModelObject.java | 19 +- .../rse/core/model/RSEModelOperation.java | 4 +- .../rse/core/model/RSEPersistableObject.java | 52 +-- .../subsystems/AbstractConnectorService.java | 8 +- .../AbstractDelegatingConnectorService.java | 29 +- .../internal/core/filters/SystemFilter.java | 2 + .../core/filters/SystemFilterPool.java | 117 +---- .../filters/SystemFilterPoolReference.java | 95 ++-- .../SystemFilterPoolReferenceManager.java | 25 +- .../core/filters/SystemFilterString.java | 1 - .../internal/core}/model/SystemProfile.java | 50 +- .../core}/model/SystemProfileManager.java | 359 ++++++-------- .../core/subsystems/ServerLauncher.java | 9 +- .../persistence/RSEPersistenceManager.java | 439 ++++++++---------- .../persistence/dom/RSEDOMExporter.java | 15 +- .../persistence/dom/RSEDOMImporter.java | 84 ++-- .../persistence/IRSEPersistenceManager.java | 99 ++-- .../rse/persistence/dom/RSEDOMNode.java | 14 +- .../rse/internal/ui/SystemProfileForm.java | 8 +- .../SystemProfileNameSelectAction.java | 4 +- .../ui/dialogs/SystemCopyProfileDialog.java | 7 +- .../ui/view/SystemViewConnectionAdapter.java | 2 +- .../SystemViewFilterPoolReferenceAdapter.java | 65 ++- .../SystemTeamViewActiveProfileAction.java | 4 +- ...SystemTeamViewMakeActiveProfileAction.java | 4 +- ...stemTeamViewMakeInActiveProfileAction.java | 4 +- .../team/SystemTeamViewProfileAdapter.java | 6 +- .../UI/org/eclipse/rse/ui/RSEUIPlugin.java | 6 +- .../rse/ui/actions/SystemBaseCopyAction.java | 4 +- .../rse/ui/validators/ValidatorFactory.java | 27 ++ .../ui/validators/ValidatorUniqueString.java | 17 +- .../rse/internal/model/SystemHostPool.java | 9 +- .../org/eclipse/rse/model/SystemRegistry.java | 23 +- .../eclipse/rse/model/SystemStartHere.java | 4 +- .../rse/core/subsystems/SubSystem.java | 11 +- .../subsystems/SubSystemConfiguration.java | 32 +- 48 files changed, 896 insertions(+), 1082 deletions(-) rename rse/plugins/{org.eclipse.rse.ui/model/org/eclipse/rse/internal => org.eclipse.rse.core/src/org/eclipse/rse/internal/core}/model/SystemProfile.java (82%) rename rse/plugins/{org.eclipse.rse.ui/model/org/eclipse/rse/internal => org.eclipse.rse.core/src/org/eclipse/rse/internal/core}/model/SystemProfileManager.java (62%) create mode 100644 rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/validators/ValidatorFactory.java diff --git a/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/SystemResourceManager.java b/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/SystemResourceManager.java index 53b996df27b..ae76f04064e 100644 --- a/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/SystemResourceManager.java +++ b/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/SystemResourceManager.java @@ -274,17 +274,6 @@ public class SystemResourceManager implements SystemResourceConstants } */ - // ----------------------------------- - // GET A SPECIFIC PROFILE FOLDER... - // ----------------------------------- - /** - * Get profiles folder for a given profile - */ - public static IFolder getProfileFolder(ISystemProfile profile) - { - return getProfileFolder(profile.getName()); - } - /** * Get profiles folder for a given profile name */ @@ -293,9 +282,6 @@ public class SystemResourceManager implements SystemResourceConstants return getResourceHelpers().getOrCreateFolder(getRemoteSystemsProject(),profileName); } - - - /* * -------------------------------------------------------------------------------------------------------------------------------- * USER ACTIONS SUBTREE FOLDER METHODS... diff --git a/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/filters/ISystemFilterPool.java b/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/filters/ISystemFilterPool.java index d1a320015c6..d0b6732cb7d 100644 --- a/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/filters/ISystemFilterPool.java +++ b/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/filters/ISystemFilterPool.java @@ -337,6 +337,5 @@ public interface ISystemFilterPool extends IRSEPersistableReferencedObject, ISys * @generated */ void setNonRenamable(boolean value); - - public ISystemFilterPool createSystemFilterPool(String name, boolean allowNestedFilters, boolean isDeletable, boolean tryToRestore); + } \ No newline at end of file diff --git a/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/filters/ISystemFilterPoolReferenceManager.java b/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/filters/ISystemFilterPoolReferenceManager.java index e9d8cb08603..c271c153d74 100644 --- a/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/filters/ISystemFilterPoolReferenceManager.java +++ b/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/filters/ISystemFilterPoolReferenceManager.java @@ -201,11 +201,10 @@ public interface ISystemFilterPoolReferenceManager extends IRSEBasePersistableRe * Given a filter pool name, create a referencing object and add it to the list. * This creates an unresolved reference to that filter pool. It will be resolved on first use. *

Calls back to inform provider - * @param filterPoolManager the manager that can be used to resolve the reference. * @param filterPoolName the name of the filter pool being referenced. * @return new filter pool reference */ - public ISystemFilterPoolReference addReferenceToSystemFilterPool(ISystemFilterPoolManager filterPoolManager, String filterPoolName); + public ISystemFilterPoolReference addReferenceToSystemFilterPool(String filterPoolName); /** * Given a filter pool, locate the referencing object for it and remove it from the list. diff --git a/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/filters/SystemFilterPoolManager.java b/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/filters/SystemFilterPoolManager.java index 81db2942466..17fe547ff00 100644 --- a/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/filters/SystemFilterPoolManager.java +++ b/rse/plugins/org.eclipse.rse.core/src/org/eclipse/rse/core/filters/SystemFilterPoolManager.java @@ -18,6 +18,7 @@ package org.eclipse.rse.core.filters; import java.util.ArrayList; import java.util.Iterator; +import java.util.List; import java.util.Vector; import org.eclipse.core.resources.IFile; @@ -25,15 +26,11 @@ import org.eclipse.core.resources.IFolder; import org.eclipse.rse.core.RSECorePlugin; import org.eclipse.rse.core.model.IRSEPersistableContainer; import org.eclipse.rse.core.model.ISystemProfile; -import org.eclipse.rse.core.model.ISystemRegistry; import org.eclipse.rse.core.model.RSEPersistableObject; import org.eclipse.rse.core.references.IRSEBaseReferencingObject; import org.eclipse.rse.internal.core.filters.ISystemFilterConstants; +import org.eclipse.rse.internal.core.filters.SystemFilterPool; import org.eclipse.rse.logging.Logger; -import org.eclipse.rse.persistence.IRSEPersistenceManager; - -// -// /** * A filter pool manager manages filter pools. @@ -190,10 +187,7 @@ public class SystemFilterPoolManager extends RSEPersistableObject implements ISy */ protected boolean singleFilterStringOnly = SINGLE_FILTER_STRING_ONLY_EDEFAULT; - /** - * @generated This field/method will be replaced during code generation. - */ - protected java.util.List pools = null; + protected List pools = null; /** * Constructor @@ -224,7 +218,7 @@ public class SystemFilterPoolManager extends RSEPersistableObject implements ISy * individual filter pool level. * @param savePolicy The save policy for the filter pools and filters. One of the * following constants from the - * {@link org.eclipse.rse.internal.core.filters.ISystemFilterConstants SystemFilterConstants} interface: + * {@link ISystemFilterConstants} interface: *