mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-16 12:45:41 +02:00
Code Issues Wiki Activity

Bug 567662: Eliminate pixel-level sizing on debugger page

Browse source 
Change-Id: If0f14b9ed8d6e6343888ba8acb3b4f432f15c5b5
This commit is contained in:
John Dallaway 2020-10-07 08:57:49 +01:00
parent 066bb7cd9a
commit 5bc332d14c
2 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
jtag/org.eclipse.cdt.debug.gdbjtag.ui/META-INF/MANIFEST.MF
View file

@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2 Bundle-ManifestVersion: 2
Bundle-Name: %pluginName Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.cdt.debug.gdbjtag.ui;singleton:=true Bundle-SymbolicName: org.eclipse.cdt.debug.gdbjtag.ui;singleton:=true
Bundle-Version: 9.0.0.qualifier Bundle-Version: 9.0.100.qualifier
Bundle-Activator: org.eclipse.cdt.debug.gdbjtag.ui.Activator Bundle-Activator: org.eclipse.cdt.debug.gdbjtag.ui.Activator
Bundle-Localization: plugin Bundle-Localization: plugin
Require-Bundle: org.eclipse.ui, Require-Bundle: org.eclipse.ui,

11
jtag/org.eclipse.cdt.debug.gdbjtag.ui/src/org/eclipse/cdt/debug/gdbjtag/ui/GDBJtagDSFDebuggerTab.java
View file

@ -22,6 +22,7 @@
* Torbjörn Svensson (STMicroelectronics) - Bug 535024 * Torbjörn Svensson (STMicroelectronics) - Bug 535024
* John Dallaway - Sort JTAG device list, bug 560186 * John Dallaway - Sort JTAG device list, bug 560186
* John Dallaway - Eliminate deprecated API, bug 566462 * John Dallaway - Eliminate deprecated API, bug 566462
* John Dallaway - Eliminate pixel-level sizing, bug 567662
*******************************************************************************/ *******************************************************************************/
package org.eclipse.cdt.debug.gdbjtag.ui; package org.eclipse.cdt.debug.gdbjtag.ui;
@ -50,6 +51,7 @@ import org.eclipse.debug.core.ILaunchConfigurationWorkingCopy;
import org.eclipse.debug.ui.AbstractLaunchConfigurationTab; import org.eclipse.debug.ui.AbstractLaunchConfigurationTab;
import org.eclipse.debug.ui.StringVariableSelectionDialog; import org.eclipse.debug.ui.StringVariableSelectionDialog;
import org.eclipse.jface.layout.GridDataFactory; import org.eclipse.jface.layout.GridDataFactory;
import org.eclipse.jface.layout.PixelConverter;
import org.eclipse.swt.SWT; import org.eclipse.swt.SWT;
import org.eclipse.swt.custom.ScrolledComposite; import org.eclipse.swt.custom.ScrolledComposite;
import org.eclipse.swt.custom.StackLayout; import org.eclipse.swt.custom.StackLayout;
@ -239,7 +241,7 @@ public class GDBJtagDSFDebuggerTab extends AbstractLaunchConfigurationTab {
}); });
remoteTimeoutValue = new Text(group, SWT.BORDER); remoteTimeoutValue = new Text(group, SWT.BORDER);
gd = new GridData(); gd = new GridData();
gd.widthHint = 125; gd.widthHint = new PixelConverter(remoteTimeoutValue).convertWidthInCharsToPixels(10);
remoteTimeoutValue.setLayoutData(gd); remoteTimeoutValue.setLayoutData(gd);
remoteTimeoutValue.setToolTipText(Messages.getString("GDBJtagDebuggerTab.remoteTimeoutTooltip")); //$NON-NLS-1$ remoteTimeoutValue.setToolTipText(Messages.getString("GDBJtagDebuggerTab.remoteTimeoutTooltip")); //$NON-NLS-1$
@ -247,7 +249,7 @@ public class GDBJtagDSFDebuggerTab extends AbstractLaunchConfigurationTab {
layout = new GridLayout(); layout = new GridLayout();
layout.numColumns = 2; layout.numColumns = 2;
comp.setLayout(layout); comp.setLayout(layout);
comp.setLayoutData(GridDataFactory.swtDefaults().span(2, 1).create()); comp.setLayoutData(GridDataFactory.swtDefaults().span(2, 1).grab(true, false).create());
Label label = new Label(comp, SWT.NONE); Label label = new Label(comp, SWT.NONE);
label.setText(Messages.getString("GDBJtagDebuggerTab.jtagDeviceLabel")); //$NON-NLS-1$ label.setText(Messages.getString("GDBJtagDebuggerTab.jtagDeviceLabel")); //$NON-NLS-1$
@ -270,7 +272,7 @@ public class GDBJtagDSFDebuggerTab extends AbstractLaunchConfigurationTab {
remoteConnectionParameters = new Composite(group, SWT.NO_TRIM | SWT.NO_FOCUS); remoteConnectionParameters = new Composite(group, SWT.NO_TRIM | SWT.NO_FOCUS);
remoteConnectParmsLayout = new StackLayout(); remoteConnectParmsLayout = new StackLayout();
remoteConnectionParameters.setLayout(remoteConnectParmsLayout); remoteConnectionParameters.setLayout(remoteConnectParmsLayout);
remoteConnectionParameters.setLayoutData(GridDataFactory.swtDefaults().span(2, 1).create()); remoteConnectionParameters.setLayoutData(GridDataFactory.fillDefaults().span(2, 1).create());
// //
// Create entry fields for other types of connections // Create entry fields for other types of connections
@ -286,8 +288,7 @@ public class GDBJtagDSFDebuggerTab extends AbstractLaunchConfigurationTab {
label = new Label(remoteConnectionBox, SWT.NONE); label = new Label(remoteConnectionBox, SWT.NONE);
label.setText(Messages.getString("GDBJtagDebuggerTab.connectionLabel")); //$NON-NLS-1$ label.setText(Messages.getString("GDBJtagDebuggerTab.connectionLabel")); //$NON-NLS-1$
connection = new Text(remoteConnectionBox, SWT.BORDER); connection = new Text(remoteConnectionBox, SWT.BORDER);
gd = new GridData(); gd = new GridData(GridData.FILL_HORIZONTAL | GridData.GRAB_HORIZONTAL);
gd.widthHint = 125;
connection.setLayoutData(gd); connection.setLayoutData(gd);
} }