mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-04 06:45:43 +02:00
Code Issues Wiki Activity

Bug 313622 Make checking for !a && b optional and off by default

Browse source
This commit is contained in:
Alena Laskavaia 2010-05-24 15:07:53 +00:00
parent c2919ed4f9
commit 5a6ecb2fb8
1 changed files with 19 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/SuggestedParenthesisChecker.java
View file

@ -21,7 +21,8 @@ import org.eclipse.cdt.core.dom.ast.IASTTranslationUnit;
import org.eclipse.cdt.core.dom.ast.IASTUnaryExpression; import org.eclipse.cdt.core.dom.ast.IASTUnaryExpression;
/** /**
* This checker finds a problems which are caused by lack of understanding operator * This checker finds a problems which are caused by lack of understanding
* operator
* precedence in C. In any case it is better to surround expressions in * precedence in C. In any case it is better to surround expressions in
* parenthesis to improve readability. Example: ! x>0 && x<10 (this would be * parenthesis to improve readability. Example: ! x>0 && x<10 (this would be
* (!x)>0 && x<10 in C) We only look for &&, || and ! operators (and binary | & * (!x)>0 && x<10 in C) We only look for &&, || and ! operators (and binary | &
@ -31,8 +32,10 @@ import org.eclipse.cdt.core.dom.ast.IASTUnaryExpression;
* *
*/ */
public class SuggestedParenthesisChecker extends AbstractIndexAstChecker { public class SuggestedParenthesisChecker extends AbstractIndexAstChecker {
private static final String ER_ID = "org.eclipse.cdt.codan.internal.checkers.SuggestedParenthesisProblem"; //$NON-NLS-1$ public static final String ER_ID = "org.eclipse.cdt.codan.internal.checkers.SuggestedParenthesisProblem"; //$NON-NLS-1$
private static final String PARAM_NOT = "paramNot"; public static final String PARAM_NOT = "paramNot"; //$NON-NLS-1$
public void processAst(IASTTranslationUnit ast) { public void processAst(IASTTranslationUnit ast) {
// traverse the ast using the visitor pattern. // traverse the ast using the visitor pattern.
@ -116,16 +119,23 @@ public class SuggestedParenthesisChecker extends AbstractIndexAstChecker {
} }
return false; return false;
} }
public boolean isParamNot(){
return (Boolean) getPreference(getProblemById(ER_ID, getFile()), PARAM_NOT); public boolean isParamNot() {
return (Boolean) getPreference(getProblemById(ER_ID, getFile()),
PARAM_NOT);
} }
/* (non-Javadoc)
* @see org.eclipse.cdt.codan.core.model.AbstractCheckerWithProblemPreferences#initPreferences(org.eclipse.cdt.codan.core.model.IProblemWorkingCopy) /*
* (non-Javadoc)
*
* @see
* org.eclipse.cdt.codan.core.model.AbstractCheckerWithProblemPreferences
* #initPreferences(org.eclipse.cdt.codan.core.model.IProblemWorkingCopy)
*/ */
@Override @Override
public void initPreferences(IProblemWorkingCopy problem) { public void initPreferences(IProblemWorkingCopy problem) {
super.initPreferences(problem); super.initPreferences(problem);
addPreference(problem, PARAM_NOT, "Suggest parentesis around not operator", Boolean.FALSE); addPreference(problem, PARAM_NOT,
"Suggest parentesis around not operator", Boolean.FALSE);
} }
} }