From 5940bb672f78347a42979900cfbf1989fefc7c02 Mon Sep 17 00:00:00 2001
From: Martin Oberhuber < martin.oberhuber@windriver.com>
Date: Thu, 6 Nov 2008 17:53:40 +0000
Subject: [PATCH] [cleanup] Add comments about new connection wizard test cases

---
 .../rse/tests/RSECombinedTestSuite.java       |  2 ++
 .../RSENewConnectionWizardTestCase.java       | 33 +++++++++++++------
 .../RSENewConnectionWizardTestSuite.java      | 19 ++++++-----
 3 files changed, 35 insertions(+), 19 deletions(-)

diff --git a/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/RSECombinedTestSuite.java b/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/RSECombinedTestSuite.java
index 480743f8297..cda93cb980e 100644
--- a/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/RSECombinedTestSuite.java
+++ b/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/RSECombinedTestSuite.java
@@ -58,6 +58,8 @@ public class RSECombinedTestSuite extends DelegatingTestSuiteHolder {
 		suite.addTest(org.eclipse.rse.tests.subsystems.testsubsystem.RSETestSubsystemTestSuite.suite());
 		suite.addTest(org.eclipse.rse.tests.ui.mnemonics.MnemonicsTestSuite.suite());
 		suite.addTest(org.eclipse.rse.tests.ui.preferences.PreferencesTestSuite.suite());
+		// //Manual test below -- cannot be run in unattended builds
+		// suite.addTest(org.eclipse.rse.tests.ui.connectionwizard.RSENewConnectionWizardTestSuite.suite());
 		return suite;
 	}
 
diff --git a/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/ui/connectionwizard/RSENewConnectionWizardTestCase.java b/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/ui/connectionwizard/RSENewConnectionWizardTestCase.java
index b0889668c6a..841e66df815 100644
--- a/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/ui/connectionwizard/RSENewConnectionWizardTestCase.java
+++ b/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/ui/connectionwizard/RSENewConnectionWizardTestCase.java
@@ -1,11 +1,11 @@
 /*******************************************************************************
  * Copyright (c) 2008 Wind River Systems, Inc. and others.
- * All rights reserved. This program and the accompanying materials 
- * are made available under the terms of the Eclipse Public License v1.0 
- * which accompanies this distribution, and is available at 
- * http://www.eclipse.org/legal/epl-v10.html 
- * 
- * Contributors: 
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
  * Uwe Stieber (Wind River) - initial API and implementation
  *******************************************************************************/
 package org.eclipse.rse.tests.ui.connectionwizard;
@@ -20,21 +20,34 @@ import org.eclipse.ui.PlatformUI;
 /**
  * Tests the RSE new connection wizard functionality.
  * 
+ * This is a manual test! Users need to manually make some selections and close
+ * the dialog for the test to complete. Therefore this test cannot be run in
+ * unattended nightly builds.
+ * 
+ * What testers should check:
+ * <ul>
+ * <li>On 1st wizard page, select a type and press next</li>
+ * <li>On 2nd page, selected type should be visible.</li>
+ * <li>Select type again on that page -- next should be enabled, press next</li>
+ * <li>Press back, select a different type, press next -- correct type should be
+ * shown</li> </li> For details, see
+ * https://bugs.eclipse.org/bugs/show_bug.cgi?id=237816
+ * 
  * @author uwe.stieber@windriver.com
  */
 public class RSENewConnectionWizardTestCase extends RSECoreTestCase {
-	
+
 	/* Test restrictToSystemType functionality. See bug 237816 */
 	public void testRestrictToSystemType() {
 		//-test-author-:UweStieber
 		if (!RSETestsPlugin.isTestCaseEnabled("RSENewConnectionWizardTestCase.testRestrictToSystemType")) return; //$NON-NLS-1$
-		
+
 		IRSECoreRegistry coreRegistry = RSECorePlugin.getTheCoreRegistry();
 		assertNotNull("Failed to fetch RSE core registry instance!", coreRegistry); //$NON-NLS-1$
-		
+
 		// Construct the wizard
 		RSENewConnectionWizardTestWizard wizard = new RSENewConnectionWizardTestWizard();
-		
+
 		WizardDialog dialog = new WizardDialog(PlatformUI.getWorkbench().getDisplay().getActiveShell(), wizard);
 		dialog.open();
 	}
diff --git a/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/ui/connectionwizard/RSENewConnectionWizardTestSuite.java b/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/ui/connectionwizard/RSENewConnectionWizardTestSuite.java
index 2110419dde2..59860ff15b8 100644
--- a/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/ui/connectionwizard/RSENewConnectionWizardTestSuite.java
+++ b/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/ui/connectionwizard/RSENewConnectionWizardTestSuite.java
@@ -1,11 +1,11 @@
 /*******************************************************************************
  * Copyright (c) 2008 Wind River Systems, Inc. and others.
- * All rights reserved. This program and the accompanying materials 
- * are made available under the terms of the Eclipse Public License v1.0 
- * which accompanies this distribution, and is available at 
- * http://www.eclipse.org/legal/epl-v10.html 
- * 
- * Contributors: 
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
  * Uwe Stieber (Wind River) - initial API and implementation.
  *******************************************************************************/
 package org.eclipse.rse.tests.ui.connectionwizard;
@@ -38,13 +38,14 @@ public class RSENewConnectionWizardTestSuite extends DelegatingTestSuiteHolder {
 	 * @return The test suite instance.
 	 */
 	public static Test suite() {
-		TestSuite suite = new TestSuite("RSE Registries Test Suite"); //$NON-NLS-1$
+		TestSuite suite = new TestSuite("RSE New Connection Wizard Test Suite"); //$NON-NLS-1$
 		// add the single test suites to the overall one here.
+		//Attention: MANUAL testcase below! Not for unattended nightly builds!
 		suite.addTestSuite(RSENewConnectionWizardTestCase.class);
-		
+
 		return suite;
 	}
-	
+
 	/* (non-Javadoc)
 	 * @see org.eclipse.rse.tests.framework.AbstractTestSuiteHolder#getTestSuite()
 	 */