mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-08 02:06:01 +02:00
Code Issues Wiki Activity

autotools: Remove redundant and unused modifiers.

Browse source 
Reducing sonar warnings is good strategy to keep new warnings easily
noticable. 
Interface methods/fields have strict modifiers so no need to specify it.

Change-Id: I8c453b5dbdc3c7fcc37e4e0a4fdf1c600e23fb1a
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
This commit is contained in:
Alexander Kurtakov 2015-10-26 21:43:23 +02:00 • committed by Gerrit Code Review @ Eclipse.org
parent a9730dc194
commit 59263ecc02
13 changed files with 130 additions and 101 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/IAutotoolsMarker.java
View file

@ -13,9 +13,9 @@ package org.eclipse.cdt.internal.autotools.core;
import org.eclipse.cdt.autotools.core.AutotoolsPlugin; import org.eclipse.cdt.autotools.core.AutotoolsPlugin;
public interface IAutotoolsMarker { public interface IAutotoolsMarker {
public static String AUTOTOOLS_PROBLEM_MARKER = AutotoolsPlugin.PLUGIN_ID + ".problem"; //$NON-NLS-1$ String AUTOTOOLS_PROBLEM_MARKER = AutotoolsPlugin.PLUGIN_ID + ".problem"; //$NON-NLS-1$
public static final String MARKER_VARIABLE = "problem.variable"; //$NON-NLS-1$ String MARKER_VARIABLE = "problem.variable"; //$NON-NLS-1$
public static final String MARKER_EXTERNAL_LOCATION = "problem.externalLocation"; //$NON-NLS-1$ String MARKER_EXTERNAL_LOCATION = "problem.externalLocation"; //$NON-NLS-1$
public static final String MARKER_LIBRARY_INFO="problem.libraryInfo"; //$NON-NLS-1$ String MARKER_LIBRARY_INFO = "problem.libraryInfo"; //$NON-NLS-1$
public static final String MARKER_PROBLEM_TYPE="problem.type"; //$NON-NLS-1$ String MARKER_PROBLEM_TYPE = "problem.type"; //$NON-NLS-1$
} }

2
build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/IConfigurationCloneListener.java
View file

@ -8,5 +8,5 @@ public interface IConfigurationCloneListener {
* @param cloneName - name of the cloned configuration * @param cloneName - name of the cloned configuration
* @param c - the clone * @param c - the clone
*/ */
public void cloneCfg(String cloneName, IConfiguration c); void cloneCfg(String cloneName, IConfiguration c);
} }

38
build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/configure/IAConfiguration.java
View file

@ -14,17 +14,29 @@ import java.util.ArrayList;
import java.util.Map; import java.util.Map;
public interface IAConfiguration { public interface IAConfiguration {
public IConfigureOption getOption(String name); IConfigureOption getOption(String name);
public String getId();
public boolean isDirty(); String getId();
public void setDirty(boolean value);
public Map<String, IConfigureOption> getOptions(); boolean isDirty();
public String getToolParameters(String name);
public ArrayList<String> getToolArgs(String name); void setDirty(boolean value);
public void setOption(String name, String value);
public void setConfigToolDirectory(String configToolDirectory); Map<String, IConfigureOption> getOptions();
public String getConfigToolDirectory();
public IAConfiguration copy(); String getToolParameters(String name);
public IAConfiguration copy(String id);
public void setDefaultOptions(); ArrayList<String> getToolArgs(String name);
void setOption(String name, String value);
void setConfigToolDirectory(String configToolDirectory);
String getConfigToolDirectory();
IAConfiguration copy();
IAConfiguration copy(String id);
void setDefaultOptions();
} }

58
build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/configure/IConfigureOption.java
View file

@ -16,26 +16,40 @@ import org.eclipse.cdt.autotools.core.IAutotoolsOption;
public interface IConfigureOption { public interface IConfigureOption {
public final static int CATEGORY = IAutotoolsOption.CATEGORY; int CATEGORY = IAutotoolsOption.CATEGORY;
public final static int BIN = IAutotoolsOption.BIN; int BIN = IAutotoolsOption.BIN;
public final static int STRING = IAutotoolsOption.STRING; int STRING = IAutotoolsOption.STRING;
public final static int INTERNAL = IAutotoolsOption.INTERNAL; int INTERNAL = IAutotoolsOption.INTERNAL;
public final static int MULTIARG = IAutotoolsOption.MULTIARG; int MULTIARG = IAutotoolsOption.MULTIARG;
public final static int TOOL = IAutotoolsOption.TOOL; int TOOL = IAutotoolsOption.TOOL;
public final static int FLAG = IAutotoolsOption.FLAG; int FLAG = IAutotoolsOption.FLAG;
public final static int FLAGVALUE = IAutotoolsOption.FLAGVALUE; int FLAGVALUE = IAutotoolsOption.FLAGVALUE;
public String getName();
public String getParameter(); String getName();
public ArrayList<String> getParameters();
public boolean isParmSet(); String getParameter();
public String getDescription();
public String getToolTip(); ArrayList<String> getParameters();
public void setValue(String value);
public IConfigureOption copy(AutotoolsConfiguration cfg); boolean isParmSet();
public String getValue();
public boolean isCategory(); String getDescription();
public boolean isMultiArg();
public boolean isFlag(); String getToolTip();
public boolean isFlagValue();
public int getType(); void setValue(String value);
IConfigureOption copy(AutotoolsConfiguration cfg);
String getValue();
boolean isCategory();
boolean isMultiArg();
boolean isFlag();
boolean isFlagValue();
int getType();
} }

2
build/org.eclipse.cdt.autotools.ui/src/org/eclipse/cdt/autotools/ui/editors/IAutotoolEditorActionDefinitionIds.java
View file

@ -13,5 +13,5 @@ package org.eclipse.cdt.autotools.ui.editors;
import org.eclipse.cdt.autotools.ui.AutotoolsUIPlugin; import org.eclipse.cdt.autotools.ui.AutotoolsUIPlugin;
public interface IAutotoolEditorActionDefinitionIds { public interface IAutotoolEditorActionDefinitionIds {
public static final String SHOW_TOOLTIP = AutotoolsUIPlugin.getUniqueIdentifier() + ".editors.text.show.tooltip"; //$NON-NLS-1$ String SHOW_TOOLTIP = AutotoolsUIPlugin.getUniqueIdentifier() + ".editors.text.show.tooltip"; //$NON-NLS-1$
} }

8
build/org.eclipse.cdt.autotools.ui/src/org/eclipse/cdt/autotools/ui/editors/IAutotoolHelpContextIds.java
View file

@ -13,8 +13,8 @@ package org.eclipse.cdt.autotools.ui.editors;
import org.eclipse.cdt.autotools.ui.AutotoolsUIPlugin; import org.eclipse.cdt.autotools.ui.AutotoolsUIPlugin;
public interface IAutotoolHelpContextIds { public interface IAutotoolHelpContextIds {
public static final String PREFIX = AutotoolsUIPlugin.getUniqueIdentifier(); String PREFIX = AutotoolsUIPlugin.getUniqueIdentifier();
public static final String AC_EDITOR_VIEW = PREFIX + "autoconf_editor"; //$NON-NLS-1$ String AC_EDITOR_VIEW = PREFIX + "autoconf_editor"; //$NON-NLS-1$
public static final String SHOW_TOOLTIP_ACTION = PREFIX + "show_tooltip_action"; //$NON-NLS-1$ String SHOW_TOOLTIP_ACTION = PREFIX + "show_tooltip_action"; //$NON-NLS-1$
public static final String CONTENT_ASSIST = PREFIX + "content_assist"; //$NON-NLS-1$ String CONTENT_ASSIST = PREFIX + "content_assist"; //$NON-NLS-1$
} }

2
build/org.eclipse.cdt.autotools.ui/src/org/eclipse/cdt/autotools/ui/editors/IAutotoolsEditor.java
View file

@ -12,5 +12,5 @@ public interface IAutotoolsEditor extends ITextEditor {
* *
* @param listener The reconcile listener to be added * @param listener The reconcile listener to be added
*/ */
public void addReconcilingParticipant(IReconcilingParticipant listener); void addReconcilingParticipant(IReconcilingParticipant listener);
} }

70
build/org.eclipse.cdt.autotools.ui/src/org/eclipse/cdt/autotools/ui/editors/parser/ITokenConstants.java
View file

@ -3,85 +3,85 @@ package org.eclipse.cdt.autotools.ui.editors.parser;
public interface ITokenConstants { public interface ITokenConstants {
/** end of file */ /** end of file */
public static final int EOF = 0; int EOF = 0;
/** end of line */ /** end of line */
public static final int EOL = 1; int EOL = 1;
/** an open parenthesis */ /** an open parenthesis */
public static final int LPAREN = 2; int LPAREN = 2;
/** a close parenthesis */ /** a close parenthesis */
public static final int RPAREN = 3; int RPAREN = 3;
/** a comma */ /** a comma */
public static final int COMMA = 4; int COMMA = 4;
/** a semicolon */ /** a semicolon */
public static final int SEMI = 5; int SEMI = 5;
/** a word (either m4 word or shell identifier-looking word) */ /** a word (either m4 word or shell identifier-looking word) */
public static final int WORD = 6; int WORD = 6;
/** other text (usually punctuation or number, one char at a time) */ /** other text (usually punctuation or number, one char at a time) */
public static final int TEXT = 7; int TEXT = 7;
/** an m4 string (the text does not contain the outermost quotes) */ /** an m4 string (the text does not contain the outermost quotes) */
public static final int M4_STRING = 21; int M4_STRING = 21;
/** an m4 comment (as determined by changecomment, NOT dnl) */ /** an m4 comment (as determined by changecomment, NOT dnl) */
public static final int M4_COMMENT = 22; int M4_COMMENT = 22;
/** the sh 'if' token */ /** the sh 'if' token */
public static final int SH_IF = 40; int SH_IF = 40;
/** the sh 'then' token */ /** the sh 'then' token */
public static final int SH_THEN = 41; int SH_THEN = 41;
/** the sh 'else' token */ /** the sh 'else' token */
public static final int SH_ELSE = 42; int SH_ELSE = 42;
/** the sh 'elif' token */ /** the sh 'elif' token */
public static final int SH_ELIF = 43; int SH_ELIF = 43;
/** the sh 'fi' token */ /** the sh 'fi' token */
public static final int SH_FI = 44; int SH_FI = 44;
/** the sh 'while' token */ /** the sh 'while' token */
public static final int SH_WHILE = 45; int SH_WHILE = 45;
/** the sh 'for' token */ /** the sh 'for' token */
public static final int SH_FOR = 46; int SH_FOR = 46;
/** the sh 'select' token */ /** the sh 'select' token */
public static final int SH_SELECT = 47; int SH_SELECT = 47;
/** the sh 'until' token */ /** the sh 'until' token */
public static final int SH_UNTIL = 48; int SH_UNTIL = 48;
/** the sh 'do' token */ /** the sh 'do' token */
public static final int SH_DO = 49; int SH_DO = 49;
/** the sh 'done' token */ /** the sh 'done' token */
public static final int SH_DONE = 50; int SH_DONE = 50;
/** the sh 'case' token */ /** the sh 'case' token */
public static final int SH_CASE = 51; int SH_CASE = 51;
/** the sh 'in' token */ /** the sh 'in' token */
public static final int SH_IN = 52; int SH_IN = 52;
/** the sh ';;' token */ /** the sh ';;' token */
public static final int SH_CASE_CONDITION_END = 53; int SH_CASE_CONDITION_END = 53;
/** the sh 'esac' token */ /** the sh 'esac' token */
public static final int SH_ESAC = 54; int SH_ESAC = 54;
/** the sh '$' token */ /** the sh '$' token */
public static final int SH_DOLLAR = 60; int SH_DOLLAR = 60;
/** the sh '{' token */ /** the sh '{' token */
public static final int SH_LBRACE = 61; int SH_LBRACE = 61;
/** the sh '}' token */ /** the sh '}' token */
public static final int SH_RBRACE = 62; int SH_RBRACE = 62;
/** the sh '[' token */ /** the sh '[' token */
public static final int SH_LBRACKET = 63; int SH_LBRACKET = 63;
/** the sh ']' token */ /** the sh ']' token */
public static final int SH_RBRACKET = 64; int SH_RBRACKET = 64;
/** the sh '<<' token */ /** the sh '<<' token */
public static final int SH_HERE = 65; int SH_HERE = 65;
/** the sh '<<-' token */ /** the sh '<<-' token */
public static final int SH_HERE_DASH = 66; int SH_HERE_DASH = 66;
/** an sh double-quoted string */ /** an sh double-quoted string */
public static final int SH_STRING_DOUBLE = 67; int SH_STRING_DOUBLE = 67;
/** an sh single-quoted string */ /** an sh single-quoted string */
public static final int SH_STRING_SINGLE = 68; int SH_STRING_SINGLE = 68;
/** an sh backtick-quoted string */ /** an sh backtick-quoted string */
public static final int SH_STRING_BACKTICK = 69; int SH_STRING_BACKTICK = 69;
} }

11
build/org.eclipse.cdt.autotools.ui/src/org/eclipse/cdt/internal/autotools/ui/editors/automake/IAutomakeConditional.java
View file

@ -12,8 +12,11 @@ package org.eclipse.cdt.internal.autotools.ui.editors.automake;
public interface IAutomakeConditional { public interface IAutomakeConditional {
public boolean isAutomake(); boolean isAutomake();
public void setAutomake(boolean value);
public Rule[] getRules(); void setAutomake(boolean value);
public void setRules(Rule[] rules);
Rule[] getRules();
void setRules(Rule[] rules);
} }

14
build/org.eclipse.cdt.autotools.ui/src/org/eclipse/cdt/internal/autotools/ui/editors/automake/ICommand.java
View file

@ -24,19 +24,19 @@ import java.io.IOException;
*/ */
public interface ICommand extends IDirective { public interface ICommand extends IDirective {
final public static char HYPHEN = '-'; char HYPHEN = '-';
final public static String HYPHEN_STRING = "-"; //$NON-NLS-1$ String HYPHEN_STRING = "-"; //$NON-NLS-1$
final public static char AT = '@'; char AT = '@';
final public static String AT_STRING = "@"; //$NON-NLS-1$ String AT_STRING = "@"; //$NON-NLS-1$
final public static char PLUS = '+'; char PLUS = '+';
final public static String PLUS_STRING = "+"; //$NON-NLS-1$ String PLUS_STRING = "+"; //$NON-NLS-1$
final public static char TAB = '\t'; char TAB = '\t';
/** /**
* - If the command prefix contains a hyphen, or the -i option is * - If the command prefix contains a hyphen, or the -i option is

4
build/org.eclipse.cdt.autotools.ui/src/org/eclipse/cdt/internal/autotools/ui/editors/automake/IComment.java
View file

@ -18,8 +18,8 @@ package org.eclipse.cdt.internal.autotools.ui.editors.automake;
*/ */
public interface IComment extends IDirective { public interface IComment extends IDirective {
final public static char POUND = '#'; char POUND = '#';
final public static String POUND_STRING = "#"; //$NON-NLS-1$ String POUND_STRING = "#"; //$NON-NLS-1$
} }

7
build/org.eclipse.cdt.autotools.ui/src/org/eclipse/cdt/internal/autotools/ui/editors/automake/IMakefileEditorActionDefinitionIds.java
View file

@ -16,10 +16,9 @@ package org.eclipse.cdt.internal.autotools.ui.editors.automake;
*/ */
public interface IMakefileEditorActionDefinitionIds { public interface IMakefileEditorActionDefinitionIds {
final String UNCOMMENT = "org.eclipse.cdt.make.ui.edit.text.makefile.uncomment"; //$NON-NLS-1$ String UNCOMMENT = "org.eclipse.cdt.make.ui.edit.text.makefile.uncomment"; //$NON-NLS-1$
String COMMENT = "org.eclipse.cdt.make.ui.edit.text.makefile.comment"; //$NON-NLS-1$
final String COMMENT = "org.eclipse.cdt.make.ui.edit.text.makefile.comment"; //$NON-NLS-1$ String OPEN_DECLARATION = "org.eclipse.cdt.make.ui.edit.text.makefile.opendcl"; //$NON-NLS-1$
final String OPEN_DECLARATION = "org.eclipse.cdt.make.ui.edit.text.makefile.opendcl"; //$NON-NLS-1$
} }

5
build/org.eclipse.cdt.autotools.ui/src/org/eclipse/cdt/internal/autotools/ui/editors/automake/IMakefileValidator.java
View file

@ -25,6 +25,7 @@ import org.eclipse.core.runtime.IProgressMonitor;
* @noimplement This interface is not intended to be implemented by clients. * @noimplement This interface is not intended to be implemented by clients.
*/ */
public interface IMakefileValidator { public interface IMakefileValidator {
public abstract void setMarkerGenerator(IMarkerGenerator errorHandler); void setMarkerGenerator(IMarkerGenerator errorHandler);
public abstract void checkFile(IFile file, IProgressMonitor monitor);
void checkFile(IFile file, IProgressMonitor monitor);
} }