mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-02 06:35:28 +02:00
Code Issues Wiki Activity

Bug 244567 makes the project optional. The bug I was attributing to the platform, was, as Pawel kindly pointed out, was actually part of our CMainTab class. I have fixed this.

Browse source
This commit is contained in:
Marc Khouzam 2008-08-21 14:02:54 +00:00
parent 5799b5a2a0
commit 587c7cb6cc
2 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
plugins/org.eclipse.dd.gdb.ui/src/org/eclipse/dd/gdb/internal/ui/launching/CMainTab.java
View file

@ -305,7 +305,10 @@ public class CMainTab extends CLaunchConfigurationTab {
}
}
} catch (CoreException e) { e.printStackTrace(); }
} else {
config.setMappedResources(null);
}
config.setAttribute(ICDTLaunchConfigurationConstants.ATTR_PROJECT_NAME, fProjText.getText());
config.setAttribute(ICDTLaunchConfigurationConstants.ATTR_PROGRAM_NAME, fProgText.getText());
if (fTerminalButton != null) {
@ -527,6 +530,9 @@ public class CMainTab extends CLaunchConfigurationTab {
setErrorMessage(null);
setMessage(null);
if (dontCheckProgram)
return true;
String name = fProjText.getText().trim();
if (name.length() == 0) {
setErrorMessage(LaunchMessages.getString("CMainTab.Project_not_specified")); //$NON-NLS-1$
@ -542,9 +548,6 @@ public class CMainTab extends CLaunchConfigurationTab {
return false;
}
if (dontCheckProgram)
return true;
name = fProgText.getText().trim();
if (name.length() == 0) {
setErrorMessage(LaunchMessages.getString("CMainTab.Program_not_specified")); //$NON-NLS-1$

6
plugins/org.eclipse.dd.gdb/src/org/eclipse/dd/gdb/internal/provisional/launching/GdbLaunchDelegate.java
View file

@ -112,12 +112,10 @@ public class GdbLaunchDelegate extends LaunchConfigurationDelegate
// An attach session also does not need to necessarily have a project
// specified. This is because we can perform source lookup towards
// code that is outside the workspace.
// However, the Platform does not support this, so for now, we check
// See bug 244567
// First verify we are dealing with a proper project.
ICProject project = LaunchUtils.verifyCProject(config);
if (!attach) {
// First verify we are dealing with a proper project.
ICProject project = LaunchUtils.verifyCProject(config);
// Now verify we know the program to debug.
exePath = LaunchUtils.verifyProgramPath(config, project);
// Finally, make sure the program is a proper binary.