Bug 568079: No need to check for NULL before free()

Change-Id: I4948ce07ed4ec426ce2a3bac226281409c25f7c9
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>

core/org.eclipse.cdt.core.native/native_src/unix/spawner.c

@@ -47,7 +47,7 @@ static void print_array(char **c_array) {
 static char** alloc_c_array(JNIEnv *env, jobjectArray j_array) {
 	int i;
 	jint c_array_size = (*env)->GetArrayLength(env, j_array);
-	char **c_array = calloc(c_array_size + 1, sizeof(*c_array));
+	char **c_array = calloc(c_array_size + 1, sizeof(char*));
 
 	if (c_array == NULL) {
 		return NULL;
@@ -67,9 +67,7 @@ static char** alloc_c_array(JNIEnv *env, jobjectArray j_array) {
 static void free_c_array(char **c_array) {
 	if (c_array) {
 		for (char **p = c_array; *p; p++) {
-			if (*p) {
+			free(*p);
-				free(*p);
-			}
 		}
 		free(c_array);
 	}
@@ -121,12 +119,8 @@ JNIEXPORT jint JNICALL Java_org_eclipse_cdt_utils_spawner_Spawner_exec2(JNIEnv *
 
 	bail_out: (*env)->ReleaseStringUTFChars(env, jdir, dirpath);
 	(*env)->ReleaseStringUTFChars(env, jslaveName, pts_name);
-	if (cmd) {
+	free_c_array(cmd);
-		free_c_array(cmd);
+	free_c_array(envp);
-	}
-	if (envp) {
-		free_c_array(envp);
-	}
 	return pid;
 }
 
@@ -162,12 +156,8 @@ Java_org_eclipse_cdt_utils_spawner_Spawner_exec1(JNIEnv *env, jobject jobj, jobj
 	}
 
 	bail_out: (*env)->ReleaseStringUTFChars(env, jdir, dirpath);
-	if (cmd) {
+	free_c_array(cmd);
-		free_c_array(cmd);
+	free_c_array(envp);
-	}
-	if (envp) {
-		free_c_array(envp);
-	}
 	return pid;
 }
 
@@ -224,12 +214,8 @@ Java_org_eclipse_cdt_utils_spawner_Spawner_exec0(JNIEnv *env, jobject jobj, jobj
 	}
 
 	bail_out: (*env)->ReleaseStringUTFChars(env, jdir, dirpath);
-	if (cmd) {
+	free_c_array(cmd);
-		free_c_array(cmd);
+	free_c_array(envp);
-	}
-	if (envp) {
-		free_c_array(envp);
-	}
 	return pid;
 }
 

core/org.eclipse.cdt.core.native/native_src/win/Win32ProcessEx.c

@@ -133,7 +133,7 @@ JNIEXPORT jint JNICALL Java_org_eclipse_cdt_utils_spawner_Spawner_exec0(JNIEnv *
 	PROCESS_INFORMATION pi = { 0 }, *piCopy;
 	STARTUPINFOW si;
 	DWORD flags = 0;
-	const wchar_t *cwd = NULL;
+	wchar_t *cwd = NULL;
 	LPVOID envBlk = NULL;
 	int ret = 0;
 	int nCmdLineLength = 0;
@@ -372,17 +372,9 @@ JNIEXPORT jint JNICALL Java_org_eclipse_cdt_utils_spawner_Spawner_exec0(JNIEnv *
 	&si, /* (in)  startup information */
 	&pi); /* (out) process information */
 
-	if (NULL != cwd) {
+	free(cwd);
-		free((void*) cwd);
+	free(szEnvBlock);
-	}
+	free(szCmdLine);
-
-	if (NULL != szEnvBlock) {
-		free(szEnvBlock);
-	}
-
-	if (NULL != szCmdLine) {
-		free(szCmdLine);
-	}
 
 	if (!ret) { // Launching error
 		char *lpMsgBuf;
@@ -572,15 +564,9 @@ JNIEXPORT jint JNICALL Java_org_eclipse_cdt_utils_spawner_Spawner_exec1(JNIEnv *
 	&si, /* (in)  startup information */
 	&pi); /* (out) process information */
 
-	if (NULL != cwd) {
+	free(cwd);
-		free(cwd);
+	free(szEnvBlock);
-	}
+	free(szCmdLine);
-	if (NULL != szEnvBlock) {
-		free(szEnvBlock);
-	}
-	if (NULL != szCmdLine) {
-		free(szCmdLine);
-	}
 
 	if (!ret) { // error
 		char *lpMsgBuf;

core/org.eclipse.cdt.core.native/native_src/win/starter.c

@@ -430,9 +430,7 @@ int main() {
 #endif
 	}
 
-	if (NULL != szCmdLine) {
+	free(szCmdLine);
-		free(szCmdLine);
-	}
 
 	CloseHandle(waitEvent);
 	CloseHandle(h[0]);
@@ -441,7 +439,7 @@ int main() {
 	CloseHandle(h[3]);
 	CloseHandle(h[4]);
 
-	return (dwExitCode);
+	return dwExitCode;
 }
 
 /////////////////////////////////////////////////////////////////////////////////////