diff --git a/build/org.eclipse.cdt.make.ui/plugin.xml b/build/org.eclipse.cdt.make.ui/plugin.xml index 604f6f26e62..25d04fc5613 100644 --- a/build/org.eclipse.cdt.make.ui/plugin.xml +++ b/build/org.eclipse.cdt.make.ui/plugin.xml @@ -461,7 +461,6 @@ helpId="cdt_u_prop_pns_sym" parent="org.eclipse.cdt.make.internal.ui.properties.PathAndSymbolPage" tooltip="%Symbols.tooltip"/> - 0); } diff --git a/build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/dataprovider/ConfigurationDataProvider.java b/build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/dataprovider/ConfigurationDataProvider.java index 28cfa4b60b1..6f08321f8c5 100644 --- a/build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/dataprovider/ConfigurationDataProvider.java +++ b/build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/dataprovider/ConfigurationDataProvider.java @@ -100,8 +100,8 @@ public class ConfigurationDataProvider extends CConfigurationDataProvider implem String bPath = b.getDefaultBuildPath(); b.setBuildPathAttribute(bPath); } -// cfg.setConfigurationDescription(des); -// ManagedBuildManager.performValueHandlerEvent(cfg, IManagedOptionValueHandler.EVENT_APPLY); + // cfg.setConfigurationDescription(des); + // ManagedBuildManager.performValueHandlerEvent(cfg, IManagedOptionValueHandler.EVENT_APPLY); cfg.serialize(cfgElemen); return appliedCfg; @@ -129,7 +129,7 @@ public class ConfigurationDataProvider extends CConfigurationDataProvider implem CConfigurationData base, IModificationContext context, IProgressMonitor monitor) - throws CoreException { + throws CoreException { if(cfgDescription.isPreferenceConfiguration()) return applyPreferences(cfgDescription, base); @@ -178,14 +178,14 @@ public class ConfigurationDataProvider extends CConfigurationDataProvider implem protected CConfigurationData createPreferences( ICConfigurationDescription cfgDescription, CConfigurationData base) - throws CoreException { + throws CoreException { Configuration cfg = (Configuration)((BuildConfigurationData)base).getConfiguration(); Configuration newCfg = new Configuration((ManagedProject)cfg.getManagedProject(), cfg, cfgDescription.getId(), true, true, true); newCfg.setConfigurationDescription(cfgDescription); newCfg.setName(cfgDescription.getName()); -// if(!newCfg.getId().equals(cfg.getId())){ -// newCfg.exportArtifactInfo(); -// } + // if(!newCfg.getId().equals(cfg.getId())){ + // newCfg.exportArtifactInfo(); + // } return newCfg.getConfigurationData(); } @@ -197,7 +197,7 @@ public class ConfigurationDataProvider extends CConfigurationDataProvider implem ICConfigurationDescription baseCfgDescription, CConfigurationData base, boolean clone, IProgressMonitor monitor) - throws CoreException { + throws CoreException { if(cfgDescription.isPreferenceConfiguration()) return createPreferences(cfgDescription, base); @@ -229,9 +229,9 @@ public class ConfigurationDataProvider extends CConfigurationDataProvider implem ManagedBuildManager.performValueHandlerEvent(newCfg, IManagedOptionValueHandler.EVENT_OPEN); -// if(!newCfg.getId().equals(cfg.getId())){ -// newCfg.exportArtifactInfo(); -// } + // if(!newCfg.getId().equals(cfg.getId())){ + // newCfg.exportArtifactInfo(); + // } return newCfg; } @@ -337,7 +337,7 @@ public class ConfigurationDataProvider extends CConfigurationDataProvider implem } protected CConfigurationData loadPreferences(ICConfigurationDescription cfgDescription) - throws CoreException { + throws CoreException { Configuration cfg = load(cfgDescription, null, true); @@ -554,12 +554,17 @@ public class ConfigurationDataProvider extends CConfigurationDataProvider implem } - public static void setDefaultLanguageSettingsProviders(IConfiguration cfg, ICConfigurationDescription cfgDescription) { - setDefaultLanguageSettingsProvidersIds(cfg, cfgDescription); - List providers = getDefaultLanguageSettingsProviders(cfg); - ((ILanguageSettingsProvidersKeeper) cfgDescription).setLanguageSettingProviders(providers); - } + public static void setDefaultLanguageSettingsProviders(IProject project, IConfiguration cfg, ICConfigurationDescription cfgDescription) { + // propagate the preference to project properties + boolean isPreferenceEnabled = ScannerDiscoveryLegacySupport.isLanguageSettingsProvidersFunctionalityEnabled(null); + ScannerDiscoveryLegacySupport.setLanguageSettingsProvidersFunctionalityEnabled(project, isPreferenceEnabled); + if (cfgDescription instanceof ILanguageSettingsProvidersKeeper) { + ConfigurationDataProvider.setDefaultLanguageSettingsProvidersIds(cfg, cfgDescription); + List providers = ConfigurationDataProvider.getDefaultLanguageSettingsProviders(cfg); + ((ILanguageSettingsProvidersKeeper) cfgDescription).setLanguageSettingProviders(providers); + } + } private boolean isPersistedCfg(ICConfigurationDescription cfgDescription){ return cfgDescription.getSessionProperty(CFG_PERSISTED_PROPERTY) != null; diff --git a/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/wizards/MBSWizardHandler.java b/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/wizards/MBSWizardHandler.java index 8d9a30b4959..8d204ec1f7f 100644 --- a/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/wizards/MBSWizardHandler.java +++ b/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/wizards/MBSWizardHandler.java @@ -23,16 +23,12 @@ import java.util.SortedMap; import java.util.TreeMap; import java.util.TreeSet; -import org.eclipse.cdt.core.language.settings.providers.ILanguageSettingsProvider; -import org.eclipse.cdt.core.language.settings.providers.ILanguageSettingsProvidersKeeper; -import org.eclipse.cdt.core.language.settings.providers.ScannerDiscoveryLegacySupport; import org.eclipse.cdt.core.model.CoreModel; import org.eclipse.cdt.core.settings.model.ICConfigurationDescription; import org.eclipse.cdt.core.settings.model.ICProjectDescription; import org.eclipse.cdt.core.settings.model.ICProjectDescriptionManager; import org.eclipse.cdt.core.settings.model.extension.CConfigurationData; import org.eclipse.cdt.core.templateengine.process.ProcessFailureException; -import org.eclipse.cdt.internal.ui.language.settings.providers.LanguageSettingsProvidersPage; import org.eclipse.cdt.internal.ui.wizards.ICDTCommonProjectWizard; import org.eclipse.cdt.managedbuilder.buildproperties.IBuildProperty; import org.eclipse.cdt.managedbuilder.buildproperties.IBuildPropertyValue; @@ -94,11 +90,11 @@ public class MBSWizardHandler extends CWizardHandler { private static final String PROP_VAL = PROPERTY + ".debug"; //$NON-NLS-1$ private static final String tooltip = - Messages.CWizardHandler_1 + - Messages.CWizardHandler_2 + - Messages.CWizardHandler_3 + - Messages.CWizardHandler_4 + - Messages.CWizardHandler_5; + Messages.CWizardHandler_1 + + Messages.CWizardHandler_2 + + Messages.CWizardHandler_3 + + Messages.CWizardHandler_4 + + Messages.CWizardHandler_5; protected SortedMap full_tcs = new TreeMap(); private String propertyId = null; @@ -108,7 +104,7 @@ public class MBSWizardHandler extends CWizardHandler { private IToolChain[] savedToolChains = null; private IWizard wizard; private IWizardPage startingPage; -// private EntryDescriptor entryDescriptor = null; + // private EntryDescriptor entryDescriptor = null; private EntryInfo entryInfo; protected CfgHolder[] cfgs = null; protected IWizardPage[] customPages; @@ -181,13 +177,13 @@ public class MBSWizardHandler extends CWizardHandler { List