mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-09 10:46:02 +02:00
Code Issues Wiki Activity

Fix stack overflow in canFlipToNextPage() and getNextPage()

Browse source
This commit is contained in:
Uwe Stieber 2010-04-07 08:13:55 +00:00
parent 24b41a5b04
commit 54ec5b51e6
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/newconnection/RSEDefaultNewConnectionWizardMainPage.java
View file

@ -1,5 +1,5 @@
/********************************************************************************
* Copyright (c) 2002, 2007 IBM Corporation and others. All rights reserved.
* Copyright (c) 2002, 2010 IBM Corporation and others. All rights reserved.
* This program and the accompanying materials are made available under the terms
* of the Eclipse Public License v1.0 which accompanies this distribution, and is
* available at http://www.eclipse.org/legal/epl-v10.html
@ -13,6 +13,7 @@
* Contributors:
* Uwe Stieber (Wind River) - Reworked new connection wizard extension point.
* Martin Oberhuber (Wind River) - [184095] Replace systemTypeName by IRSESystemType
* Uwe Stieber (Wind River) - Fix stack overflow in canFlipToNextPage() and getNextPage()
********************************************************************************/
package org.eclipse.rse.ui.wizards.newconnection;
@ -49,6 +50,13 @@ public class RSEDefaultNewConnectionWizardMainPage extends WizardPage implements
private SystemConnectionForm form;
private final RSEDialogPageMessageLine messageLine;
// Remember in getNextPage() if we called form.verify(...) already once.
// As the form is coming back to this page to invoke setPageComplete(boolean),
// form.verify(...) triggers an update of the wizard buttons, which in turn invoke
// canFlipToNextPage(...) which does call getNextPage(...). If the page is not used
// with a RSEDefaultNewConnectionWizard, this will end up in a StackOverflowError.
private boolean formVerificationGateKeeper = false;
/**
* Constructor. Use this when you want to supply your own title and
* description strings.
@ -138,7 +146,11 @@ public class RSEDefaultNewConnectionWizardMainPage extends WizardPage implements
// verify contents of page before going to main page
// this is done because the main page may have input that is not valid, but can
// only be verified when next is pressed since it requires a long running operation
if (!getSystemConnectionForm().verify(true)) return null;
if (!formVerificationGateKeeper) {
formVerificationGateKeeper = true;
if (!getSystemConnectionForm().verify(true)) return null;
formVerificationGateKeeper = false;
}
RSEDefaultNewConnectionWizard newConnWizard = getWizard() instanceof RSEDefaultNewConnectionWizard ? (RSEDefaultNewConnectionWizard)getWizard() : null;
if (newConnWizard != null) {