From 4f7831b525c085064f23026d101b2d7174d13e0f Mon Sep 17 00:00:00 2001 From: Ken Ryall Date: Thu, 4 Jun 2009 12:35:21 +0000 Subject: [PATCH] Bug 196885, cache the "is the exe a binary" value. --- .../src/org/eclipse/cdt/launch/ui/CMainTab.java | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/launch/org.eclipse.cdt.launch/src/org/eclipse/cdt/launch/ui/CMainTab.java b/launch/org.eclipse.cdt.launch/src/org/eclipse/cdt/launch/ui/CMainTab.java index b9dff1d42a5..82dec0564f0 100644 --- a/launch/org.eclipse.cdt.launch/src/org/eclipse/cdt/launch/ui/CMainTab.java +++ b/launch/org.eclipse.cdt.launch/src/org/eclipse/cdt/launch/ui/CMainTab.java @@ -13,8 +13,10 @@ package org.eclipse.cdt.launch.ui; import java.util.ArrayList; +import java.util.HashMap; import java.util.HashSet; import java.util.List; +import java.util.Map; import org.eclipse.cdt.core.CCorePlugin; import org.eclipse.cdt.core.ICDescriptor; @@ -128,6 +130,8 @@ public class CMainTab extends CLaunchConfigurationTab { /** @since 6.0 */ public static final int SPECIFY_CORE_FILE = 4; + private final Map fBinaryExeCache = new HashMap(); + public CMainTab() { this(WANTS_TERMINAL); @@ -790,8 +794,14 @@ public class CMainTab extends CLaunchConfigurationTab { */ protected boolean isBinary(IProject project, IPath exePath) throws CoreException { try { - IBinaryObject exe = LaunchUtils.getBinary(project, exePath); - return exe != null; + Boolean binValue = fBinaryExeCache.get(exePath); + if (binValue == null) + { + IBinaryObject exe = LaunchUtils.getBinary(project, exePath); + binValue = exe != null; + fBinaryExeCache.put(exePath, binValue); + } + return binValue; } catch (ClassCastException e) { } return false;