From 4c87198224c7094588a35e48abce2ac4d4ba696b Mon Sep 17 00:00:00 2001 From: Jonah Graham Date: Wed, 23 Feb 2022 14:38:57 -0500 Subject: [PATCH] Bug 573730: Turn on ConPTY as default PTY in Windows Change-Id: I27b2719c8fc5853792eba403fd5f5ca116dd7156 --- .../src/org/eclipse/cdt/utils/pty/PTY.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/core/org.eclipse.cdt.core.native/src/org/eclipse/cdt/utils/pty/PTY.java b/core/org.eclipse.cdt.core.native/src/org/eclipse/cdt/utils/pty/PTY.java index 4b0537edbb4..ad169aadd22 100644 --- a/core/org.eclipse.cdt.core.native/src/org/eclipse/cdt/utils/pty/PTY.java +++ b/core/org.eclipse.cdt.core.native/src/org/eclipse/cdt/utils/pty/PTY.java @@ -292,10 +292,10 @@ public class PTY { if (!isWindows) { isConPTY = IS_CONPTY.CONPTY_NO; } - // Force conpty off by default - // NOTE: to invert the default, the presence of the property must be checked too, not - // just the getBoolean return! - if (!Boolean.getBoolean("org.eclipse.cdt.core.conpty_enabled")) { //$NON-NLS-1$ + // Disable ConPTY if the user needs to + boolean conPtyEnabled = Boolean + .parseBoolean(System.getProperty("org.eclipse.cdt.core.conpty_enabled", "true")); //$NON-NLS-1$ //$NON-NLS-2$ + if (!conPtyEnabled) { isConPTY = IS_CONPTY.CONPTY_NO; }