mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-20 22:55:51 +02:00
Code Issues Wiki Activity

[234045] [ftp] Errors while changing file permissions are not displayed to the user

Browse source
This commit is contained in:
David McKnight 2008-07-09 19:14:09 +00:00
parent 3a247d06f7
commit 4c4214e61e
1 changed files with 61 additions and 58 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/internal/files/ui/propertypages/SystemFilePermissionsPropertyPage.java
View file

@ -13,6 +13,7 @@
* David McKnight (IBM) - [209703] apply encoding and updating remote file when apply on property page * David McKnight (IBM) - [209703] apply encoding and updating remote file when apply on property page
* Martin Oberhuber (Wind River) - [234038] Force refresh IRemoteFile after changing permissions * Martin Oberhuber (Wind River) - [234038] Force refresh IRemoteFile after changing permissions
* David McKnight (IBM) - [234038] [files][refresh] Changing file permissions does not update property sheet or refresh tree * David McKnight (IBM) - [234038] [files][refresh] Changing file permissions does not update property sheet or refresh tree
* David McKnight (IBM) - [234045] [ftp] Errors while changing file permissions are not displayed to the user
*********************************************************************************/ *********************************************************************************/
package org.eclipse.rse.internal.files.ui.propertypages; package org.eclipse.rse.internal.files.ui.propertypages;
@ -27,10 +28,12 @@ import org.eclipse.rse.core.events.ISystemResourceChangeEvents;
import org.eclipse.rse.core.events.SystemResourceChangeEvent; import org.eclipse.rse.core.events.SystemResourceChangeEvent;
import org.eclipse.rse.core.model.ISystemRegistry; import org.eclipse.rse.core.model.ISystemRegistry;
import org.eclipse.rse.internal.files.ui.FileResources; import org.eclipse.rse.internal.files.ui.FileResources;
import org.eclipse.rse.services.clientserver.messages.SystemMessageException;
import org.eclipse.rse.services.files.IFilePermissionsService; import org.eclipse.rse.services.files.IFilePermissionsService;
import org.eclipse.rse.services.files.IHostFilePermissions; import org.eclipse.rse.services.files.IHostFilePermissions;
import org.eclipse.rse.services.files.PendingHostFilePermissions; import org.eclipse.rse.services.files.PendingHostFilePermissions;
import org.eclipse.rse.subsystems.files.core.subsystems.IRemoteFile; import org.eclipse.rse.subsystems.files.core.subsystems.IRemoteFile;
import org.eclipse.rse.ui.SystemBasePlugin;
import org.eclipse.rse.ui.SystemWidgetHelpers; import org.eclipse.rse.ui.SystemWidgetHelpers;
import org.eclipse.rse.ui.propertypages.SystemBasePropertyPage; import org.eclipse.rse.ui.propertypages.SystemBasePropertyPage;
import org.eclipse.swt.SWT; import org.eclipse.swt.SWT;
@ -270,9 +273,6 @@ public class SystemFilePermissionsPropertyPage extends SystemBasePropertyPage {
} }
if ((capabilities & IFilePermissionsService.FS_CAN_GET_PERMISSIONS) != 0){ if ((capabilities & IFilePermissionsService.FS_CAN_GET_PERMISSIONS) != 0){
try
{
_permissions = file.getPermissions(); _permissions = file.getPermissions();
if (_permissions == null || _permissions instanceof PendingHostFilePermissions){ if (_permissions == null || _permissions instanceof PendingHostFilePermissions){
Job deferredFetch = new Job(FileResources.MESSAGE_GETTING_PERMISSIONS) Job deferredFetch = new Job(FileResources.MESSAGE_GETTING_PERMISSIONS)
@ -306,8 +306,9 @@ public class SystemFilePermissionsPropertyPage extends SystemBasePropertyPage {
} }
}); });
} }
catch (Exception e) catch (SystemMessageException e)
{ {
setMessage(e.getSystemMessage());
} }
return Status.OK_STATUS; return Status.OK_STATUS;
} }
@ -332,10 +333,6 @@ public class SystemFilePermissionsPropertyPage extends SystemBasePropertyPage {
_groupEntry.setText(_group); _groupEntry.setText(_group);
} }
} }
catch (Exception e){
}
}
else { else {
enablePermissionFields(false); enablePermissionFields(false);
enableOwnershipFields(false); enableOwnershipFields(false);
@ -415,8 +412,12 @@ public class SystemFilePermissionsPropertyPage extends SystemBasePropertyPage {
_permissions = newPermissions; _permissions = newPermissions;
} }
} }
catch (Exception e){ catch (SystemMessageException e){
setMessage(e.getSystemMessage());
}
catch (CloneNotSupportedException e){
// unexpected, not showing but logging
SystemBasePlugin.logError(e.getMessage());
} }
} }
} }
@ -458,7 +459,9 @@ public class SystemFilePermissionsPropertyPage extends SystemBasePropertyPage {
{ {
file = file.getParentRemoteFileSubSystem().getRemoteFileObject(file.getAbsolutePath(), new NullProgressMonitor()); file = file.getParentRemoteFileSubSystem().getRemoteFileObject(file.getAbsolutePath(), new NullProgressMonitor());
} }
catch (Exception e){ catch (SystemMessageException e){
// unexpected, logging but not showing user
SystemBasePlugin.logMessage(e.getSystemMessage());
} }
setElement((IAdaptable)file); setElement((IAdaptable)file);