From 434436e82f1daed262deb8bda72336c6c6734152 Mon Sep 17 00:00:00 2001 From: John Cortell Date: Mon, 11 Aug 2008 14:49:50 +0000 Subject: [PATCH] gdb session isn't getting cleaned up because of of my change to null out the ICDITarget reference after we dispose it. Reported by Mikhail. Will revisit. For now, just avoid nulling the reference. Restores previous behavior. --- .../eclipse/cdt/debug/internal/core/model/CDebugTarget.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/model/CDebugTarget.java b/debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/model/CDebugTarget.java index 4b8eb43c4cf..6611224ab32 100644 --- a/debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/model/CDebugTarget.java +++ b/debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/model/CDebugTarget.java @@ -1068,7 +1068,11 @@ public class CDebugTarget extends CDebugElement implements ICDebugTarget, ICDIEv disposePreferences(); ICDITarget cdiTarget = getCDITarget(); - setCDITarget(null); + // TODO: apparently we're not really done with the ICDITarget. The + // arrival of a terminate event from gdb requires access to this (see + // SessionManager.handleDebugEvent()). Reported by Mikhail. Need to + // revisit this. + // setCDITarget(null); if (cdiTarget instanceof ICDIDisposable) { ((ICDIDisposable)cdiTarget).dispose(); }