diff --git a/rse/plugins/org.eclipse.dstore.core/src/org/eclipse/dstore/core/miners/miner/Miner.java b/rse/plugins/org.eclipse.dstore.core/src/org/eclipse/dstore/core/miners/miner/Miner.java index eac5ff7c4af..92e5c07b028 100644 --- a/rse/plugins/org.eclipse.dstore.core/src/org/eclipse/dstore/core/miners/miner/Miner.java +++ b/rse/plugins/org.eclipse.dstore.core/src/org/eclipse/dstore/core/miners/miner/Miner.java @@ -567,7 +567,7 @@ implements ISchemaExtender */ public final String getCommandName(DataElement command) { - return (String) command.getAttribute(DE.A_NAME); + return command.getAttribute(DE.A_NAME); } /** diff --git a/rse/plugins/org.eclipse.dstore.core/src/org/eclipse/dstore/core/server/ServerCommandHandler.java b/rse/plugins/org.eclipse.dstore.core/src/org/eclipse/dstore/core/server/ServerCommandHandler.java index 9ad63c587ff..e30aa68e881 100644 --- a/rse/plugins/org.eclipse.dstore.core/src/org/eclipse/dstore/core/server/ServerCommandHandler.java +++ b/rse/plugins/org.eclipse.dstore.core/src/org/eclipse/dstore/core/server/ServerCommandHandler.java @@ -204,7 +204,7 @@ public class ServerCommandHandler extends CommandHandler if (commandName.equals(DataStoreSchema.C_VALIDATE_TICKET)) { DataElement serverTicket = _dataStore.getTicket(); - DataElement clientTicket = (DataElement) command.get(0); + DataElement clientTicket = command.get(0); String st = serverTicket.getName(); String ct = clientTicket.getName(); if (ct.equals(st)) @@ -230,19 +230,19 @@ public class ServerCommandHandler extends CommandHandler } else if (commandName.equals(DataStoreSchema.C_SET)) { - DataElement dataObject = (DataElement) command.get(0); + DataElement dataObject = command.get(0); status.setAttribute(DE.A_NAME,DataStoreResources.model_done); } else if (commandName.equals(DataStoreSchema.C_MODIFY)) { - DataElement dataObject = (DataElement) command.get(0); + DataElement dataObject = command.get(0); DataElement original = _dataStore.find(dataObject.getId()); original.setAttributes(dataObject.getAttributes()); status.setAttribute(DE.A_NAME,DataStoreResources.model_done); } else if (commandName.equals(DataStoreSchema.C_SET_HOST)) { - DataElement dataObject = (DataElement) command.get(0); + DataElement dataObject = command.get(0); DataElement original = _dataStore.getHostRoot(); original.setAttributes(dataObject.getAttributes()); @@ -253,13 +253,13 @@ public class ServerCommandHandler extends CommandHandler } else if (commandName.equals(DataStoreSchema.C_ADD_MINERS)) { - DataElement location = (DataElement) command.get(1); + DataElement location = command.get(1); _dataStore.addMinersLocation(location); status.setAttribute(DE.A_NAME,DataStoreResources.model_done); } else if (commandName.equals(DataStoreSchema.C_ACTIVATE_MINER)) { - DataElement minerId = (DataElement) command.get(0); + DataElement minerId = command.get(0); String minerName = minerId.getName(); Miner miner = loadMiner(minerName); miner.initMiner(status); @@ -268,7 +268,7 @@ public class ServerCommandHandler extends CommandHandler } else if (commandName.equals(DataStoreSchema.C_SET_PREFERENCE)) { - DataElement dataObject = (DataElement) command.get(0); + DataElement dataObject = command.get(0); String property = dataObject.getName(); String value = dataObject.getValue(); _dataStore.setPreference(property, value); diff --git a/rse/plugins/org.eclipse.dstore.core/src/org/eclipse/dstore/core/server/ServerReceiver.java b/rse/plugins/org.eclipse.dstore.core/src/org/eclipse/dstore/core/server/ServerReceiver.java index b0b57cb8ebf..0cae6440f37 100644 --- a/rse/plugins/org.eclipse.dstore.core/src/org/eclipse/dstore/core/server/ServerReceiver.java +++ b/rse/plugins/org.eclipse.dstore.core/src/org/eclipse/dstore/core/server/ServerReceiver.java @@ -54,7 +54,7 @@ public class ServerReceiver extends Receiver // parse request and determine what is wanted for (int a = 0; a < documentObject.getNestedSize(); a++) { - DataElement rootOutput = (DataElement) documentObject.get(a); + DataElement rootOutput = documentObject.get(a); DataElement log = _dataStore.getLogRoot(); log.addNestedData(rootOutput, false); diff --git a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemAddToArchiveAction.java b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemAddToArchiveAction.java index c8fff27b39f..3899d91e8ec 100644 --- a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemAddToArchiveAction.java +++ b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemAddToArchiveAction.java @@ -90,8 +90,6 @@ public class SystemAddToArchiveAction extends SystemBaseAction String[] relativePaths = getRelativePaths(); AddToArchiveDialog dialog = new AddToArchiveDialog(getShell(), title, relativePaths); - if (dialog == null) - return; dialog.setNeedsProgressMonitor(false); dialog.setMessage(FileResources.RESID_ADDTOARCHIVE_PROMPT); @@ -299,7 +297,7 @@ public class SystemAddToArchiveAction extends SystemBaseAction _selected.clear(); boolean enable = false; - Iterator e = ((IStructuredSelection) selection).iterator(); + Iterator e = selection.iterator(); while (e.hasNext()) { Object selected = e.next(); diff --git a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemCompareFilesAction.java b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemCompareFilesAction.java index a7d6acdf2ca..9abd49776aa 100644 --- a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemCompareFilesAction.java +++ b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemCompareFilesAction.java @@ -85,7 +85,7 @@ public class SystemCompareFilesAction extends SystemBaseAction _selected.clear(); boolean enable = false; - Iterator e = ((IStructuredSelection) selection).iterator(); + Iterator e = selection.iterator(); while (e.hasNext()) { Object selected = e.next(); diff --git a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemEditionAction.java b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemEditionAction.java index f87980c60e3..ba9e05e8cd3 100644 --- a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemEditionAction.java +++ b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemEditionAction.java @@ -130,7 +130,7 @@ public class SystemEditionAction extends SystemBaseAction { boolean enable = false; _selected.clear(); - Iterator e = ((IStructuredSelection) selection).iterator(); + Iterator e = selection.iterator(); if (e.hasNext()) { Object selected = e.next(); diff --git a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemExtractAction.java b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemExtractAction.java index 05616435d78..db567731d27 100644 --- a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemExtractAction.java +++ b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/actions/SystemExtractAction.java @@ -193,7 +193,7 @@ public class SystemExtractAction extends SystemBaseAction _selected.clear(); boolean enable = false; - Iterator e = ((IStructuredSelection) selection).iterator(); + Iterator e = selection.iterator(); while (e.hasNext()) { Object selected = e.next(); diff --git a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/propertypages/UniversalPreferencePage.java b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/propertypages/UniversalPreferencePage.java index 6eda371f262..06d0bfc8d55 100644 --- a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/propertypages/UniversalPreferencePage.java +++ b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/propertypages/UniversalPreferencePage.java @@ -130,8 +130,8 @@ public class UniversalPreferencePage protected void createFieldEditors() { - modeRegistry = (SystemFileTransferModeRegistry)(SystemFileTransferModeRegistry.getDefault()); - editorRegistry = (IEditorRegistry)(PlatformUI.getWorkbench().getEditorRegistry()); + modeRegistry = SystemFileTransferModeRegistry.getDefault(); + editorRegistry = PlatformUI.getWorkbench().getEditorRegistry(); modeMappings = new ArrayList(); editorMappings = new ArrayList(); diff --git a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/widgets/SystemQualifiedRemoteFolderCombo.java b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/widgets/SystemQualifiedRemoteFolderCombo.java index 40f2857b584..3f6ed59e44c 100644 --- a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/widgets/SystemQualifiedRemoteFolderCombo.java +++ b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/widgets/SystemQualifiedRemoteFolderCombo.java @@ -733,7 +733,7 @@ public class SystemQualifiedRemoteFolderCombo extends Composite browseAction.run(); - IRemoteFile folder = ((SystemSelectRemoteFolderAction)browseAction).getSelectedFolder(); + IRemoteFile folder = browseAction.getSelectedFolder(); if (folder != null) setFolder(folder); }; diff --git a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/widgets/SystemRemoteFolderCombo.java b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/widgets/SystemRemoteFolderCombo.java index 03b368f0f8a..e36e9f8e7d6 100644 --- a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/widgets/SystemRemoteFolderCombo.java +++ b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/widgets/SystemRemoteFolderCombo.java @@ -523,7 +523,7 @@ public class SystemRemoteFolderCombo extends Composite implements ISystemCombo } browseAction.run(); - IRemoteFile folder = ((SystemSelectRemoteFolderAction)browseAction).getSelectedFolder(); + IRemoteFile folder = browseAction.getSelectedFolder(); if (folder != null) setText(folder.getAbsolutePath()); diff --git a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/widgets/SystemSelectRemoteFileOrFolderForm.java b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/widgets/SystemSelectRemoteFileOrFolderForm.java index 005e6491bb8..b04ad7f936e 100644 --- a/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/widgets/SystemSelectRemoteFileOrFolderForm.java +++ b/rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/files/ui/widgets/SystemSelectRemoteFileOrFolderForm.java @@ -699,7 +699,7 @@ public class SystemSelectRemoteFileOrFolderForm } // MESSAGE/VERBAGE TEXT AT TOP - verbageLabel = (Label) SystemWidgetHelpers.createVerbiage(composite_prompts, verbage, gridColumns, false, PROMPT_WIDTH); + verbageLabel = SystemWidgetHelpers.createVerbiage(composite_prompts, verbage, gridColumns, false, PROMPT_WIDTH); //verbageLabel = SystemWidgetHelpers.createLabel(composite_prompts, verbage, gridColumns); // SPACER LINE diff --git a/rse/plugins/org.eclipse.rse.processes.ui/src/org/eclipse/rse/processes/ui/dialogs/SystemKillDialog.java b/rse/plugins/org.eclipse.rse.processes.ui/src/org/eclipse/rse/processes/ui/dialogs/SystemKillDialog.java index 6c7c0a5587f..432f2375abf 100644 --- a/rse/plugins/org.eclipse.rse.processes.ui/src/org/eclipse/rse/processes/ui/dialogs/SystemKillDialog.java +++ b/rse/plugins/org.eclipse.rse.processes.ui/src/org/eclipse/rse/processes/ui/dialogs/SystemKillDialog.java @@ -144,7 +144,7 @@ public class SystemKillDialog extends SystemPromptDialog } } else { - prompt = (Label)SystemWidgetHelpers.createVerbiage(composite, promptLabel, nbrColumns, false, 200); + prompt = SystemWidgetHelpers.createVerbiage(composite, promptLabel, nbrColumns, false, 200); } // WARNING diff --git a/rse/plugins/org.eclipse.rse.services.dstore/miners/org/eclipse/rse/dstore/universal/miners/command/CommandMiner.java b/rse/plugins/org.eclipse.rse.services.dstore/miners/org/eclipse/rse/dstore/universal/miners/command/CommandMiner.java index 94c3e9b7163..0080a1a5b2c 100644 --- a/rse/plugins/org.eclipse.rse.services.dstore/miners/org/eclipse/rse/dstore/universal/miners/command/CommandMiner.java +++ b/rse/plugins/org.eclipse.rse.services.dstore/miners/org/eclipse/rse/dstore/universal/miners/command/CommandMiner.java @@ -198,7 +198,7 @@ public class CommandMiner extends Miner } else if (name.equals("C_CANCEL")) { - DataElement de = (DataElement) subject.dereference().get(1); + DataElement de = subject.dereference().get(1); DataElement cancelStatus = getCommandStatus(subject); cancelCommand(de.getName().trim(), cancelStatus); return status; diff --git a/rse/plugins/org.eclipse.rse.services.dstore/src/org/eclipse/rse/services/dstore/files/DStoreFileService.java b/rse/plugins/org.eclipse.rse.services.dstore/src/org/eclipse/rse/services/dstore/files/DStoreFileService.java index a50c03bbdc9..18af93b5f81 100644 --- a/rse/plugins/org.eclipse.rse.services.dstore/src/org/eclipse/rse/services/dstore/files/DStoreFileService.java +++ b/rse/plugins/org.eclipse.rse.services.dstore/src/org/eclipse/rse/services/dstore/files/DStoreFileService.java @@ -622,7 +622,7 @@ public class DStoreFileService extends AbstractDStoreService implements IFileSer } try { - DownloadListener dlistener = new DownloadListener(monitor, status, localFile, remotePath, (long) fileLength); + DownloadListener dlistener = new DownloadListener(monitor, status, localFile, remotePath, fileLength); try { dlistener.waitForUpdate(); diff --git a/rse/plugins/org.eclipse.rse.services.local/src/org/eclipse/rse/services/local/search/LocalSearchHandler.java b/rse/plugins/org.eclipse.rse.services.local/src/org/eclipse/rse/services/local/search/LocalSearchHandler.java index 786514b1a8b..6de584f1205 100644 --- a/rse/plugins/org.eclipse.rse.services.local/src/org/eclipse/rse/services/local/search/LocalSearchHandler.java +++ b/rse/plugins/org.eclipse.rse.services.local/src/org/eclipse/rse/services/local/search/LocalSearchHandler.java @@ -96,7 +96,7 @@ public class LocalSearchHandler implements ISearchHandler // if the remote file is not virtual, then simply get the file if (!(_theRmtFile instanceof LocalVirtualHostFile)) { - _theFile = (File) (_theRmtFile.getFile()); + _theFile = _theRmtFile.getFile(); } // for virtual file, fake it with a non-existent file representing the // actual path (note this file won't actually exist on the filesystem) diff --git a/rse/plugins/org.eclipse.rse.services/clientserver/org/eclipse/rse/services/clientserver/util/tar/TarFile.java b/rse/plugins/org.eclipse.rse.services/clientserver/org/eclipse/rse/services/clientserver/util/tar/TarFile.java index efc0e14bf7d..d8a5e2f4910 100644 --- a/rse/plugins/org.eclipse.rse.services/clientserver/org/eclipse/rse/services/clientserver/util/tar/TarFile.java +++ b/rse/plugins/org.eclipse.rse.services/clientserver/org/eclipse/rse/services/clientserver/util/tar/TarFile.java @@ -158,7 +158,7 @@ public class TarFile implements ITarConstants { // determine how many blocks make up the contents of the file long fileSize = header.getSize(); int numFileBlocks = (int)(fileSize / BLOCK_SIZE); - numFileBlocks += (int)((fileSize % BLOCK_SIZE) > 0 ? 1 : 0); + numFileBlocks += (fileSize % BLOCK_SIZE) > 0 ? 1 : 0; // if the file is a symbolic link, number of blocks will be 0 if (header.getTypeFlag() == ITarConstants.TF_SYMLINK) { @@ -306,7 +306,7 @@ public class TarFile implements ITarConstants { // determine how many blocks make up the contents of the file int numFileBlocks = (int)(fileSize / BLOCK_SIZE); - numFileBlocks += (int)((fileSize % BLOCK_SIZE) > 0 ? 1 : 0); + numFileBlocks += (fileSize % BLOCK_SIZE) > 0 ? 1 : 0; // if the file is a symbolic link, number of blocks will be 0 if (header.getTypeFlag() == ITarConstants.TF_SYMLINK) { diff --git a/rse/plugins/org.eclipse.rse.shells.ui/src/org/eclipse/rse/shells/ui/view/SystemCommandsViewPart.java b/rse/plugins/org.eclipse.rse.shells.ui/src/org/eclipse/rse/shells/ui/view/SystemCommandsViewPart.java index 807b660f324..d0c08d52b1e 100644 --- a/rse/plugins/org.eclipse.rse.shells.ui/src/org/eclipse/rse/shells/ui/view/SystemCommandsViewPart.java +++ b/rse/plugins/org.eclipse.rse.shells.ui/src/org/eclipse/rse/shells/ui/view/SystemCommandsViewPart.java @@ -716,7 +716,7 @@ public class SystemCommandsViewPart if (source instanceof IRemoteCommandShell) { updateOutput((IRemoteCommandShell) source, false); - _folder.remove((IRemoteCommandShell)source); + _folder.remove(source); updateActionStates(); } } diff --git a/rse/plugins/org.eclipse.rse.subsystems.files.dstore/src/org/eclipse/rse/subsystems/files/dstore/old/SearchResultsChangeListener.java b/rse/plugins/org.eclipse.rse.subsystems.files.dstore/src/org/eclipse/rse/subsystems/files/dstore/old/SearchResultsChangeListener.java index eaf3ca64c17..29a5f6668b1 100644 --- a/rse/plugins/org.eclipse.rse.subsystems.files.dstore/src/org/eclipse/rse/subsystems/files/dstore/old/SearchResultsChangeListener.java +++ b/rse/plugins/org.eclipse.rse.subsystems.files.dstore/src/org/eclipse/rse/subsystems/files/dstore/old/SearchResultsChangeListener.java @@ -244,7 +244,7 @@ public class SearchResultsChangeListener implements IDomainListener, ICommunicat String remotePath = parentPath + slash + result.getName(); if (_subsys instanceof FileServiceSubSystem) { - remoteFile = (IRemoteFile)((FileServiceSubSystem)_subsys).getCachedRemoteFile(remotePath); + remoteFile = ((FileServiceSubSystem)_subsys).getCachedRemoteFile(remotePath); } if (remoteFile == null) diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemBaseAction.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemBaseAction.java index 7bc7189f206..07048346451 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemBaseAction.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemBaseAction.java @@ -529,7 +529,7 @@ public class SystemBaseAction extends Action implements ISystemAction public boolean updateSelection(IStructuredSelection selection) { boolean enable = true; - Iterator e= ((IStructuredSelection) selection).iterator(); + Iterator e= selection.iterator(); while (enable && e.hasNext()) { enable = checkObjectType(e.next()); diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemCollapseAction.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemCollapseAction.java index 92d057a067b..5efedf81a32 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemCollapseAction.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemCollapseAction.java @@ -66,7 +66,7 @@ public class SystemCollapseAction extends SystemBaseAction { return ((ISystemTree)viewer).areAnySelectedItemsExpanded(); } - Iterator e= ((IStructuredSelection) selection).iterator(); + Iterator e = selection.iterator(); ISystemViewElementAdapter adapter = null; while (!enable && e.hasNext()) { diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemExpandAction.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemExpandAction.java index 56355c4d5ee..6b032b05654 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemExpandAction.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemExpandAction.java @@ -66,7 +66,7 @@ public class SystemExpandAction extends SystemBaseAction { return ((ISystemTree)viewer).areAnySelectedItemsExpandable(); } - Iterator e= ((IStructuredSelection) selection).iterator(); + Iterator e = selection.iterator(); ISystemViewElementAdapter adapter = null; while (!enable && e.hasNext()) { diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemMoveDownConnectionAction.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemMoveDownConnectionAction.java index 8836d0c02d0..ac72d8e87fb 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemMoveDownConnectionAction.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemMoveDownConnectionAction.java @@ -63,7 +63,7 @@ public class SystemMoveDownConnectionAction extends SystemBaseAction boolean enable = true; ISystemRegistry sr = RSEUIPlugin.getDefault().getSystemRegistry(); prevProfile = null; - Iterator e= ((IStructuredSelection) selection).iterator(); + Iterator e = selection.iterator(); while (enable && e.hasNext()) { Object selectedObject = e.next(); diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemMoveUpConnectionAction.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemMoveUpConnectionAction.java index e33055f2609..e027456fa71 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemMoveUpConnectionAction.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemMoveUpConnectionAction.java @@ -63,7 +63,7 @@ public class SystemMoveUpConnectionAction extends SystemBaseAction boolean enable = true; ISystemRegistry sr = RSEUIPlugin.getDefault().getSystemRegistry(); prevProfile = null; - Iterator e= ((IStructuredSelection) selection).iterator(); + Iterator e = selection.iterator(); while (enable && e.hasNext()) { Object selectedObject = e.next(); diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemShowInMonitorAction.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemShowInMonitorAction.java index feb1cf73a9a..15c80ad13da 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemShowInMonitorAction.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemShowInMonitorAction.java @@ -85,7 +85,7 @@ public class SystemShowInMonitorAction extends SystemBaseAction public boolean updateSelection(IStructuredSelection selection) { boolean enable = false; - Iterator e = ((IStructuredSelection) selection).iterator(); + Iterator e = selection.iterator(); Object selected = e.next(); if (selected != null && selected instanceof IAdaptable) diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemShowInTableAction.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemShowInTableAction.java index 84d1afb7b30..bc42bfe55bf 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemShowInTableAction.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemShowInTableAction.java @@ -84,7 +84,7 @@ public class SystemShowInTableAction extends SystemBaseAction public boolean updateSelection(IStructuredSelection selection) { boolean enable = false; - Iterator e = ((IStructuredSelection) selection).iterator(); + Iterator e = selection.iterator(); Object selected = e.next(); if (selected != null && selected instanceof IAdaptable) diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemDeleteDialog.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemDeleteDialog.java index 5bdf9600829..034943bc245 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemDeleteDialog.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemDeleteDialog.java @@ -162,7 +162,7 @@ public class SystemDeleteDialog extends SystemPromptDialog } } else { - prompt = (Label)SystemWidgetHelpers.createVerbiage(composite, promptLabel, nbrColumns, false, 200); + prompt = SystemWidgetHelpers.createVerbiage(composite, promptLabel, nbrColumns, false, 200); } // WARNING diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemSimpleSelectDialog.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemSimpleSelectDialog.java index 23529bfa066..868a88bd710 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemSimpleSelectDialog.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemSimpleSelectDialog.java @@ -265,7 +265,7 @@ public class SystemSimpleSelectDialog extends SystemPromptDialog { for (int idx=0; idx0) { diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/monitor/MonitorViewWorkbook.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/monitor/MonitorViewWorkbook.java index b06e472b454..5c442a07749 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/monitor/MonitorViewWorkbook.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/monitor/MonitorViewWorkbook.java @@ -208,7 +208,7 @@ public class MonitorViewWorkbook extends Composite if (createTab) { // never shown this, so add it - createTabItem((IAdaptable) root); + createTabItem(root); } } } diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/scratchpad/SystemScratchpadView.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/scratchpad/SystemScratchpadView.java index 8b772d557de..d3f0215200d 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/scratchpad/SystemScratchpadView.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/scratchpad/SystemScratchpadView.java @@ -290,7 +290,7 @@ implements IMenuListener, ISystemDeleteTarget, ISystemRenameTarget, ISystemSelec int ops = DND.DROP_COPY | DND.DROP_MOVE; Transfer[] transfers = new Transfer[] { PluginTransfer.getInstance(), TextTransfer.getInstance(), EditorInputTransfer.getInstance(), FileTransfer.getInstance()}; - addDragSupport(ops, transfers, new SystemViewDataDragAdapter((ISelectionProvider) this)); + addDragSupport(ops, transfers, new SystemViewDataDragAdapter(this)); addDropSupport(ops | DND.DROP_DEFAULT, transfers, new SystemViewDataDropAdapter(this)); } @@ -1028,7 +1028,7 @@ implements IMenuListener, ISystemDeleteTarget, ISystemRenameTarget, ISystemSelec Tree tree = getTree(); - Tree theTree = (Tree) tree; + Tree theTree = tree; theTree.setSelection(theTree.getItems()); TreeItem[] items = theTree.getItems(); Object[] objects = new Object[items.length]; diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/search/SystemSearchViewPart.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/search/SystemSearchViewPart.java index d4fa60ef751..39c23cb7f71 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/search/SystemSearchViewPart.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/search/SystemSearchViewPart.java @@ -371,7 +371,7 @@ public class SystemSearchViewPart extends ViewPart implements ISystemResourceCha return false; } - ISystemViewElementAdapter adapter = (ISystemViewElementAdapter)getAdapter(input); + ISystemViewElementAdapter adapter = getAdapter(input); if (adapter == null) { return false; @@ -537,7 +537,7 @@ public class SystemSearchViewPart extends ViewPart implements ISystemResourceCha // TODO change to tabletree when eclipse fixes the swt widget //TableTree table = new TableTree(pageBook, SWT.H_SCROLL | SWT.V_SCROLL | SWT.MULTI | SWT.BORDER | SWT.FULL_SELECTION | SWT.HIDE_SELECTION); Tree tabletree = new Tree(pageBook, SWT.H_SCROLL | SWT.V_SCROLL | SWT.MULTI | SWT.BORDER | SWT.FULL_SELECTION | SWT.HIDE_SELECTION); - SystemSearchTableView viewer = new SystemSearchTableView(tabletree, (IHostSearchResultSet)resultSet, this); + SystemSearchTableView viewer = new SystemSearchTableView(tabletree, resultSet, this); viewer.setWorkbenchPart(this); getSite().registerContextMenu(viewer.getContextMenuManager(), viewer); diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamViewLabelProvider.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamViewLabelProvider.java index fcd392973e5..130bfdeafc8 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamViewLabelProvider.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamViewLabelProvider.java @@ -84,7 +84,7 @@ public class SystemTeamViewLabelProvider extends LabelProvider // If we have a project, return the resource project images. else if (element instanceof IProject) { - Image projectImage = aWorkbenchLabelProvider.getImage((IProject)element); + Image projectImage = aWorkbenchLabelProvider.getImage(element); return projectImage; } diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamViewPart.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamViewPart.java index bb770a942e2..ba3da83f040 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamViewPart.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/team/SystemTeamViewPart.java @@ -310,7 +310,7 @@ public class SystemTeamViewPart { menuListenerAdded = true; SystemViewMenuListener ml = new SystemViewMenuListener(); - ml.setShowToolTipText(true, (ISystemMessageLine)this); + ml.setShowToolTipText(true, this); m.addMenuListener(ml); } } @@ -996,7 +996,7 @@ public class SystemTeamViewPart public boolean canDelete() { boolean ok = true; - IStructuredSelection selection= (IStructuredSelection)getStructuredSelection(); + IStructuredSelection selection= getStructuredSelection(); Iterator elements= selection.iterator(); ISystemProfileManager mgr = RSEUIPlugin.getTheSystemRegistry().getSystemProfileManager(); int nbrActiveProfiles = mgr.getActiveSystemProfiles().length; @@ -1023,7 +1023,7 @@ public class SystemTeamViewPart public boolean doDelete(IProgressMonitor monitor) { boolean ok = true; - IStructuredSelection selection= (IStructuredSelection)getStructuredSelection(); + IStructuredSelection selection= getStructuredSelection(); Iterator elements= selection.iterator(); Object currObj = null; while (ok && elements.hasNext()) @@ -1059,7 +1059,7 @@ public class SystemTeamViewPart public boolean canRename() { boolean ok = true; - IStructuredSelection selection= (IStructuredSelection)getStructuredSelection(); + IStructuredSelection selection= getStructuredSelection(); Iterator elements= selection.iterator(); while (ok && elements.hasNext()) { @@ -1076,7 +1076,7 @@ public class SystemTeamViewPart public boolean doRename(String[] newNames) { boolean ok = true; - IStructuredSelection selection= (IStructuredSelection)getStructuredSelection(); + IStructuredSelection selection= getStructuredSelection(); Iterator elements= selection.iterator(); Object currObj = null; int idx = 0; @@ -1084,7 +1084,7 @@ public class SystemTeamViewPart { currObj = elements.next(); try { - profileAdapter.doRename(getShell(), (ISystemProfile)currObj, newNames[idx++]); + profileAdapter.doRename(getShell(), currObj, newNames[idx++]); } catch (SystemMessageException exc) { diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/widgets/EnvironmentVariablesForm.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/widgets/EnvironmentVariablesForm.java index 17cb56a7e6c..5d7a9f22518 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/widgets/EnvironmentVariablesForm.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/widgets/EnvironmentVariablesForm.java @@ -562,7 +562,7 @@ public class EnvironmentVariablesForm extends SystemBaseForm implements Selectio private SystemMessage validateName(String value) { SystemMessage msg = null; - String name = (String) value; + String name = value; if (name == null || name.trim().equals("")) { msg = RSEUIPlugin.getPluginMessage(ISystemMessages.MSG_COMM_ENVVAR_NONAME); @@ -573,7 +573,7 @@ public class EnvironmentVariablesForm extends SystemBaseForm implements Selectio { if (invalidNameChars.indexOf(' ') != -1) { - name = ((String) value).trim(); + name = (value).trim(); } // first check for invalid characters diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/widgets/SystemSelectConnectionForm.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/widgets/SystemSelectConnectionForm.java index 866ce0f06c7..782d0f99667 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/widgets/SystemSelectConnectionForm.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/widgets/SystemSelectConnectionForm.java @@ -355,7 +355,7 @@ public class SystemSelectConnectionForm extends SystemBaseForm } // MESSAGE/VERBAGE TEXT AT TOP - verbageLabel = (Label) SystemWidgetHelpers.createVerbiage(composite_prompts, verbage, gridColumns, false, PROMPT_WIDTH); + verbageLabel = SystemWidgetHelpers.createVerbiage(composite_prompts, verbage, gridColumns, false, PROMPT_WIDTH); //verbageLabel = SystemWidgetHelpers.createLabel(composite_prompts, verbage, gridColumns); // SPACER LINE diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/RSEDefaultNewConnectionWizardDelegate.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/RSEDefaultNewConnectionWizardDelegate.java index 6ca85a256ca..1e32887301a 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/RSEDefaultNewConnectionWizardDelegate.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/RSEDefaultNewConnectionWizardDelegate.java @@ -287,7 +287,7 @@ public class RSEDefaultNewConnectionWizardDelegate extends RSENewConnectionWizar { boolean ok = mainPage.performFinish(); if (!ok) - getWizard().setPageError((IWizardPage)mainPage); + getWizard().setPageError(mainPage); else if (ok && hasAdditionalPages()) { for (int idx=0; ok && (idx0)) { - IWizardPage previousPage = (IWizardPage)mainPage; + IWizardPage previousPage = mainPage; for (int idx=0; idx