mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-07 17:56:01 +02:00
Code Issues Wiki Activity

Bug 420604 - Disassembly view tends to scroll upwards on refresh

Browse source
This commit is contained in:
Anton Leherbauer 2013-11-05 15:00:51 +01:00
parent 61c76973a3
commit 3e528ebafe
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyPart.java
View file

@ -278,6 +278,7 @@ public abstract class DisassemblyPart extends WorkbenchPart implements IDisassem
private volatile int fUpdateCount; private volatile int fUpdateCount;
private BigInteger fPCAddress; private BigInteger fPCAddress;
private BigInteger fGotoAddressPending= PC_UNKNOWN; private BigInteger fGotoAddressPending= PC_UNKNOWN;
private boolean fGotoAddressOnTop;
private BigInteger fFocusAddress= PC_UNKNOWN; private BigInteger fFocusAddress= PC_UNKNOWN;
private int fBufferZone; private int fBufferZone;
private String fDebugSessionId; private String fDebugSessionId;
@ -1414,10 +1415,13 @@ public abstract class DisassemblyPart extends WorkbenchPart implements IDisassem
AddressRangePosition pos = getPositionOfAddress(address); AddressRangePosition pos = getPositionOfAddress(address);
if (pos != null) { if (pos != null) {
if (pos.fValid) { if (pos.fValid) {
boolean onTop = false;
if (fGotoAddressPending.equals(address)) { if (fGotoAddressPending.equals(address)) {
fGotoAddressPending = PC_UNKNOWN; fGotoAddressPending = PC_UNKNOWN;
onTop = fGotoAddressOnTop;
fGotoAddressOnTop = false;
} }
gotoPosition(pos, false); gotoPosition(pos, onTop);
} else { } else {
int lines = fBufferZone+3; int lines = fBufferZone+3;
BigInteger endAddress = pos.fAddressOffset.add(pos.fAddressLength).min( BigInteger endAddress = pos.fAddressOffset.add(pos.fAddressLength).min(
@ -2034,6 +2038,7 @@ public abstract class DisassemblyPart extends WorkbenchPart implements IDisassem
fTargetFrame = targetFrame; fTargetFrame = targetFrame;
fFrameAddress = frameAddress; fFrameAddress = frameAddress;
fPCAddress = pcAddress; fPCAddress = pcAddress;
fGotoAddressOnTop = true;
gotoAddress(topAddress); gotoAddress(topAddress);
} else { } else {
refreshView((int)(refreshViewScheduled - now)); refreshView((int)(refreshViewScheduled - now));