From 3d3460f63f16e034ec8ec6419a6326c5fa9b7c4e Mon Sep 17 00:00:00 2001 From: Martin Oberhuber < martin.oberhuber@windriver.com> Date: Wed, 9 Aug 2006 09:39:22 +0000 Subject: [PATCH] Fix unnecessary NPE when restoring local command shells. No change in observed operation since the NPE would have been caught anyway, but avoiding the NPE allows easier debugging with a Java exception breakpoint on java.lang.NullPointerException --- .../eclipse/rse/shells/ui/view/SystemCommandsViewPart.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/rse/plugins/org.eclipse.rse.shells.ui/src/org/eclipse/rse/shells/ui/view/SystemCommandsViewPart.java b/rse/plugins/org.eclipse.rse.shells.ui/src/org/eclipse/rse/shells/ui/view/SystemCommandsViewPart.java index 3c3ad9c0b55..807b660f324 100644 --- a/rse/plugins/org.eclipse.rse.shells.ui/src/org/eclipse/rse/shells/ui/view/SystemCommandsViewPart.java +++ b/rse/plugins/org.eclipse.rse.shells.ui/src/org/eclipse/rse/shells/ui/view/SystemCommandsViewPart.java @@ -674,9 +674,12 @@ public class SystemCommandsViewPart if (cmds == null || cmds.length == 0) { cmds = cmdSS.restoreShellState(getShell()); - for (int i = 0; i < cmds.length; i++) + if (cmds!=null) { - updateOutput(cmds[i]); + for (int i = 0; i < cmds.length; i++) + { + updateOutput(cmds[i]); + } } } }