mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-08 16:55:38 +02:00
Code Issues Wiki Activity

Bug 313622 Make checking for !a && b optional and off by default

Browse source
This commit is contained in:
Alena Laskavaia 2010-05-23 02:29:57 +00:00
parent 94711d3e76
commit 3a426fb5fc
1 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/SuggestedParenthesisChecker.java
View file

@ -11,6 +11,7 @@
package org.eclipse.cdt.codan.internal.checkers; package org.eclipse.cdt.codan.internal.checkers;
import org.eclipse.cdt.codan.core.cxx.model.AbstractIndexAstChecker; import org.eclipse.cdt.codan.core.cxx.model.AbstractIndexAstChecker;
import org.eclipse.cdt.codan.core.model.IProblemWorkingCopy;
import org.eclipse.cdt.core.dom.ast.ASTNodeProperty; import org.eclipse.cdt.core.dom.ast.ASTNodeProperty;
import org.eclipse.cdt.core.dom.ast.ASTVisitor; import org.eclipse.cdt.core.dom.ast.ASTVisitor;
import org.eclipse.cdt.core.dom.ast.IASTBinaryExpression; import org.eclipse.cdt.core.dom.ast.IASTBinaryExpression;
@ -31,6 +32,7 @@ import org.eclipse.cdt.core.dom.ast.IASTUnaryExpression;
*/ */
public class SuggestedParenthesisChecker extends AbstractIndexAstChecker { public class SuggestedParenthesisChecker extends AbstractIndexAstChecker {
private static final String ER_ID = "org.eclipse.cdt.codan.internal.checkers.SuggestedParenthesisProblem"; //$NON-NLS-1$ private static final String ER_ID = "org.eclipse.cdt.codan.internal.checkers.SuggestedParenthesisProblem"; //$NON-NLS-1$
private static final String PARAM_NOT = "paramNot";
public void processAst(IASTTranslationUnit ast) { public void processAst(IASTTranslationUnit ast) {
// traverse the ast using the visitor pattern. // traverse the ast using the visitor pattern.
@ -50,7 +52,7 @@ public class SuggestedParenthesisChecker extends AbstractIndexAstChecker {
if (isInParentesis(expression)) if (isInParentesis(expression))
return PROCESS_CONTINUE; return PROCESS_CONTINUE;
if (precedence == 2) { // unary not if (precedence == 2) { // unary not
if (isUsedAsOperand(expression)) { if (isParamNot() && isUsedAsOperand(expression)) {
reportProblem(ER_ID, expression); reportProblem(ER_ID, expression);
return PROCESS_SKIP; return PROCESS_SKIP;
} }
@ -114,4 +116,16 @@ public class SuggestedParenthesisChecker extends AbstractIndexAstChecker {
} }
return false; return false;
} }
public boolean isParamNot(){
return (Boolean) getPreference(getProblemById(ER_ID, getFile()), PARAM_NOT);
}
/* (non-Javadoc)
* @see org.eclipse.cdt.codan.core.model.AbstractCheckerWithProblemPreferences#initPreferences(org.eclipse.cdt.codan.core.model.IProblemWorkingCopy)
*/
@Override
public void initPreferences(IProblemWorkingCopy problem) {
super.initPreferences(problem);
addPreference(problem, PARAM_NOT, "Suggest parentesis around not operator", Boolean.FALSE);
}
} }