mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

[220842] S-Record export generates invalid checksums.

Browse source
This commit is contained in:
Ted Williams 2008-03-02 19:14:50 +00:00
parent 0669b2c27a
commit 39f6ca8ccc
3 changed files with 50 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
plugins/org.eclipse.dd.debug.memory.renderings.traditional/src/org/eclipse/dd/debug/memory/renderings/actions/ExportMemoryAction.java
View file

@ -159,16 +159,20 @@ public class ExportMemoryAction implements IViewActionDelegate {
buf.append(bString);
}
BigInteger checksum = BigInteger.ZERO;
/*
* The least significant byte of the one's complement of the sum of the values
* represented by the pairs of characters making up the records length, address,
* and the code/data fields.
*/
byte checksum = 0;
for(int i = 0; i < buf.length(); i+=2)
{
BigInteger value = new BigInteger(buf.substring(i, i+1), 16);
checksum = checksum.add(value);
BigInteger value = new BigInteger(buf.substring(i, i+2), 16);
checksum += value.byteValue();
}
buf.append(BigInteger.valueOf(0xFF - checksum.byteValue()).and(
BigInteger.valueOf(0xFF)).toString(16));
buf.append(BigInteger.valueOf(0xFF - checksum).and(BigInteger.valueOf(0xFF)).toString(16));
writer.write(buf.toString().toUpperCase());
writer.write("\n");

38
plugins/org.eclipse.dd.debug.memory.renderings.traditional/src/org/eclipse/dd/debug/memory/renderings/actions/ImportMemoryAction.java
View file

@ -21,9 +21,9 @@ import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Status;
import org.eclipse.core.runtime.jobs.Job;
import org.eclipse.dd.debug.memory.renderings.traditional.TraditionalRenderingPlugin;
import org.eclipse.debug.core.model.IMemoryBlock;
import org.eclipse.debug.core.model.IMemoryBlockExtension;
import org.eclipse.debug.core.model.MemoryByte;
import org.eclipse.debug.internal.ui.DebugUIPlugin;
import org.eclipse.debug.internal.ui.views.memory.MemoryView;
import org.eclipse.debug.internal.ui.views.memory.MemoryViewIdRegistry;
@ -89,7 +89,7 @@ public class ImportMemoryAction implements IViewActionDelegate {
BigInteger start = (BigInteger) results[2];
File file = (File) results[3];
if("S-Record".equals(format))
if("S-Record".equals(format)) //$NON-NLS-1$
{
downloadSRecord(file, start, useCustomAddress.booleanValue(), (IMemoryBlockExtension) memBlock); // FIXME
}
@ -101,6 +101,7 @@ public class ImportMemoryAction implements IViewActionDelegate {
private void downloadSRecord(final File inputFile, final BigInteger startAddress, final boolean useCustomAddress, final IMemoryBlockExtension memblock)
{
Job job = new Job("Memory Download from S-Record File"){ //$NON-NLS-1$
@Override
public IStatus run(IProgressMonitor monitor) {
try
@ -125,7 +126,7 @@ public class ImportMemoryAction implements IViewActionDelegate {
jobs = jobs.divide(factor);
}
monitor.beginTask("Transferring Data", jobs.intValue());
monitor.beginTask("Transferring Data", jobs.intValue()); //$NON-NLS-1$
BigInteger jobCount = BigInteger.ZERO;
String line = reader.readLine();
@ -139,11 +140,11 @@ public class ImportMemoryAction implements IViewActionDelegate {
BigInteger recordAddress = null;
if("S3".equals(recordType))
if("S3".equals(recordType)) //$NON-NLS-1$
addressSize = 4;
else if("S1".equals(recordType))
else if("S1".equals(recordType)) //$NON-NLS-1$
addressSize = 2;
else if("S2".equals(recordType))
else if("S2".equals(recordType)) //$NON-NLS-1$
addressSize = 3;
recordAddress = new BigInteger(line.substring(position, position + addressSize * 2), 16);
@ -161,6 +162,31 @@ public class ImportMemoryAction implements IViewActionDelegate {
data[i] = new BigInteger(line.substring(position++, position++ + 1), 16).byteValue();
}
/*
* The least significant byte of the one's complement of the sum of the values
* represented by the pairs of characters making up the records length, address,
* and the code/data fields.
*/
StringBuffer buf = new StringBuffer(line.substring(2));
byte checksum = 0;
for(int i = 0; i < buf.length(); i+=2)
{
BigInteger value = new BigInteger(buf.substring(i, i+2), 16);
checksum += value.byteValue();
}
/*
* Since we included the checksum in the checksum calculation the checksum
* ( if correct ) will always be 0xFF which is -1 using the signed byte size
* calculation here.
*/
if ( checksum != (byte) -1 ) {
reader.close();
monitor.done();
return new Status( IStatus.ERROR, TraditionalRenderingPlugin.getUniqueIdentifier(), "Checksum failure of line = " + line); //$NON-NLS-1$
}
// FIXME error on incorrect checksum
memblock.setValue(recordAddress.subtract(memblock.getBigBaseAddress()), data);

10
plugins/org.eclipse.dd.debug.memory.renderings.traditional/src/org/eclipse/dd/debug/memory/renderings/traditional/TraditionalRenderingPlugin.java
View file

@ -15,7 +15,8 @@ import org.eclipse.ui.plugin.AbstractUIPlugin;
public class TraditionalRenderingPlugin extends AbstractUIPlugin
{
private static final String PLUGIN_ID = "org.eclipse.dd.debug.memory.renderings.traditional"; //$NON-NLS-1$
private static TraditionalRenderingPlugin plugin;
public TraditionalRenderingPlugin()
@ -30,4 +31,11 @@ public class TraditionalRenderingPlugin extends AbstractUIPlugin
public static TraditionalRenderingPlugin getDefault() {
return plugin;
}
/**
* Returns the unique identifier for this plugin.
*/
public static String getUniqueIdentifier() {
return PLUGIN_ID;
}
}