mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-09 01:05:38 +02:00
Code Issues Wiki Activity

Remove compile and javadoc warnings

Browse source
This commit is contained in:
Kushal Munir 2006-11-29 03:35:53 +00:00
parent c159c4a582
commit 3665ea9c49
5 changed files with 22 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemShowPreferencesPageAction.java
View file

@ -24,6 +24,7 @@ import org.eclipse.jface.preference.IPreferenceNode;
import org.eclipse.jface.preference.PreferenceDialog; import org.eclipse.jface.preference.PreferenceDialog;
import org.eclipse.jface.preference.PreferenceManager; import org.eclipse.jface.preference.PreferenceManager;
import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelection;
import org.eclipse.rse.ui.RSEUIPlugin;
import org.eclipse.ui.IViewActionDelegate; import org.eclipse.ui.IViewActionDelegate;
import org.eclipse.ui.IViewPart; import org.eclipse.ui.IViewPart;
import org.eclipse.ui.PlatformUI; import org.eclipse.ui.PlatformUI;
@ -40,6 +41,10 @@ import org.eclipse.ui.internal.dialogs.WorkbenchPreferenceDialog;
* extension point. * extension point.
* @see org.eclipse.rse.ui.actions.SystemCascadingPreferencesAction * @see org.eclipse.rse.ui.actions.SystemCascadingPreferencesAction
*/ */
/**
* @author kmunir
*
*/
public class SystemShowPreferencesPageAction extends SystemBaseAction implements IViewActionDelegate public class SystemShowPreferencesPageAction extends SystemBaseAction implements IViewActionDelegate
{ {
@ -48,12 +53,12 @@ public class SystemShowPreferencesPageAction extends SystemBaseAction implements
private String preferencePageCategory; private String preferencePageCategory;
/** /**
* Constructor. We are instantiated inside {@link RSEUIPlugin#getPreferencePageActionPlugins()} * Constructor. We are instantiated inside {@link RSEUIPlugin#getShowPreferencePageActions()}
* for each extension of our extension point <code>org.eclipse.rse.core.remoteSystemsViewPreferencesActions</code> * for each extension of our extension point <code>org.eclipse.rse.core.remoteSystemsViewPreferencesActions</code>
*/ */
public SystemShowPreferencesPageAction() public SystemShowPreferencesPageAction()
{ {
super("temp label", null); super("temp label", null); //$NON-NLS-1$
} }
/** /**
@ -94,17 +99,17 @@ public class SystemShowPreferencesPageAction extends SystemBaseAction implements
} }
/** /**
* @see IActionDelegate#run(IAction) * @see org.eclipse.ui.IActionDelegate#run(org.eclipse.jface.action.IAction)
*/ */
public void run(IAction action) public void run(IAction action)
{ {
run(); run();
} }
/** /**
* @see IActionDelegate#selectionChanged(IAction, ISelection) * @see org.eclipse.ui.IActionDelegate#selectionChanged(org.eclipse.jface.action.IAction, org.eclipse.jface.viewers.ISelection)
*/ */
public void selectionChanged(IAction action, ISelection selection) public void selectionChanged(IAction action, ISelection selection)
{ {
@ -130,7 +135,7 @@ public class SystemShowPreferencesPageAction extends SystemBaseAction implements
PreferenceDialog d = new WorkbenchPreferenceDialog(shell, pm); PreferenceDialog d = new WorkbenchPreferenceDialog(shell, pm);
d.create(); d.create();
// TODO - hack to make this work in 3.1 // TODO - hack to make this work in 3.1
String id = PlatformUI.PLUGIN_ID + ".preference_dialog_context"; String id = PlatformUI.PLUGIN_ID + ".preference_dialog_context"; //$NON-NLS-1$
PlatformUI.getWorkbench().getHelpSystem().setHelp(d.getShell(), id); PlatformUI.getWorkbench().getHelpSystem().setHelp(d.getShell(), id);
d.open(); d.open();

10
rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/AbstractSystemSubSystemPropertyPageCoreForm.java
View file

@ -21,7 +21,6 @@ import org.eclipse.jface.wizard.WizardPage;
import org.eclipse.rse.core.subsystems.ISubSystem; import org.eclipse.rse.core.subsystems.ISubSystem;
import org.eclipse.rse.core.subsystems.ISubSystemConfiguration; import org.eclipse.rse.core.subsystems.ISubSystemConfiguration;
import org.eclipse.rse.services.clientserver.messages.SystemMessage; import org.eclipse.rse.services.clientserver.messages.SystemMessage;
import org.eclipse.rse.ui.RSEUIPlugin;
import org.eclipse.rse.ui.SystemResources; import org.eclipse.rse.ui.SystemResources;
import org.eclipse.rse.ui.SystemWidgetHelpers; import org.eclipse.rse.ui.SystemWidgetHelpers;
import org.eclipse.rse.ui.dialogs.SystemPromptDialog; import org.eclipse.rse.ui.dialogs.SystemPromptDialog;
@ -65,7 +64,6 @@ public abstract class AbstractSystemSubSystemPropertyPageCoreForm
callerInstanceOfWizardPage = (caller instanceof WizardPage); callerInstanceOfWizardPage = (caller instanceof WizardPage);
callerInstanceOfSystemPromptDialog = (caller instanceof SystemPromptDialog); callerInstanceOfSystemPromptDialog = (caller instanceof SystemPromptDialog);
callerInstanceOfPropertyPage = (caller instanceof PropertyPage); callerInstanceOfPropertyPage = (caller instanceof PropertyPage);
RSEUIPlugin sp = RSEUIPlugin.getDefault();
} }
/** /**
* Get the input element * Get the input element
@ -103,22 +101,22 @@ public abstract class AbstractSystemSubSystemPropertyPageCoreForm
// Vendor display // Vendor display
labelText = SystemWidgetHelpers.appendColon(SystemResources.RESID_SUBSYSTEM_VENDOR_LABEL); labelText = SystemWidgetHelpers.appendColon(SystemResources.RESID_SUBSYSTEM_VENDOR_LABEL);
labelVendorPrompt = SystemWidgetHelpers.createLabel(composite_prompts, labelText); labelVendorPrompt = SystemWidgetHelpers.createLabel(composite_prompts, labelText);
labelVendor = SystemWidgetHelpers.createLabel(composite_prompts, " "); labelVendor = SystemWidgetHelpers.createLabel(composite_prompts, " "); //$NON-NLS-1$
// Name display // Name display
labelText = SystemWidgetHelpers.appendColon(SystemResources.RESID_SUBSYSTEM_NAME_LABEL); labelText = SystemWidgetHelpers.appendColon(SystemResources.RESID_SUBSYSTEM_NAME_LABEL);
labelNamePrompt = SystemWidgetHelpers.createLabel(composite_prompts, labelText); labelNamePrompt = SystemWidgetHelpers.createLabel(composite_prompts, labelText);
labelName = SystemWidgetHelpers.createLabel(composite_prompts, " "); labelName = SystemWidgetHelpers.createLabel(composite_prompts, " "); //$NON-NLS-1$
// Connection display // Connection display
labelText = SystemWidgetHelpers.appendColon(SystemResources.RESID_SUBSYSTEM_CONNECTION_LABEL); labelText = SystemWidgetHelpers.appendColon(SystemResources.RESID_SUBSYSTEM_CONNECTION_LABEL);
labelConnectionPrompt = SystemWidgetHelpers.createLabel(composite_prompts, labelText); labelConnectionPrompt = SystemWidgetHelpers.createLabel(composite_prompts, labelText);
labelConnection = SystemWidgetHelpers.createLabel(composite_prompts, " "); labelConnection = SystemWidgetHelpers.createLabel(composite_prompts, " "); //$NON-NLS-1$
// Profile display // Profile display
labelText = SystemWidgetHelpers.appendColon(SystemResources.RESID_SUBSYSTEM_PROFILE_LABEL); labelText = SystemWidgetHelpers.appendColon(SystemResources.RESID_SUBSYSTEM_PROFILE_LABEL);
labelProfilePrompt = SystemWidgetHelpers.createLabel(composite_prompts, labelText); labelProfilePrompt = SystemWidgetHelpers.createLabel(composite_prompts, labelText);
labelProfile = SystemWidgetHelpers.createLabel(composite_prompts, " "); labelProfile = SystemWidgetHelpers.createLabel(composite_prompts, " "); //$NON-NLS-1$
createInner(composite_prompts, inputElement, shell); createInner(composite_prompts, inputElement, shell);

5
rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/AbstractSystemViewAdapter.java
View file

@ -575,7 +575,7 @@ public abstract class AbstractSystemViewAdapter
* *
* @return an array containing all descriptors to be added to the default set of descriptors, or null * @return an array containing all descriptors to be added to the default set of descriptors, or null
* if no additional properties desired. * if no additional properties desired.
* @see #createSimplePropertyDescriptor(String,ResourceBundle,String) * @see #createSimplePropertyDescriptor(String, String, String)
*/ */
protected abstract IPropertyDescriptor[] internalGetPropertyDescriptors(); protected abstract IPropertyDescriptor[] internalGetPropertyDescriptors();
@ -1105,9 +1105,8 @@ public abstract class AbstractSystemViewAdapter
* set. For optimal performance, this should be overridden. * set. For optimal performance, this should be overridden.
* *
* @param set the set of objects to copy * @param set the set of objects to copy
* @param sameSystemType indication of whether the source and target reside on the same type of system
* @param monitor the progress monitor * @param monitor the progress monitor
* @return a temporary workspace copies of the object that was copied * @return the set of objects as a result of the drag
* *
*/ */
public ISystemResourceSet doDrag(SystemRemoteResourceSet set, IProgressMonitor monitor) public ISystemResourceSet doDrag(SystemRemoteResourceSet set, IProgressMonitor monitor)

4
rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/AbstractConnectorService.java
View file

@ -1044,7 +1044,7 @@ public abstract class AbstractConnectorService extends RSEModelObject implements
// } // }
/** /**
* This methods returns the enablement state per server launch type. * This methods returns the enablement state per server launch type.
* If {@link #enableServerLaunchType(ServerLaunchType,boolean)} has not been * If {@link RemoteServerLauncher#enableServerLaunchType(ServerLaunchType, boolean)} has not been
* called for this server launch type, then it is enabled by default. * called for this server launch type, then it is enabled by default.
* @see org.eclipse.rse.core.subsystems.ServerLaunchType * @see org.eclipse.rse.core.subsystems.ServerLaunchType
*/ */
@ -1144,7 +1144,7 @@ public abstract class AbstractConnectorService extends RSEModelObject implements
private void logException(Throwable t) { private void logException(Throwable t) {
Logger log = LoggerFactory.getLogger(RSEUIPlugin.getDefault()); Logger log = LoggerFactory.getLogger(RSEUIPlugin.getDefault());
log.logError("Unexpected exception", t); log.logError("Unexpected exception", t); //$NON-NLS-1$
} }
protected NewPasswordInfo promptForNewPassword(SystemMessage prompt) throws InterruptedException protected NewPasswordInfo promptForNewPassword(SystemMessage prompt) throws InterruptedException

8
rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/AbstractConnectorServiceManager.java
View file

@ -49,15 +49,13 @@ import org.eclipse.swt.widgets.Shell;
* <p> * <p>
* Your subclass <b>must supply</b> a method like the following:</p> * Your subclass <b>must supply</b> a method like the following:</p>
* <pre><code> * <pre><code>
* public static AbstractSystemManager <b>getTheSystemManager</b>() * public static MyConnectorServiceManager <b>getTheMyConnectorServiceManager</b>()
* { * {
* if (inst == null) * if (inst == null)
* inst = new AbstractSystemManager(); * inst = new MyConnectorServiceManager();
* return inst; * return inst;
* } * }
* </code></pre> * </code></pre>
* Your {@link org.eclipse.rse.core.servicesubsystem.ServiceSubSystem SubSystem} class
* should then call this factory method in its {@link org.eclipse.rse.core.servicesubsystem.ServiceSubSystem#getSystemManager() getSystemManager()} method.
*/ */
public abstract class AbstractConnectorServiceManager implements IConnectorServiceManager public abstract class AbstractConnectorServiceManager implements IConnectorServiceManager
{ {
@ -185,7 +183,7 @@ public abstract class AbstractConnectorServiceManager implements IConnectorServi
* subsystems in this SystemConnection, that share a single IConnectorService, * subsystems in this SystemConnection, that share a single IConnectorService,
* so we keep them all in synch in terms of these two properties used * so we keep them all in synch in terms of these two properties used
* by all ISystems. * by all ISystems.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#updateSubSystem(Shell,ISubSystem,boolean,String,boolean,Integer) * @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#updateSubSystem(ISubSystem, boolean, String, boolean, int)
*/ */
public void updateSubSystems(Shell shell, ISubSystem subsystem, boolean updateUserId, String userId, boolean updatePort, int port) public void updateSubSystems(Shell shell, ISubSystem subsystem, boolean updateUserId, String userId, boolean updatePort, int port)
{ {