From 352f47bc82cd03b945040414ba09806a40992ddf Mon Sep 17 00:00:00 2001 From: Sergey Prigogin Date: Sun, 20 Nov 2016 12:42:15 -0800 Subject: [PATCH] Improved Remove Unused Declarations code reducer Change-Id: I6d7cdea0fe85df14fe64ea7bd57b88ac27f4f9df --- .../tests/reducer/RemoveUnusedDeclarationsRefactoring.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/core/org.eclipse.cdt.ui.tests/src/org/eclipse/cdt/ui/tests/reducer/RemoveUnusedDeclarationsRefactoring.java b/core/org.eclipse.cdt.ui.tests/src/org/eclipse/cdt/ui/tests/reducer/RemoveUnusedDeclarationsRefactoring.java index 09b6632f585..2843752b273 100644 --- a/core/org.eclipse.cdt.ui.tests/src/org/eclipse/cdt/ui/tests/reducer/RemoveUnusedDeclarationsRefactoring.java +++ b/core/org.eclipse.cdt.ui.tests/src/org/eclipse/cdt/ui/tests/reducer/RemoveUnusedDeclarationsRefactoring.java @@ -53,6 +53,7 @@ import org.eclipse.cdt.core.dom.ast.IASTFunctionDeclarator; import org.eclipse.cdt.core.dom.ast.IASTFunctionDefinition; import org.eclipse.cdt.core.dom.ast.IASTName; import org.eclipse.cdt.core.dom.ast.IASTNode; +import org.eclipse.cdt.core.dom.ast.IASTParameterDeclaration; import org.eclipse.cdt.core.dom.ast.IASTPreprocessorMacroExpansion; import org.eclipse.cdt.core.dom.ast.IASTSimpleDeclaration; import org.eclipse.cdt.core.dom.ast.IASTTranslationUnit; @@ -336,6 +337,11 @@ public class RemoveUnusedDeclarationsRefactoring extends CRefactoring { for (IASTName name : names) { if (name != declName) { + if (name.getPropertyInParent() == IASTDeclarator.DECLARATOR_NAME + && name.getParent().getPropertyInParent() == IASTParameterDeclaration.DECLARATOR) { + continue; // Ignore parameter names. + } + char[] nameChars = name.getSimpleID(); int offset = nameChars.length != 0 && nameChars[0] == '~' ? 1 : 0;