Fixes warnings

core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/buildconsole/BuildConsoleManager.java

@@ -13,25 +13,19 @@ package org.eclipse.cdt.internal.ui.buildconsole;
 import java.util.HashMap;
 import java.util.Map;
 
-import org.eclipse.cdt.core.resources.IConsole;
-import org.eclipse.cdt.internal.ui.preferences.BuildConsolePreferencePage;
-import org.eclipse.cdt.ui.CUIPlugin;
-import org.eclipse.cdt.ui.IBuildConsoleEvent;
-import org.eclipse.cdt.ui.IBuildConsoleListener;
-import org.eclipse.cdt.ui.IBuildConsoleManager;
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.resources.IResource;
 import org.eclipse.core.resources.IResourceChangeEvent;
 import org.eclipse.core.resources.IResourceChangeListener;
 import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IStatus;
+import org.eclipse.core.runtime.ListenerList;
 import org.eclipse.core.runtime.Status;
 import org.eclipse.jface.preference.PreferenceConverter;
 import org.eclipse.jface.text.Assert;
 import org.eclipse.jface.text.IDocument;
 import org.eclipse.jface.text.IDocumentPartitioner;
 import org.eclipse.jface.util.IPropertyChangeListener;
-import org.eclipse.jface.util.ListenerList;
 import org.eclipse.jface.util.PropertyChangeEvent;
 import org.eclipse.swt.graphics.Color;
 import org.eclipse.swt.graphics.RGB;
@@ -45,9 +39,17 @@ import org.eclipse.ui.console.ConsolePlugin;
 import org.eclipse.ui.console.IConsoleConstants;
 import org.eclipse.ui.console.IConsoleView;
 
+import org.eclipse.cdt.core.resources.IConsole;
+import org.eclipse.cdt.ui.CUIPlugin;
+import org.eclipse.cdt.ui.IBuildConsoleEvent;
+import org.eclipse.cdt.ui.IBuildConsoleListener;
+import org.eclipse.cdt.ui.IBuildConsoleManager;
+
+import org.eclipse.cdt.internal.ui.preferences.BuildConsolePreferencePage;
+
 public class BuildConsoleManager implements IBuildConsoleManager, IResourceChangeListener, IPropertyChangeListener {
 
-	ListenerList listeners = new ListenerList(1);
+	ListenerList listeners = new ListenerList();
 	BuildConsole fConsole;
 	private Map fConsoleMap = new HashMap();
 	Color infoColor, outputColor, errorColor;

core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/buildconsole/BuildConsolePage.java

@@ -336,7 +336,6 @@ public class BuildConsolePage extends Page
 
 	protected void setInitialSelection() {
 		// Use the selection, if any
-		Object input;
 		IWorkbenchPage page= getSite().getPage();
 		ISelection selection= null;
 		if (page != null)
@@ -446,7 +445,7 @@ public class BuildConsolePage extends Page
 	/**
 	 * Sets the tab width for this page.
 	 * 
-	 * @param int
+	 * @param tabs
 	 *            tab width
 	 */
 	protected void setTabs(int tabs) {

core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/codemanipulation/AddIncludesOperation.java

@@ -43,7 +43,6 @@ public class AddIncludesOperation implements IWorkspaceRunnable {
 	private ITranslationUnit fTranslationUnit;
 	private IRequiredInclude[] fIncludes;
 	private String[] fUsings;
-	private boolean fDoSave;
 
 	private String newLine = System.getProperty("line.separator", "\n");  //$NON-NLS-1$//$NON-NLS-2$
 
@@ -62,7 +61,6 @@ public class AddIncludesOperation implements IWorkspaceRunnable {
 		fIncludes= includes;
 		fUsings = using;
 		fTranslationUnit = tu;
-		fDoSave= save;
 	}
 	
 	public void executeInludes(IProgressMonitor monitor) throws CoreException {

core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/codemanipulation/StubUtility.java

@@ -20,20 +20,20 @@ import org.eclipse.swt.SWT;
 public class StubUtility {
 	
 	/**
-	 * @see org.eclipse.jdt.ui.CodeGeneration#getTypeComment(ICompilationUnit, String, String)
+	 * Not implemented, returns <code>""</code>.
 	 */	
 	public static String getHeaderFileContent(ITranslationUnit cu, String typeComment, String typeContent, String lineDelimiter) throws CoreException {
 		return ""; //$NON-NLS-1$
 	}
 	/**
-	 * @see org.eclipse.jdt.ui.CodeGeneration#getTypeComment(ICompilationUnit, String, String)
+	 * Not implemented, returns <code>""</code>.
 	 */	
 	public static String getBodyFileContent(ITranslationUnit cu, String typeComment, String typeContent, String lineDelimiter) throws CoreException {
 		return ""; //$NON-NLS-1$
 	}
-	/*
+	/**
-	 * @see org.eclipse.jdt.ui.CodeGeneration#getTypeComment(ICompilationUnit, String, String)
+	 * Not implemented, returns <code>""</code>.
-	 */		
+	 */	
 	public static String getClassComment(ITranslationUnit cu, String typeQualifiedName, String lineDelim) throws CoreException {
 		return ""; //$NON-NLS-1$
 	}

core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/compare/CNode.java

@@ -24,11 +24,8 @@ import org.eclipse.swt.graphics.Image;
 
 class CNode extends DocumentRangeNode implements ITypedElement {
 
-	private CNode fParent;
-		
 	public CNode(CNode parent, int type, String id, IDocument doc, int start, int length) {
 		super(type, id, doc, start, length);
-		fParent= parent;
 		if (parent != null) {
 			parent.addChild(this);
 		}
@@ -38,23 +35,14 @@ class CNode extends DocumentRangeNode implements ITypedElement {
 		this(parent, type, id, parent.getDocument(), start, length);
 	}
 
-	/**
-	 * @see ITypedInput#getName
-	 */
 	public String getName() {
 		return getId();
 	}
 
-	/**
-	 * @see ITypedInput#getType
-	 */
 	public String getType() {
 		return "c2"; //$NON-NLS-1$
 	}
 
-	/**
-	 * @see ITypedInput#getImage
-	 */
 	public Image getImage() {
 		ImageDescriptor descriptor = CElementImageProvider.getImageDescriptor(getTypeCode());
 		return CUIPlugin.getImageDescriptorRegistry().get(descriptor);

core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/compare/CStructureCreator.java

@@ -47,16 +47,10 @@ public class CStructureCreator implements IStructureCreator {
 	public CStructureCreator() {
 	}
 
-	/**
-	 * @see IStructureCreator#getTitle
-	 */
 	public String getName() {
 		return CUIPlugin.getResourceString(NAME);
 	}
 
-	/**
-	 * @see IStructureCreator#getStructure
-	 */
 	public IStructureComparator getStructure(Object input) {
 
 		String s = null;
@@ -94,30 +88,18 @@ public class CStructureCreator implements IStructureCreator {
 		return root;
 	}
 
-	/**
-	 * @see IStructureCreator#canSave
-	 */
 	public boolean canSave() {
 		return true;
 	}
 
-	/**
-	 * @see IStructureCreator#locate
-	 */
 	public IStructureComparator locate(Object path, Object source) {
 		return null;
 	}
 
-	/**
-	 * @see IStructureCreator#canRewriteTree
-	 */
 	public boolean canRewriteTree() {
 		return false;
 	}
 
-	/**
-	 * @see IStructureCreator#rewriteTree
-	 */
 	public void rewriteTree(Differencer differencer, IDiffContainer root) {
 	}
 

core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/cview/CView.java

@@ -204,7 +204,7 @@ public class CView extends ViewPart implements ISetSelectionTarget, IPropertyCha
 	 * Reveal and select the passed element selection in self's visual
 	 * component
 	 * 
-	 * @see ISetSelectionTarget#selectReveal()
+	 * @see ISetSelectionTarget#selectReveal(ISelection)
 	 */
 	public void selectReveal(ISelection selection) {
 		IStructuredSelection ssel = SelectionConverter.convertSelectionToCElements(selection);

core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/cview/CViewActionGroup.java

@@ -21,6 +21,8 @@ import org.eclipse.swt.events.KeyEvent;
 import org.eclipse.ui.IActionBars;
 import org.eclipse.ui.IMemento;
 import org.eclipse.ui.actions.ActionGroup;
+import org.eclipse.ui.views.navigator.SortAndFilterActionGroup;
+import org.eclipse.ui.views.navigator.WorkspaceActionGroup;
 
 /**
  * This is the action group for all the view actions.
@@ -43,7 +45,7 @@ public abstract class CViewActionGroup extends ActionGroup {
 	/**
 	 * Constructs a new navigator action group and creates its actions.
 	 * 
-	 * @param navigator the resource navigator
+	 * @param cview the CView
 	 */
 	public CViewActionGroup(CView cview) {
 		this.cview = cview;

core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/cview/CViewContentProvider.java

@@ -90,9 +90,6 @@ public class CViewContentProvider extends CElementContentProvider {
 		return ref.getChildren();
 	}
 	
-	/**
-	 * @return
-	 */
 	private Object[] getProjectChildren(ICProject cproject) throws CModelException {
 		Object[] extras = null;
 		IArchiveContainer archive = cproject.getArchiveContainer(); 

core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/cview/CViewLabelProvider.java

@@ -27,10 +27,6 @@ import org.eclipse.swt.graphics.Image;
  */
 public class CViewLabelProvider extends StandardCElementLabelProvider {
 	
-	/**
-	 * @param flags
-	 * @param adormentProviders
-	 */
 	public CViewLabelProvider(int textFlags, int imageFlags) {
 		super(textFlags, imageFlags);
 	}

core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/cview/SelectionTransferDragAdapter.java

@@ -31,7 +31,6 @@ public class SelectionTransferDragAdapter extends BasicSelectionTransferDragAdap
 			for (Iterator iter= ((IStructuredSelection)selection).iterator(); iter.hasNext();) {
 				Object element= iter.next();
 				if (element instanceof ICElement) {
-					ICElement celement = (ICElement)element;
 					if (!(element instanceof ISourceReference)) {
 						return  false;
 					}

core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/dialogs/StatusDialog.java

@@ -39,27 +39,13 @@ public abstract class StatusDialog extends Dialog {
 	private String fTitle;
 	private Image fImage;
 	
-	private boolean fStatusLineAboveButtons;
-	
 	/**
 	 * Creates an instane of a status dialog.
 	 */
 	public StatusDialog(Shell parent) {
 		super(parent);
-		fStatusLineAboveButtons= false;
 	}
-	
+		
-	/**
-	 * Specifies whether status line appears to the left of the buttons (default)
-	 * or above them.
-	 *
-	 * @param aboveButtons if <code>true</code> status line is placed above buttons; if
-	 * 	<code>false</code> to the right
-	 */
-	public void setStatusLineAboveButtons(boolean aboveButtons) {
-		fStatusLineAboveButtons= aboveButtons;
-	}	
-	
 	/**
 	 * Update the dialog's status line to reflect the given status.
 	 * It is save to call this method before the dialog has been opened.