mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-19 14:15:50 +02:00
Code Issues Wiki Activity

Remove unnecessary check after instanceof

Browse source
This commit is contained in:
Martin Oberhuber 2006-08-08 08:36:50 +00:00
parent 1f3cf11369
commit 328e07f782
1 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
rse/plugins/org.eclipse.rse.subsystems.shells.core/src/org/eclipse/rse/internal/subsystems/shells/subsystems/RemoteCmdSubSystem.java
View file

@ -59,7 +59,7 @@ import org.eclipse.swt.widgets.Shell;
public abstract class RemoteCmdSubSystem extends SubSystem implements IRemoteCmdSubSystem, ICommunicationsListener public abstract class RemoteCmdSubSystem extends SubSystem implements IRemoteCmdSubSystem, ICommunicationsListener
{ {
public static String COMMAND_SHELLS_MEMENTO = "commandshells"; public static String COMMAND_SHELLS_MEMENTO = "commandshells"; //$NON-NLS-1$
protected java.util.List envVars = null; protected java.util.List envVars = null;
@ -87,22 +87,22 @@ public abstract class RemoteCmdSubSystem extends SubSystem implements IRemoteCmd
public String getShellEncoding() public String getShellEncoding()
{ {
IPropertySet set = getPropertySet("Remote"); IPropertySet set = getPropertySet("Remote"); //$NON-NLS-1$
if (set != null) if (set != null)
{ {
return set.getPropertyValue("shell.encoding"); return set.getPropertyValue("shell.encoding"); //$NON-NLS-1$
} }
return null; return null;
} }
public void setShellEncoding(String encoding) public void setShellEncoding(String encoding)
{ {
IPropertySet set = getPropertySet("Remote"); IPropertySet set = getPropertySet("Remote"); //$NON-NLS-1$
if (set == null) if (set == null)
{ {
set = createPropertySet("Remote", getDescription()); set = createPropertySet("Remote", getDescription()); //$NON-NLS-1$
} }
set.addProperty("shell.encoding", encoding); set.addProperty("shell.encoding", encoding); //$NON-NLS-1$
setDirty(true); setDirty(true);
commit(); commit();
} }
@ -283,7 +283,7 @@ public abstract class RemoteCmdSubSystem extends SubSystem implements IRemoteCmd
{ {
name = name.toUpperCase(); name = name.toUpperCase();
} }
envVars[i] = name + "=" + list[i].getValue(); envVars[i] = name + "=" + list[i].getValue(); //$NON-NLS-1$
} }
} }
@ -368,8 +368,8 @@ public abstract class RemoteCmdSubSystem extends SubSystem implements IRemoteCmd
public boolean isWindows() public boolean isWindows()
{ {
String type = getSystemType(); String type = getSystemType();
return (type.equals("Windows") || type.equals("Local") return (type.equals("Windows") || type.equals("Local") //$NON-NLS-1$ //$NON-NLS-2$
&& System.getProperty("os.name").toLowerCase().startsWith("win")); && System.getProperty("os.name").toLowerCase().startsWith("win")); //$NON-NLS-1$ //$NON-NLS-2$
} }
/** /**
@ -395,7 +395,7 @@ public abstract class RemoteCmdSubSystem extends SubSystem implements IRemoteCmd
ArrayList addedFolders = new ArrayList(); ArrayList addedFolders = new ArrayList();
char separator = isWindows() ? ';' : ':'; char separator = isWindows() ? ';' : ':';
StringTokenizer tokenizer = new StringTokenizer(path, separator + ""); StringTokenizer tokenizer = new StringTokenizer(path, separator + ""); //$NON-NLS-1$
while (tokenizer.hasMoreTokens()) while (tokenizer.hasMoreTokens())
{ {
String token = tokenizer.nextToken(); String token = tokenizer.nextToken();
@ -437,7 +437,7 @@ public abstract class RemoteCmdSubSystem extends SubSystem implements IRemoteCmd
*/ */
public String getInvalidEnvironmentVariableNameCharacters() public String getInvalidEnvironmentVariableNameCharacters()
{ {
return "="; return "="; //$NON-NLS-1$
} }
// ------------------------------- // -------------------------------
@ -640,7 +640,7 @@ public abstract class RemoteCmdSubSystem extends SubSystem implements IRemoteCmd
int numShells = 0; int numShells = 0;
if (shellStr != null && shellStr.length() > 0) if (shellStr != null && shellStr.length() > 0)
{ {
StringTokenizer tok = new StringTokenizer(shellStr, "|"); StringTokenizer tok = new StringTokenizer(shellStr, "|"); //$NON-NLS-1$
results = new IRemoteCommandShell[tok.countTokens()]; results = new IRemoteCommandShell[tok.countTokens()];
while (tok.hasMoreTokens()) while (tok.hasMoreTokens())