mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-22 14:12:10 +02:00
Code Issues Wiki Activity

Bug 478740: Cleanup reverse toggle image handling

Browse source 
Change-Id: I5b7eae467179b4cd34d9633bc217a48cf729fd87
This commit is contained in:
Marc Khouzam 2016-02-28 22:37:59 -05:00
parent 4f5cccde8a
commit 2befa91f27
1 changed files with 12 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/commands/ReverseToggleCommandHandler.java
View file

@ -58,9 +58,12 @@ import org.osgi.framework.Bundle;
public class ReverseToggleCommandHandler extends DebugCommandHandler implements IDebugContextListener, IElementUpdater { public class ReverseToggleCommandHandler extends DebugCommandHandler implements IDebugContextListener, IElementUpdater {
private ReverseTraceMethod fTraceMethod; private ReverseTraceMethod fTraceMethod;
private ReverseTraceMethod fLastTraceMethod; private ReverseTraceMethod fLastTraceMethod;
private ImageDescriptor fTracemethodOnImages[];
private ImageDescriptor fTracemethodOffImages[]; private static final ImageDescriptor REVERSE_TOGGLE_DEFAULT_IMAGE = getImageDescriptor("icons/obj16/reverse_toggle.gif"); //$NON-NLS-1$
private ImageDescriptor fTracemethodDefaultImage; private static final ImageDescriptor REVERSE_TOGGLE_SOFTWARE_ON_IMAGE = getImageDescriptor("icons/obj16/reverse_toggle_sw_on.png"); //$NON-NLS-1$
private static final ImageDescriptor REVERSE_TOGGLE_SOFTWARE_OFF_IMAGE = getImageDescriptor("icons/obj16/reverse_toggle_sw_off.png"); //$NON-NLS-1$
private static final ImageDescriptor REVERSE_TOGGLE_HARDWARE_ON_IMAGE = getImageDescriptor("icons/obj16/reverse_toggle_hw_on.png"); //$NON-NLS-1$
private static final ImageDescriptor REVERSE_TOGGLE_HARDWARE_OFF_IMAGE = getImageDescriptor("icons/obj16/reverse_toggle_hw_off.png"); //$NON-NLS-1$
@Override @Override
protected Class<?> getCommandType() { protected Class<?> getCommandType() {
@ -83,7 +86,7 @@ public class ReverseToggleCommandHandler extends DebugCommandHandler implements
private IReverseToggleHandler fTargetAdapter = null; private IReverseToggleHandler fTargetAdapter = null;
private IDebugContextService fContextService = null; private IDebugContextService fContextService = null;
private ImageDescriptor getImageDescriptor (String path) { private static ImageDescriptor getImageDescriptor (String path) {
Bundle bundle = Platform.getBundle("org.eclipse.cdt.debug.ui"); //$NON-NLS-1$ Bundle bundle = Platform.getBundle("org.eclipse.cdt.debug.ui"); //$NON-NLS-1$
URL url = null; URL url = null;
if (bundle != null) { if (bundle != null) {
@ -106,14 +109,6 @@ public class ReverseToggleCommandHandler extends DebugCommandHandler implements
// This can happen if we activate the action set after the launch. // This can happen if we activate the action set after the launch.
refresh(fContextService.getActiveContext()); refresh(fContextService.getActiveContext());
fTracemethodOnImages = new ImageDescriptor[2];
fTracemethodOffImages = new ImageDescriptor[2];
fTracemethodDefaultImage = getImageDescriptor("icons/obj16/reverse_toggle.gif"); //$NON-NLS-1$
fTracemethodOnImages[0] = getImageDescriptor("icons/obj16/reverse_toggle_sw_on.png"); //$NON-NLS-1$
fTracemethodOnImages[1] = getImageDescriptor("icons/obj16/reverse_toggle_hw_on.png"); //$NON-NLS-1$
fTracemethodOffImages[0] = getImageDescriptor("icons/obj16/reverse_toggle_sw_off.png"); //$NON-NLS-1$
fTracemethodOffImages[1] = getImageDescriptor("icons/obj16/reverse_toggle_hw_off.png"); //$NON-NLS-1$
fTraceMethod = ReverseTraceMethod.STOP_TRACE; fTraceMethod = ReverseTraceMethod.STOP_TRACE;
fLastTraceMethod = ReverseTraceMethod.STOP_TRACE; fLastTraceMethod = ReverseTraceMethod.STOP_TRACE;
} }
@ -287,20 +282,20 @@ public class ReverseToggleCommandHandler extends DebugCommandHandler implements
if (fTraceMethod == ReverseTraceMethod.HARDWARE_TRACE) { if (fTraceMethod == ReverseTraceMethod.HARDWARE_TRACE) {
HandlerUtil.updateRadioState(commandService.getCommand(REVERSE_TOGGLE_COMMAND_ID), "UseHardTrace"); //$NON-NLS-1$ HandlerUtil.updateRadioState(commandService.getCommand(REVERSE_TOGGLE_COMMAND_ID), "UseHardTrace"); //$NON-NLS-1$
element.setTooltip(Messages.ReverseDebugging_ToggleHardwareTrace); element.setTooltip(Messages.ReverseDebugging_ToggleHardwareTrace);
element.setIcon(fTracemethodOnImages[1]); element.setIcon(REVERSE_TOGGLE_HARDWARE_ON_IMAGE);
} else if (fTraceMethod == ReverseTraceMethod.FULL_TRACE) { } else if (fTraceMethod == ReverseTraceMethod.FULL_TRACE) {
HandlerUtil.updateRadioState(commandService.getCommand(REVERSE_TOGGLE_COMMAND_ID), "UseSoftTrace"); //$NON-NLS-1$ HandlerUtil.updateRadioState(commandService.getCommand(REVERSE_TOGGLE_COMMAND_ID), "UseSoftTrace"); //$NON-NLS-1$
element.setTooltip(Messages.ReverseDebugging_ToggleSoftwareTrace); element.setTooltip(Messages.ReverseDebugging_ToggleSoftwareTrace);
element.setIcon(fTracemethodOnImages[0]); element.setIcon(REVERSE_TOGGLE_SOFTWARE_ON_IMAGE);
} else { } else {
element.setTooltip(Messages.ReverseDebugging_ToggleReverseDebugging); element.setTooltip(Messages.ReverseDebugging_ToggleReverseDebugging);
HandlerUtil.updateRadioState(commandService.getCommand(REVERSE_TOGGLE_COMMAND_ID), "TraceOff"); //$NON-NLS-1$ HandlerUtil.updateRadioState(commandService.getCommand(REVERSE_TOGGLE_COMMAND_ID), "TraceOff"); //$NON-NLS-1$
if (fLastTraceMethod == ReverseTraceMethod.HARDWARE_TRACE) { if (fLastTraceMethod == ReverseTraceMethod.HARDWARE_TRACE) {
element.setIcon(fTracemethodOffImages[1]); element.setIcon(REVERSE_TOGGLE_HARDWARE_OFF_IMAGE);
} else if (fLastTraceMethod == ReverseTraceMethod.FULL_TRACE) { } else if (fLastTraceMethod == ReverseTraceMethod.FULL_TRACE) {
element.setIcon(fTracemethodOffImages[0]); element.setIcon(REVERSE_TOGGLE_SOFTWARE_OFF_IMAGE);
} else { } else {
element.setIcon(fTracemethodDefaultImage); element.setIcon(REVERSE_TOGGLE_DEFAULT_IMAGE);
} }
} }
} }