From 2ba1428cf1e0eef4b534b7759675a885a73ea114 Mon Sep 17 00:00:00 2001
From: Mikhail Khodjaiants <mikhailkhod@googlemail.com>
Date: Mon, 14 Apr 2003 14:47:28 +0000
Subject: [PATCH] Fixes for toggle actions.

---
 debug/org.eclipse.cdt.debug.ui/ChangeLog               |  7 +++++++
 debug/org.eclipse.cdt.debug.ui/plugin.xml              | 10 ++++++++++
 .../debug/internal/ui/actions/MemoryFormatAction.java  |  3 +--
 .../ui/actions/MemoryNumberOfColumnAction.java         |  3 +--
 .../debug/internal/ui/actions/MemorySizeAction.java    |  3 +--
 5 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/debug/org.eclipse.cdt.debug.ui/ChangeLog b/debug/org.eclipse.cdt.debug.ui/ChangeLog
index c782f088d7d..235496c4ec0 100644
--- a/debug/org.eclipse.cdt.debug.ui/ChangeLog
+++ b/debug/org.eclipse.cdt.debug.ui/ChangeLog
@@ -1,3 +1,10 @@
+2003-04-14 Mikhail Khodjaiants
+	Fixes for toggle actions.
+	* plugin.xml
+	* MemoryFormatAction.java
+	* MemoryNumberOfColumnAction.java
+	* MemorySizeAction.java
+
 2003-04-11 Mikhail Khodjaiants
 	Method and function breakpoints.
 	* plugin.properties
diff --git a/debug/org.eclipse.cdt.debug.ui/plugin.xml b/debug/org.eclipse.cdt.debug.ui/plugin.xml
index 5cbfa0fbe84..a1537cc0ea3 100644
--- a/debug/org.eclipse.cdt.debug.ui/plugin.xml
+++ b/debug/org.eclipse.cdt.debug.ui/plugin.xml
@@ -291,6 +291,7 @@
          </action>
          <action
                label="%ShowFullPathsAction.label"
+               style="toggle"
                icon="icons/full/clcl16/show_paths.gif"
                helpContextId="show_full_paths_action_context"
                class="org.eclipse.cdt.debug.internal.ui.actions.ShowFullPathsAction"
@@ -305,6 +306,7 @@
          </action>
          <action
                label="%SwitchToDisassemblyAction.label"
+               style="toggle"
                icon="icons/full/clcl16/disassembly.gif"
                helpContextId="switch_to_disassembly_action_context"
                class="org.eclipse.cdt.debug.internal.ui.actions.SwitchToDisassemblyActionDelegate"
@@ -320,6 +322,7 @@
          </action>
          <action
                label="%ShowDebuggerConsoleAction.label"
+               style="toggle"
                icon="icons/full/clcl16/debugger_console.gif"
                helpContextId="show_debugger_console_action_context"
                class="org.eclipse.cdt.debug.internal.ui.actions.DebuggerConsoleActionDelegate"
@@ -458,6 +461,7 @@
             id="org.eclipse.cdt.debug.ui.breakpointview.popupMenu">
          <action
                label="%ShowFullPathsAction.label"
+               style="toggle"
                icon="icons/full/clcl16/show_paths.gif"
                helpContextId="show_full_paths_action_context"
                class="org.eclipse.cdt.debug.internal.ui.actions.ShowFullPathsAction"
@@ -733,6 +737,7 @@
             id="org.eclipse.cdt.debug.ui.SharedLibrariesViewPopupActions">
          <action
                label="%ShowFullPathsAction.label"
+               style="toggle"
                icon="icons/full/clcl16/show_paths.gif"
                helpContextId="show_full_paths_action_context"
                class="org.eclipse.cdt.debug.internal.ui.actions.ShowFullPathsAction"
@@ -898,6 +903,7 @@
             </enablement>
          </action>
          <action
+               style="toggle"
                id="org.eclipse.cdt.debug.internal.ui.actions.ShowFullPathsAction"
                toolbarPath="renderGroup"
                hoverIcon="icons/full/clcl16/show_paths.gif"
@@ -915,6 +921,7 @@
             </enablement>
          </action>
          <action
+               style="toggle"
                toolbarPath="renderGroup"
                id="org.eclipse.cdt.debug.internal.ui.actions.SwitchToDisassemblyActionDelegate"
                hoverIcon="icons/full/clcl16/disassembly.gif"
@@ -933,6 +940,7 @@
             </enablement>
          </action>
          <action
+               style="toggle"
                toolbarPath="renderGroup"
                id="org.eclipse.cdt.debug.internal.ui.actions.DebuggerConsoleActionDelegate"
                hoverIcon="icons/full/clcl16/debugger_console.gif"
@@ -955,6 +963,7 @@
             targetID="org.eclipse.debug.ui.BreakpointView"
             id="org.eclipse.cdt.debug.ui.breakpointview.toolbar">
          <action
+               style="toggle"
                id="org.eclipse.cdt.debug.internal.ui.actions.ShowFullPathsAction"
                toolbarPath="renderGroup"
                hoverIcon="icons/full/clcl16/show_paths.gif"
@@ -998,6 +1007,7 @@
             targetID="org.eclipse.cdt.debug.ui.SharedLibrariesView"
             id="org.eclipse.debug.ui.sharedLibrariesView.toolbar">
          <action
+               style="toggle"
                id="org.eclipse.cdt.debug.internal.ui.actions.ShowFullPathsAction"
                toolbarPath="renderGroup"
                hoverIcon="icons/full/clcl16/show_paths.gif"
diff --git a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/MemoryFormatAction.java b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/MemoryFormatAction.java
index 54790c11804..72f4ff5f66d 100644
--- a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/MemoryFormatAction.java
+++ b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/MemoryFormatAction.java
@@ -31,11 +31,10 @@ public class MemoryFormatAction extends Action implements IUpdate
 							   MemoryViewer viewer, 
 							   int format )
 	{
-		super( getLabel( format ) );
+		super( getLabel( format ), Action.AS_CHECK_BOX );
 		fGroup = group;
 		fMemoryViewer = viewer;
 		fFormat = format;
-		setChecked( false );
 	}
 
 	/**
diff --git a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/MemoryNumberOfColumnAction.java b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/MemoryNumberOfColumnAction.java
index f844cace8ca..80cdfde9cf6 100644
--- a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/MemoryNumberOfColumnAction.java
+++ b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/MemoryNumberOfColumnAction.java
@@ -29,11 +29,10 @@ public class MemoryNumberOfColumnAction extends Action implements IUpdate
 							 		   MemoryViewer viewer, 
 							 		   int numberOfColumns )
 	{
-		super( getLabel( numberOfColumns ) );
+		super( getLabel( numberOfColumns ), Action.AS_CHECK_BOX );
 		fGroup = group;
 		fMemoryViewer = viewer;
 		fNumberOfColumns = numberOfColumns;
-		setChecked( false );
 	}
 
 	private static String getLabel( int numberOfColumns )
diff --git a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/MemorySizeAction.java b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/MemorySizeAction.java
index edf235abdbe..ce8dbbeb876 100644
--- a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/MemorySizeAction.java
+++ b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/MemorySizeAction.java
@@ -30,11 +30,10 @@ public class MemorySizeAction extends Action implements IUpdate
 							 MemoryViewer viewer, 
 							 int id )
 	{
-		super( getLabel( id ) );
+		super( getLabel( id ), Action.AS_CHECK_BOX );
 		fGroup = group;
 		fMemoryViewer = viewer;
 		fId = id;
-		setChecked( false );
 	}
 
 	/* (non-Javadoc)