mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-08 10:16:03 +02:00
Code Issues Wiki Activity

Bug Fixing

Browse source
This commit is contained in:
Hoda Amer 2004-06-17 15:28:42 +00:00
parent e92ee9c4db
commit 2b26b06747
4 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
core/org.eclipse.cdt.ui/ChangeLog
View file

@ -1,3 +1,6 @@
2004-06-17 Hoda Amer
Fix for PR 63933: [Refactoring] compilation errors does not prevent rename refactoring
2004-06-16 Hoda Amer 2004-06-16 Hoda Amer
Fix for PR 66730: [Refactoring] Renaming a class does not change .cpp file. Fix for PR 66730: [Refactoring] Renaming a class does not change .cpp file.
Fix for PR 61045: [Accessibility] Code Templates Preview box has no MSAA name Fix for PR 61045: [Accessibility] Code Templates Preview box has no MSAA name

5
core/org.eclipse.cdt.ui/refactor/org/eclipse/cdt/internal/corext/refactoring/Checks.java
View file

@ -175,7 +175,7 @@ public class Checks {
if (tu == null) if (tu == null)
return RefactoringStatus.createFatalErrorStatus(RefactoringCoreMessages.getString("Checks.cu_not_created")); //$NON-NLS-1$ return RefactoringStatus.createFatalErrorStatus(RefactoringCoreMessages.getString("Checks.cu_not_created")); //$NON-NLS-1$
else if (! tu.isStructureKnown()) else if (! tu.isStructureKnown())
return RefactoringStatus.createErrorStatus(RefactoringCoreMessages.getString("Checks.cu_not_parsed")); //$NON-NLS-1$ return RefactoringStatus.createFatalErrorStatus(RefactoringCoreMessages.getString("Checks.cu_not_parsed")); //$NON-NLS-1$
return new RefactoringStatus(); return new RefactoringStatus();
} }
//-------- validateEdit checks ---- //-------- validateEdit checks ----
@ -227,6 +227,9 @@ public class Checks {
if ((!wasEmpty) && result.isEmpty()) if ((!wasEmpty) && result.isEmpty())
status.addFatalError(RefactoringCoreMessages.getString("Checks.all_excluded")); //$NON-NLS-1$ status.addFatalError(RefactoringCoreMessages.getString("Checks.all_excluded")); //$NON-NLS-1$
else if (result.isEmpty()){
status.addFatalError(RefactoringCoreMessages.getString("Checks.no_files"));
}
return (SearchResultGroup[])result.toArray(new SearchResultGroup[result.size()]); return (SearchResultGroup[])result.toArray(new SearchResultGroup[result.size()]);
} }

3
core/org.eclipse.cdt.ui/refactor/org/eclipse/cdt/internal/corext/refactoring/refactoring.properties
View file

@ -34,6 +34,7 @@ Checks.constructor_name= If you proceed, the method {0} in ''{1}'' will have a c
Checks.method_names_lowercase=This name is discouraged. According to convention, names of methods should start with lowercase letters Checks.method_names_lowercase=This name is discouraged. According to convention, names of methods should start with lowercase letters
Checks.error.InvalidClassName=Class name is not valid. {0} Checks.error.InvalidClassName=Class name is not valid. {0}
Checks.warning.ClassNameDiscouraged=Class name is discouraged. {0} Checks.warning.ClassNameDiscouraged=Class name is discouraged. {0}
Checks.no_files=No files are found.
####################################### #######################################
# org.eclipse.jdt.internal.core.refactoring.base # org.eclipse.jdt.internal.core.refactoring.base
@ -346,7 +347,7 @@ RenameTypeRefactoring.member_type=Member Type declared inside ''{0}'' is named {
RenameTypeRefactoring.another_type=Another type named ''{0} is referenced in ''{1}'' RenameTypeRefactoring.another_type=Another type named ''{0} is referenced in ''{1}''
RenameTypeRefactoring.wrong_element=Rename refactoring does not handle this type of element. RenameTypeRefactoring.wrong_element=Rename refactoring does not handle this type of element.
RenameTypeRefactoring.virtual_method=Renaming a virtual method. Consider renaming the base and derived class methods (if any). RenameTypeRefactoring.virtual_method=Renaming a virtual method. Consider renaming the base and derived class methods (if any).
RenameTypeRefactoring.no_files=No files are found.
TextMatchFinder.comment=text reference update in a comment TextMatchFinder.comment=text reference update in a comment

9
core/org.eclipse.cdt.ui/refactor/org/eclipse/cdt/internal/corext/refactoring/rename/RenameElementProcessor.java
View file

@ -317,13 +317,10 @@ public class RenameElementProcessor extends RenameProcessor implements IReferenc
pm.setTaskName(RefactoringCoreMessages.getString("RenameTypeRefactoring.checking")); //$NON-NLS-1$ pm.setTaskName(RefactoringCoreMessages.getString("RenameTypeRefactoring.checking")); //$NON-NLS-1$
if (pm.isCanceled()) if (pm.isCanceled())
throw new OperationCanceledException(); throw new OperationCanceledException();
if (fReferences.length == 0){
result.addFatalError(RefactoringCoreMessages.getString("RenameTypeRefactoring.no_files"));
}
if (result.hasFatalError()) if (result.hasFatalError())
return result; return result;
// more checks go here // more checks go here
fChangeManager= createChangeManager(new SubProgressMonitor(pm, 35)); fChangeManager= createChangeManager(new SubProgressMonitor(pm, 35));
pm.worked(5); pm.worked(5);